From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B491C7EE30 for ; Wed, 25 Jun 2025 09:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=powAaYkRIeBMj70egbbj/us5VriLMTXfcIoRJEQWmnY=; b=UV0MjlSXAbUIy8dYDE87haM67h s4AmAs5jipt0tp9b/QRz0Sz2xOaqxKvIzpGyyfamsGTzr4MqRWR/f+SReYN7Dy7Szq0TvjjSYsmrH CTXKI3RI8yGb9/zbByA8GJkIUuYMF+c7nlVhTTzInJLBMEliPx9jtDLHxIwGuVHIpe5q5HbyOsalg N1DxZurPXSjSiLIu/v7FdCSVY529ZALPG2iUWxOD7+vZc9NWUMuY/OzGKtF7eKoJZUPh3wYeZdHDy WSKMLjVj+BsD6duE/5RYj39fKzh7hwRVjnMJf2vsVKOhbHosNsfrd+6oWyabqD67yI7nght+B4shF MmqR8C8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUMI6-000000086fL-3KGN; Wed, 25 Jun 2025 09:19:38 +0000 Received: from leonov.paulk.fr ([185.233.101.22]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uULcR-00000007yXb-2bfk; Wed, 25 Jun 2025 08:36:37 +0000 Received: from laika.paulk.fr (12.234.24.109.rev.sfr.net [109.24.234.12]) by leonov.paulk.fr (Postfix) with ESMTPS id 9EBCA1F00036; Wed, 25 Jun 2025 08:36:32 +0000 (UTC) Received: by laika.paulk.fr (Postfix, from userid 65534) id 392B0AC7A3C; Wed, 25 Jun 2025 08:36:31 +0000 (UTC) Received: from shepard (unknown [192.168.1.1]) by laika.paulk.fr (Postfix) with ESMTPSA id 0CA55AC7A32; Wed, 25 Jun 2025 08:36:30 +0000 (UTC) Date: Wed, 25 Jun 2025 10:36:28 +0200 From: Paul Kocialkowski To: Kuba =?utf-8?Q?Szczodrzy=C5=84ski?= Cc: Maxime Ripard , Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Airlie , Simona Vetter , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/5] drm/sun4i: Support LVDS using MIPI DSI combo D-PHY Message-ID: References: <20250221161751.1278049-1-kuba@szczodrzynski.pl> <20250221161751.1278049-3-kuba@szczodrzynski.pl> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250625_013635_819969_5EBF7B05 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8103929654901913424==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============8103929654901913424== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mMddwFhTjlnTEsAi" Content-Disposition: inline --mMddwFhTjlnTEsAi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 25 Jun 25, 10:03, Paul Kocialkowski wrote: > On Fri 21 Feb 25, 17:17, Kuba Szczodrzy=C5=84ski wrote: > > @@ -183,6 +184,8 @@ static void sun4i_tcon_lvds_set_status(struct sun4i= _tcon *tcon, > > } else { > > regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_IF_REG, > > SUN4I_TCON0_LVDS_IF_EN, 0); >=20 > Does the T113-S3/D1 also have LVDS support in TCON regsiters? > My understanding is that it only has the combo-phy, so this register write > should not take place. >=20 > I think it would be easier to just move this to a common callback for use= rs of > the tcon0 lvds phy and always call=20 Nevermind this comment, the LVDS_IF writes are actually necessary and independent from the LVDS PHY configuration. All the best, Paul --=20 Paul Kocialkowski, Independent contractor - sys-base - https://www.sys-base.io/ Free software developer - https://www.paulk.fr/ Expert in multimedia, graphics and embedded hardware support with Linux. --mMddwFhTjlnTEsAi Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEAbcMXZQMtj1fphLChP3B6o/ulQwFAmhbtQwACgkQhP3B6o/u lQxNJQ/+NRLOuDtviPYOloG5xp+nX3B4qO2FXp19IWGBOrz/SEL34AfiP1Bb30fu 7uwvYvURCKtY9J68zna5ovG4mex4pLo5sA81xZVc/1Cs5+7pMV2F2ixnPkAWHP6i um3pIEKP5amDFP9DCAVAchAAQdZHD5D4+FZlu9Mw5CCWt0XToXkUpmfcExA07kzD KnlpKPJhc1DPgXku5izWrAkrgAC0k8uMlENVclI0djMw67aO7vOyqIJpABp5ZOe4 oHIsanTWy3/2PWx2RyrXdvrXwUaZRcJUmbezq+VOxyqtVY+IytVWHj13l2CzL+eu dyKm538s55HpwBvEbo9vYiFvLMRaMct637GGK9Z3TG2khO6LJHtBZ8nvfEHCBVmu vUxTCl6/Mm7HEm6Wkg2wOzeBc94OsYYib2WDnPJ2TnmB2vWua9Nk96t5TQ48qOQT J/N1sRyvy3iBX2U+gYCS9bb2SmQ+yVDSoIulX25hTqypn5peaJgQh9miq4UtC21M 4F73RP0zjS6Dn/1Hw7lE3l/M7Pd169b5ymguuxorKg+rGDpz62TMsClNQr/tPg9M NPUZK7YW4s+O3VOXjkAy/aj+iQ8gTVvifRn14lB+lYQFPcnb82l2Ra+x6YnRTo// 6VzXsjUgV9sGRYKxcau8DQPfRDfKrZNpruYazhAOToyO96tvKiY= =o01Z -----END PGP SIGNATURE----- --mMddwFhTjlnTEsAi-- --===============8103929654901913424== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============8103929654901913424==--