From: Vinod Koul <vkoul@kernel.org>
To: Yulin Lu <luyulin@eswincomputing.com>
Cc: dlemoal@kernel.org, cassel@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kishon@kernel.org,
linux-phy@lists.infradead.org, ningyu@eswincomputing.com,
zhengyu@eswincomputing.com, linmin@eswincomputing.com,
huangyifeng@eswincomputing.com, fenglin@eswincomputing.com,
lianghujun@eswincomputing.com
Subject: Re: [PATCH v2 3/3] phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver
Date: Wed, 20 Aug 2025 21:37:36 +0530 [thread overview]
Message-ID: <aKXyyAT-xRPhoYDx@vaman> (raw)
In-Reply-To: <20250819140043.1862-1-luyulin@eswincomputing.com>
On 19-08-25, 22:00, Yulin Lu wrote:
> From: luyulin <luyulin@eswincomputing.com>
>
> Created the eswin phy driver directory and added support for
> the SATA phy driver on the EIC7700 SoC platform.
>
> Signed-off-by: luyulin <luyulin@eswincomputing.com>
Please use full name as you have used in the copyright notices
> +#define SATA_P0_PHY_TX_PREEMPH_GEN2 (0x05 << 8)
> +#define SATA_P0_PHY_TX_PREEMPH_GEN3 (0x08 << 16)
> +#define SATA_MPLL_MULTIPLIER (0x3c << 16)
Use GENMASK for these
> +static int eic7700_sata_phy_init(struct phy *phy)
> +{
> + struct eic7700_sata_phy *sata_phy = phy_get_drvdata(phy);
> + u32 val = 0;
> + int ret = 0;
both initializations are superfluous
> +static int eic7700_sata_phy_exit(struct phy *phy)
> +{
> + struct eic7700_sata_phy *sata_phy = phy_get_drvdata(phy);
> + u32 val = 0;
here and other places
> +static struct platform_driver eic7700_sata_phy_driver = {
> + .probe = eic7700_sata_phy_probe,
> + .driver = {
> + .of_match_table = eic7700_sata_phy_of_match,
> + .name = "eswin,sata-phy",
> + .suppress_bind_attrs = true,
why?
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-08-20 20:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 13:47 [PATCH v2 0/3] ESWIN EIC7700 sata phy driver and yaml, Yulin Lu
2025-08-19 13:54 ` [PATCH v2 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci Yulin Lu
2025-08-19 14:25 ` Rob Herring
2025-08-25 8:19 ` luyulin
2025-08-28 10:22 ` luyulin
2025-08-28 13:05 ` Niklas Cassel
2025-08-29 6:22 ` luyulin
2025-08-19 14:00 ` [PATCH v2 3/3] phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver Yulin Lu
2025-08-20 16:07 ` Vinod Koul [this message]
2025-08-21 8:41 ` kernel test robot
2025-08-20 9:27 ` [PATCH v2 2/3] dt-bindings: phy: eswin: Document for EIC7700 SoC SATA PHY Yulin Lu
2025-08-21 7:55 ` Krzysztof Kozlowski
2025-08-26 3:23 ` luyulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXyyAT-xRPhoYDx@vaman \
--to=vkoul@kernel.org \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=fenglin@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lianghujun@eswincomputing.com \
--cc=linmin@eswincomputing.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=luyulin@eswincomputing.com \
--cc=ningyu@eswincomputing.com \
--cc=robh@kernel.org \
--cc=zhengyu@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox