From: Niklas Cassel <cassel@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Yulin Lu <luyulin@eswincomputing.com>,
dlemoal@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
vkoul@kernel.org, kishon@kernel.org,
linux-phy@lists.infradead.org, ningyu@eswincomputing.com,
zhengyu@eswincomputing.com, linmin@eswincomputing.com,
huangyifeng@eswincomputing.com, fenglin@eswincomputing.com,
lianghujun@eswincomputing.com
Subject: Re: [PATCH v3 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci
Date: Thu, 4 Sep 2025 11:14:57 +0200 [thread overview]
Message-ID: <aLlYkZWBaI5Yz6fo@ryzen> (raw)
In-Reply-To: <8489c13b-6810-480c-9894-bb5c80cfbde0@kernel.org>
Hello Krzysztof, Rob,
On Thu, Sep 04, 2025 at 09:10:34AM +0200, Krzysztof Kozlowski wrote:
> > +
> > + ports-implemented:
> > + const: 1
>
> I do not see how you addressed request about firmware. Nothing changed
> here, no explanation in the commit msg.
In Yulin's defence, he did comment that when having the Ports Implemented
register initialized by firmware, the Ports Implemented register apparently
gets cleared to zero when rmmoding the driver (probably because it disables
the clocks and regulators to the controller), thus this suggestion breaks
the use case of being able to reload the driver (rmmod + insmod).
He mentioned this, and asked for advice here:
https://lore.kernel.org/linux-ide/2cc9f2ff.6a2.198e04fd36e.Coremail.luyulin@eswincomputing.com/
After no reply he asked the same question again:
https://lore.kernel.org/linux-ide/692e11ca.843.198f0337528.Coremail.luyulin@eswincomputing.com/
I assume that Rob simply missed those messages.
Anyway, I provided my 50 cents here:
https://lore.kernel.org/linux-ide/aLBUC116MdJqDGIJ@flawful.org/
(I would like to add that I think it is the disabling of clocks and
regulators that causes the register to be cleared, since we do call
ahci_platform_assert_rsts() during the first probe, so if it was the reset
that cleared the register, the first probe should also not have worked.)
Not sure if it relevant to mention this reply to Rob's review comment in the
commit message, but perhaps it should have been mentioned in the change log.
Kind regards,
Niklas
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-09-04 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 6:34 [PATCH v3 0/3] Add driver support for Eswin EIC7700 SoC SATA Controller and PHY Yulin Lu
2025-09-04 6:37 ` [PATCH v3 1/3] dt-bindings: ata: eswin: Document for EIC7700 SoC ahci Yulin Lu
2025-09-04 7:10 ` Krzysztof Kozlowski
2025-09-04 9:14 ` Niklas Cassel [this message]
2025-09-04 9:50 ` Krzysztof Kozlowski
2025-09-05 7:23 ` luyulin
2025-09-04 6:38 ` [PATCH v3 2/3] dt-bindings: phy: eswin: Document for EIC7700 SoC SATA PHY Yulin Lu
2025-09-04 7:11 ` Krzysztof Kozlowski
2025-09-04 6:38 ` [PATCH v3 3/3] phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver Yulin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLlYkZWBaI5Yz6fo@ryzen \
--to=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=fenglin@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lianghujun@eswincomputing.com \
--cc=linmin@eswincomputing.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=luyulin@eswincomputing.com \
--cc=ningyu@eswincomputing.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=zhengyu@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).