From: Frank Li <Frank.li@nxp.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Haibo Chen <haibo.chen@nxp.com>,
linux-can@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/9] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048
Date: Thu, 4 Sep 2025 10:17:13 -0400 [thread overview]
Message-ID: <aLmfaZQcsd8zqY/i@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250904-can-v5-1-23d8129b5e5d@nxp.com>
On Thu, Sep 04, 2025 at 04:36:44PM +0800, Peng Fan wrote:
> The TJA1048 is a dual high-speed CAN transceiver with sleep mode supported
> and no EN pin.
>
> The TJA1051 is a high-speed CAN transceiver with slient mode supported,
> but only TJA1051T/E has EN pin. To make it simple, make enable-gpios as
> optional for TJA1051.
>
> The TJA1057 is a high-speed CAN transceiver with slient mode supported
> and no EN pin.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 69 +++++++++++++++++++++-
> 1 file changed, 66 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> index 4a8c3829d85d3c4a4963750d03567c1c345beb91..124493f360516eb203e8711cb96789258dd01119 100644
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -22,16 +22,26 @@ properties:
> - enum:
> - ti,tcan1042
> - ti,tcan1043
> + - nxp,tja1048
> + - nxp,tja1051
> + - nxp,tja1057
> - nxp,tjr1443
>
> '#phy-cells':
> - const: 0
> + enum: [0, 1]
>
> - standby-gpios:
> + silent-gpios:
> description:
> - gpio node to toggle standby signal on transceiver
> + gpio node to toggle silent signal on transceiver
> maxItems: 1
>
> + standby-gpios:
> + description:
> + gpio node to toggle standby signal on transceiver. For two Items, item 1
> + is for stbn1, item 2 is for stbn2.
> + minItems: 1
> + maxItems: 2
> +
> enable-gpios:
> description:
> gpio node to toggle enable signal on transceiver
> @@ -53,6 +63,59 @@ required:
> - compatible
> - '#phy-cells'
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nxp,tja1048
> + then:
> + properties:
> + '#phy-cells':
> + const: 1
> + enable-gpios: false
> + silent-gpios: false
> + standby-gpios:
> + minItems: 2
> + else:
> + properties:
> + '#phy-cells':
> + const: 0
> + standby-gpios:
> + maxItems: 1
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - nxp,tja1051
> + - nxp,tja1057
> + then:
> + properties:
> + silent-gpios: true
> + else:
> + properties:
> + silent-gpios: false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nxp,tja1051
> + then:
> + properties:
> + standby-gpios: false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nxp,tja1057
> + then:
> + properties:
> + enable-gpios: false
> + standby-gpios: false
> +
> additionalProperties: false
>
> examples:
>
> --
> 2.37.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-09-04 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 8:36 [PATCH v5 0/9] phy: phy-can-transceiver: Support TJA1048/TJA1051 Peng Fan
2025-09-04 8:36 ` [PATCH v5 1/9] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048 Peng Fan
2025-09-04 14:17 ` Frank Li [this message]
2025-09-05 7:52 ` Krzysztof Kozlowski
2025-09-05 13:11 ` Peng Fan
2025-09-04 8:36 ` [PATCH v5 2/9] phy: phy-can-transceiver: Introduce can_transceiver_priv Peng Fan
2025-09-04 8:36 ` [PATCH v5 3/9] phy: phy-can-transceiver: Add dual channel support for TJA1048 Peng Fan
2025-09-04 8:36 ` [PATCH v5 4/9] phy: phy-can-transceiver: Drop the gpio desc check Peng Fan
2025-09-04 14:18 ` Frank Li
2025-09-04 8:36 ` [PATCH v5 5/9] phy: phy-can-transceiver: Propagate return value of gpiod_set_value_cansleep Peng Fan
2025-09-04 14:20 ` Frank Li
2025-09-04 8:36 ` [PATCH v5 6/9] phy: phy-can-transceiver: Add support for TJA105{1,7} Peng Fan
2025-09-04 14:22 ` Frank Li
2025-09-04 8:36 ` [PATCH v5 7/9] arm64: dts: imx95-15x15-evk: Use phys to replace xceiver-supply Peng Fan
2025-09-04 8:36 ` [PATCH v5 8/9] arm64: dts: imx8mp-evk: " Peng Fan
2025-09-04 8:36 ` [PATCH v5 9/9] arm64: dts: imx93-11x11-evk: " Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLmfaZQcsd8zqY/i@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=a-govindraju@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox