From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EF59CA1012 for ; Thu, 4 Sep 2025 18:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Pab6vylyT18053W6/0sME1+jwAOPDKPbXN3JbrLf0U=; b=cbWbMDhGkQEcDT kXkZuoIsqWTN9O3b/Loeg0lNlDAGAhL06yAA8cj3QICGJu+2yKL0HHdC+dnLc2HjddRsrvxWxsIzv 9mZdmMsiBITU6oxc/m908iQBj+3kBzqlymS3o3szDgvGk7HWajfle4/lhzfpM/pNln/dmoyop4hIn Tl/hNTTuZQ61hSahR9a8fYe3XDxlX+j7Twk3OVbKT69/muvKkhHKBDY8rmnZwZimLxWbDBIJuEnmR pOC7MKH/Lt3eUofgtG7c3xodeOzhtZyFLFoeLsd+NaUOi/EQo+PspC2XWLWq9yDeKlR/zE/dKWpOi /yVFyPGU25RhMD+9RD7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uuEmF-0000000DdJN-3kFh; Thu, 04 Sep 2025 18:33:43 +0000 Received: from mail-northeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c200::3] helo=DU2PR03CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uuAnY-0000000C9lg-1EXq; Thu, 04 Sep 2025 14:18:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ALC5jrxNMOdPeYsvDk6udKGBEo7szYPxMvre7mxjaIGFeOsDRzclGCEAvmUTjBbA87FQvz8bl19jb6VS9z7pGn08OAe4uQF+ItYY4yhWgmGtXZRhCiOwenTGT1Qs+CGGM33oHDSFoC3WWjOjx0F07fVGH4XBae6wNqilzPL37uF+MCsXyl5SeQ2Mc+S2M6wqEhvtI1kNFgDNsqIRPPxlGAJHeTXAFWBHvXmcfIjPMxjAbjSGyJHuq/o3ILM/o6hi365ilynogpkNZ+UZOlbuUZP7aPqzYAkOgvEO3l1ljb95uuF994DYSN1ToBKIP0dNVB2ilfkTEiQ5e0N2Sz2gKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EYptEAC0Qgw5z9/pWSxwLA7cBiJQO2jRppGgWvFW4pE=; b=PhNt0Js4rrFvT8aLCap+m1IqF3jg9UegMN8wouw6BhTl1E2z6x5V0ImVHlewubN6yOzIizC0feeXArL91qlREaB3SJJks2USZNx1SRCk9LQobuPMQXCLNisBDXHfEwSsTQlsJWxMw/EQsAlFwaiujNPSGlixTrr5je/YRPEkaMYkY7TyqEVjz8qmu49tWib4uoKvMDqu2K70W5mF+VMNsHQvQ8SUpsGISARJLvCWyvjtwULF+9FExRvrtqU354peB/uFawcksZAFuEFivGHWQq7ynD74nrCpmtuG/Pu8oDpI8PGMYdgDsb0Yob5yavSPl70O6Sz2oKESW40SLU57ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EYptEAC0Qgw5z9/pWSxwLA7cBiJQO2jRppGgWvFW4pE=; b=Ob0IXTygonjJLciDCl5pFWd9lFWuImEExWpfVVCylRu2wABcp2R+yty7JRVwNLmjsx3uYBBhWKmO2WFWnUdEvrC1cZ/oDTixne1UNe/fOxtKz+zqUn3WRZoHKtxUxIz/UMbVJ8Z2lq1NcviilIxKIySUButkHPgajS7OW4AZkfs+o1JLYP5CMtGFUo6ZVdizAlDzdi0SI0n0gvZ565rITRq6rxQ6D+1S1ucVo3un1HIXvw9EFMW3aQlEtKLepcLsCdCsGHv+6hhtYrtENqqCQevgaXIHAcAFAKriHtJP9H1o7VQ3Z/XriFULpIbbtAotKyEvB6iNDykAn8W9Q4xVcA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by AM8PR04MB7380.eurprd04.prod.outlook.com (2603:10a6:20b:1d5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.16; Thu, 4 Sep 2025 14:18:40 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::55ef:fa41:b021:b5dd]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::55ef:fa41:b021:b5dd%5]) with mapi id 15.20.9094.015; Thu, 4 Sep 2025 14:18:40 +0000 Date: Thu, 4 Sep 2025 10:18:32 -0400 From: Frank Li To: Peng Fan Cc: Marc Kleine-Budde , Vincent Mailhol , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Aswath Govindraju , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Haibo Chen , linux-can@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 4/9] phy: phy-can-transceiver: Drop the gpio desc check Message-ID: References: <20250904-can-v5-0-23d8129b5e5d@nxp.com> <20250904-can-v5-4-23d8129b5e5d@nxp.com> Content-Disposition: inline In-Reply-To: <20250904-can-v5-4-23d8129b5e5d@nxp.com> X-ClientProxiedBy: PH7P223CA0014.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:338::24) To DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|AM8PR04MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c71e5ab-34c8-43b3-118d-08ddebbdf273 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|52116014|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LVV9tghFx0KWK6bUFG+6rBn/tuWDTaa2AIeZVLoSYwAnS2ymxlVveMA+8l+b?= =?us-ascii?Q?cCCZrr7o/GRgJByJ8q61wd6KpsFrPhP5/VmJeMx8FmmOyNdz/uUBd0UFN917?= =?us-ascii?Q?e5gtWh9f1P7ffLTghOFnH4skI6ppxshof0d77EBkfwQuDeMA9B+4oVViqzdJ?= =?us-ascii?Q?FSTvvJR3sLPXgkEfg5k6Ah5n91a+6Dymi8PNTKDVcm7r+nqbNPjpIm5g80pd?= =?us-ascii?Q?XJLJtP/kfGFomDyByRzKtB6Kr2W7Vlty/ODWVOBPQ0n1DUak4q9f0QR2EVVW?= =?us-ascii?Q?wpFSuVaIKKwidQ749mAF4aOhbrVAwXGcjhFwb7jNal0FyMJuXUqjHUIA5ZZT?= =?us-ascii?Q?fCbuUSsf6bBywfrOa9774OOLaEY5e5rswgMSotzrU26/y8iqdESxF8xGlgTB?= =?us-ascii?Q?s9waSETqdPtRJeRbN8tu2FbxS8OCo7BNtWxici83yzsw4O16bp0fPGPkcAHr?= =?us-ascii?Q?M3ZnYYYwtnQK51gH8FrVOaW4aB6rqfZbfV9BXN+E81Xq7R3s7PipfLmHk1SC?= =?us-ascii?Q?FFa9sq3RjfKZUVfYyQn1OAlQli+qtyUdvO/c2gn9ZQifEjuiU8xrVMP5l4Za?= =?us-ascii?Q?bdzPfMdIziJJ/ZXeQPRXSRf3rR0rp+kLBY2GqiO7rSnU4uEhZW9wrHJx19CR?= =?us-ascii?Q?/wVsTm8qO9m4rTfN7hxpQwrUNZRxAdmgd6bOtJGtnqdvWA5D/9EcAuwvMsfT?= =?us-ascii?Q?d0AdkrSHRA6ucp43CEINgW2TR+fViMkUmA83Aaa6TC3AIr5GykW20DTlvO0J?= =?us-ascii?Q?MwYT5Kt1dyx0ATwNz5JkyCoA2U24uQQFVh3A4YiDJZS1P0Dh5xbFZpi+LkhI?= =?us-ascii?Q?nUY0nWysSXUnnlHVOoN7sGjJFdr5Lu9ARU/j0t7pSQhIVEsRLUJmcjXdyPDn?= =?us-ascii?Q?4ytJXSzjrRfBKPUdC7IuQvBq+McIhMryz7vdr83rCgnYx8tLyvfP6GBHRlYj?= =?us-ascii?Q?S7G4xrdiQnv1CHp5MEyJ1ln1xmlkl3TKoqpyXT12q3HjX+INbFAXE6DW5npy?= =?us-ascii?Q?9Se1TiPBh6XRzD8ZRpbu+K542dQdGeXIpOU4J/zTcJ14AB1HsNpppQBiTcoM?= =?us-ascii?Q?p+8F0b8wbs1oXzgroOjjeuUkENbsGArHX8osQOKx4Zn1RQb2HOuBupFOk8aT?= =?us-ascii?Q?2e/SbCrFfPT22WPy8hdmUvnl2aAs0pz3v6GqjQahb2veItOjk601iU8N7oKT?= =?us-ascii?Q?w0IIr9qW+xEOy/Mt0n4fIiOfsYSdtNy3+NIYFkmUm6HZINocXJBbsnmMJZhi?= =?us-ascii?Q?r9u3z5K7catcOqtZI6XuxxMIxX55lrVKYm76iFbH0Wt4Z0WGm0dE7iwQF1Sg?= =?us-ascii?Q?8hu8wSjIu+6097L0rEOWee/oSMhfgPYdYVZ1Qdy4Tu3Q75XWdYeizjkoZG7r?= =?us-ascii?Q?Z5FOMo5HZdm5mAeGD8/XsOnT1HDDvboeGfJN16Fnx0djr3SvMaqOgX58F8Up?= =?us-ascii?Q?CsACAM/wnF6ISrGldCk11I1TpIj5QRpA2AOaz2AjNWDXylXHRUQXIg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(52116014)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fcUjYWDWHCx1Y7L8NxKWdGfaWt8rU6bMe8ALg6rfWZv98/oVEYg0B/vrcFaU?= =?us-ascii?Q?Qe8kQ0soWGlDBC5F6Q85mnxyQSYaQEa6eOtHRSS28FaIBicAodHGqGcREPHn?= =?us-ascii?Q?QrRmaqZvQ7fg4Cw9yS1a9ugIMKnHCZpgJ6l2O9juGrTzfR059DgKMpmJIQJ1?= =?us-ascii?Q?fvKALPPPFZdchIh6qI1sx89ukMtmLmC4Xqx/YWDwjjqIc8A5en5vPON4m8m4?= =?us-ascii?Q?zJhqzG145t4BET5FF8NgW33iP8PR1+0jAPm0S3bnmxofR3pSiXZMD1GyapaG?= =?us-ascii?Q?e2RJOrIYYLpf4eFm8Uuk0h2N/luMUrEOMgrzJtaWOmnHHUx43KXnCWatxmVK?= =?us-ascii?Q?XFJTfBv55zkSAnGhWpXSZ5w7rRRzbvT0qCMTCvYn64gploY34NdJ2dzW5gPG?= =?us-ascii?Q?cg3z6LowFvrAH8eYL4yHbLa1lrPiGkO4UbvxIYU4oQuYI7XEBtzkWO9rOaMU?= =?us-ascii?Q?I/52rWTZ5fLqB8aLYFRKOq66FxMFJht29feB9+M6HpRJawRekKc8JAunK/go?= =?us-ascii?Q?a9TxxinqRGCU8Bi9W2J/Dfp/YPZUiCClWXIwAFuEFp5gWCZNDAxfmUkCrCS3?= =?us-ascii?Q?1j4eIJsiFToqPRCHJ6LxCPH6oMOxug3JeOA5yUNl6ooW8My322v2zYjtULl/?= =?us-ascii?Q?CTusSeHRVm+gJFWytzY3r8wepMvRMD/YyoYi0H1vZUUrmvVjX/Zg/3lc2G4G?= =?us-ascii?Q?RKS9L8djg0Y2JUMYojEQiSJw9wIEd3HV797q3y+vt/yNBDzOK86HlGoP+ZL1?= =?us-ascii?Q?QuSA8fC3BfNwn01cdO/utvnohlHKtCetqgII3+W26hV6oy8Brk9qPyK21izf?= =?us-ascii?Q?cNaX18NAVmH7yRHdBu/5PKHRFk8XNl6vyhHyvllr0emMOCNeUKGESWRnIxtG?= =?us-ascii?Q?RBpVkmMun5quzaHObyazij3gbnr4UsKFbDUc4v4JoRvXXmJCPTyaBRhCWY3s?= =?us-ascii?Q?6b5BPf0fYAWuXCITYF1O0Zr5Gplryn5ORqNvu69Ot0Ysv76yf65fYDbCZMXI?= =?us-ascii?Q?SDFX8ISVOcAVVIloRG+0gnyx2VDT59KLhWidNuh6oiFvD+AFPj/fTs6MZ/cc?= =?us-ascii?Q?UOzSyb15G7ajGhp2yDXDO+l8ehFUEdwbh2bmn/5SjxoWsK0s7KqkLD74ghXe?= =?us-ascii?Q?Vb4lUy/cU7A/5XCEu5JTvxW2cWvpjdb+osBUCs/Os9FqkwA52fCYEF9gjHoj?= =?us-ascii?Q?plZAO2AKa1lOyXIrNL1B8IOfbIr8cbB64bR7PrUatwZ4Ib3CtCHr8SVZmMzb?= =?us-ascii?Q?egYs+nXkhQ8n0eBPW5bv7ILkKWzfyu9ldAJNNTfgxEOquOTfumGka2lBrB12?= =?us-ascii?Q?vkixKTzKekMpduNxHGPm13kMt0bPFKtgkZX97dD4A2pItT3xZsjPafdekHq4?= =?us-ascii?Q?4cQdxjhWEYLlFpGN/WKl33WC3McnQIESk87Zg7V2i4A3foVnWD7YqTUtliwC?= =?us-ascii?Q?t9ntXfkkA1u4mek9yQqFdD8jOK+nyTh30YHOf+ENtw0I+CnDc9RGKY3Q4Ot7?= =?us-ascii?Q?3adoKeTI9UGaS8QpvHPdNnQrp/uHCQnbbYJghqn4C1uRWVu1Go0J2nROejpV?= =?us-ascii?Q?pUDwUx96F6Y5umAm3U3slw2zFCiQcPdAImAauupa?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c71e5ab-34c8-43b3-118d-08ddebbdf273 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2025 14:18:40.8510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bMkclWMrgi9S2+v4McQUZUCJvXhyttxQS09+4WncNOE8it/QqY0NTqrO/q2y5/GcanSLkJVKJ3jdxBdrk8J9Ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7380 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250904_071848_332991_FDB7568B X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Sep 04, 2025 at 04:36:47PM +0800, Peng Fan wrote: > gpiod_set_value_cansleep has an internal check on gpio_desc using > 'VALIDATE_DESC(desc)', the check before invoking gpiod_set_value_cansleep > could be removed. > > Signed-off-by: Peng Fan Reviewed-by: Frank Li > --- > drivers/phy/phy-can-transceiver.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c > index f06b1df76ada023f432dce892c3346f45397ab54..b7d75a78d9242e2003660a87d2d4c9f784aea523 100644 > --- a/drivers/phy/phy-can-transceiver.c > +++ b/drivers/phy/phy-can-transceiver.c > @@ -46,10 +46,8 @@ static int can_transceiver_phy_power_on(struct phy *phy) > return ret; > } > } > - if (can_transceiver_phy->standby_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0); > - if (can_transceiver_phy->enable_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1); > + gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0); > + gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1); > > return 0; > } > @@ -59,10 +57,8 @@ static int can_transceiver_phy_power_off(struct phy *phy) > { > struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy); > > - if (can_transceiver_phy->standby_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1); > - if (can_transceiver_phy->enable_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0); > + gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1); > + gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0); > if (can_transceiver_phy->priv->mux_state) > mux_state_deselect(can_transceiver_phy->priv->mux_state); > > > -- > 2.37.1 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy