Re: [PATCH v9 4/6] phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920

Vinod Koul
2025-11-21T10:24:41Z

On 21-11-25, 13:36, Pritam Manohar Sutar wrote:
> Hi Vinod,
>
> > -----Original Message-----
> > From: Vinod Koul <vkoul@kernel.org>
> > Sent: 20 November 2025 10:07 PM
> > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> > Cc: kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> > conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org;
> > peter.griffin@linaro.org; kauschluss@disroot.org; johan@kernel.org;
> > ivo.ivanov.ivanov1@gmail.com; m.szyprowski@samsung.com;
> > s.nawrocki@samsung.com; linux-phy@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> > rosa.pila@samsung.com; dev.tailor@samsung.com;
> > faraz.ata@samsung.com; muhammed.ali@samsung.com;
> > selvarasu.g@samsung.com
> > Subject: Re: [PATCH v9 4/6] phy: exynos5-usbdrd: support HS combo phy for
> > ExynosAutov920
> >
> > On 10-10-25, 12:39, Pritam Manohar Sutar wrote:
> > > Support UTMI+ combo phy for this SoC which is somewhat simmilar to
> > ^^^^^^^^ typo
> >
> > > what the existing Exynos850 support does. The difference is that some
> > > register offsets and bit fields are defferent from Exynos850.
> > ^^^^^^^^ again
>
> Thank for the review and sorry for the typo and can you please
> confirm if updated commit message is fine, mentioned as below?
>
> "
> phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920
>
> Support UTMI+ combo phy for this SoC, which is somewhat similar to
> what the existing Exynos850 supports. The difference is that some
> register offsets and bit fields are different from Exynos850.
>
> Add required change in phy driver to support combo HS phy for this SoC.
> "

better :-)
--
~Vinod