RE: [PATCH v9 0/6] initial usbdrd phy support for Exynosautov920 soc

Pritam Manohar Sutar
2025-10-24T10:39:15Z

Hi Vinod,

Gentle reminder. Can you please take this to your tree
and let me know if any comments?

> -----Original Message-----
> From: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Sent: 10 October 2025 12:39 PM
> To: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com;
> andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org;
> johan@kernel.org; ivo.ivanov.ivanov1@gmail.com;
> m.szyprowski@samsung.com; s.nawrocki@samsung.com;
> pritam.sutar@samsung.com
> Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: [PATCH v9 0/6] initial usbdrd phy support for Exynosautov920 soc
>
> This SoC has a single USB 3.1 DRD combo phy and three USB2.0 only DRD phy
> controllers as mentined below
>
> * Combo phy supports USB3.1 SSP+(10Gbps) protocol and is backwards
> compatible to the USB3.0 SS(5Gbps). 'Add-on USB2.0' phy is added
> to support USB2.0 HS(480Mbps), FS(12Mbps) and LS(1.5Mbps) data rates.
> These two phys are combined to form a combo phy as mentioned below.
>
>
> USB30DRD_0 port
>
> +------------------------------------------------------------+
> | |
> | (combo) USB phy controller |
> | +----------------------------------------------+ |
> | | USB HSPHY | |
> | | (samsung,exynosautov920-usbdrd-combo-hsphy) | |
> | +----------------------------------------------+ |
> | |
> | +--------------------------------------------------+ |
> | | USB SSPHY | |
> | | (samsung,exynosautov920-usb31drd-combo-ssphy) | |
> | +--------------------------------------------------+- |
> | |
> +------------------------------------------------------------+
> | |
> | USBDRD30 Link |
> | Controller |
> +------------------------------------------------------------+
>
> * USB2.0 phy supports only UTMI+ interface. USB2.0DRD phy
> is very similar to the existing Exynos850 support in this driver.
>
> USB20DRD_0/1/2 ports
>
> +---------------------------------------------------+
> | |
> | USB PHY controller |
> | +-----------------------------------------+ |
> | | USB HSPHY | |
> | | (samsung,exynosautov920-usbdrd-phy) | |
> | +-----------------------------------------+ |
> | |
> +---------------------------------------------------+
> | |
> | USBDRD20_* Link |
> | Controller |
> | |
> +---------------------------------------------------+
>
> The "USB20 phy output isolation" is shared across the USB20 phys.
> We have to bypass isolation when any one of the USBs is configured and enable
> it when all are turned off. The "USB31 phy isolation"
> is seperate for USB31 phy.
>
> This patchset only supports device mode and same is verified with as NCM
> device
>
> changelog
> ----------
> Changes in v9:
> - added RB tags those were given in v7 [1] and v8.
> - updated commit message in patch no.1 by adding supplies'
> names those are taken from phy User Manual [2]
> link for v8: https://lore.kernel.org/linux-phy/20250903073827.3015662-1-
> pritam.sutar@samsung.com/
> [1]: https://lore.kernel.org/linux-phy/20250824-mustang-of-glorious-
> sufficiency-b55bf4@kuoka/
> [2]: https://lore.kernel.org/linux-phy/02ef5180-ad56-45f0-a56f-
> 87f442bf6793@kernel.org/
>
> Changes in v8:
> - modified supplies' names in schema and driver.
> - Since supplies' names are changed, modified patch no 5. to
> fix warnings in dtbs_check dt_binding_check.
> - updated commit message for patch no. 1, 3 and 5 to describe
> hardware details.
> link for v7: https://lore.kernel.org/linux-phy/20250822093845.1179395-1-
> pritam.sutar@samsung.com/
>
> Changes in v7:
> - added fixes for driver build warnings
> link for v6: https://lore.kernel.org/linux-phy/20250821073703.2498302-1-
> pritam.sutar@samsung.com/
>
> Changes in v6:
> - added else part for new supplies in schemas those are only
> supported for exynosautov920.
> - addressed comments for driver given in v5.
> link for v5: https://lore.kernel.org/linux-phy/20250805115216.3798121-1-
> pritam.sutar@samsung.com/
>
> Changes in v5:
>
> - addressed comments from v4 patchset.
> - patch (1/6)
> - DTS style is corrected and added required supplies in code/schema.
> - schema block added to resolve below failure during 'dtbs_check'.
> Unevaluated properties are not allowed ('dvdd075-usb-supply', 'vdd18-
> usb20-supply', 'vdd33-usb20-supply' were unexpected.
> - patch (2/6)
> - removed usage_counter(take this later in subsequent patch-sets)
> - patch (3/6)
> - There are 3 types of the phys in this SoC.
> - one is simmilar with exynos850 as mentioned in patch no.1.
> - second supports only USB3.1 SSP+ and denoted in patch no 5
> - third supports only USB2.0 HS as in patch3.
> - hs phy in combo phy is "NOT" same as phy. (in patch no. 1)
> - These three phys(usbdrd-phy, combo-hsphy, combo-ssphy) are totally
> deferent, "NOT" same, hence added three compatible for three phys.
> - patch (5/6)
> - Since there are two phys in combo phy, explaination is given
> in each patch.
> link for v4: https://lore.kernel.org/linux-phy/20250701120706.2219355-1-
> pritam.sutar@samsung.com/
>
> Changes in v4:
> - addressed comments from v3 patchset
> - removed dts related patches, to be posted in new patchset.
> - added regulator, pmu and power sequences.
> - phy isol is shared across USBs, added usage counter to bypass or
> enable phy isolation.
> - modified schemas with hs and combo phy compatible names
> (used "combo" to denote combo phy) and regulators
> - modified code to work with binding and unbinding devices/drivers
> - added "Reviewed-by" tag.
> link for v3: https://lore.kernel.org/linux-phy/20250613055613.866909-1-
> pritam.sutar@samsung.com/
>
> Changes in v3:
> - Updated dt-bindings for USB2.0 only.
> - Added dt-bindings for combo phy.
> - Added implementation for combo phy (SS and HS phy).
> - Added added DTS nodes for all the phys
> link for v2: https://lore.kernel.org/linux-phy/20250516102650.2144487-1-
> pritam.sutar@samsung.com/
>
> Changes in v2:
> - Used standard GENMASK() and FIELD_GET() to get the major version
> from controller version register.
> link for v1: https://lore.kernel.org/linux-phy/20250514134813.380807-1-
> pritam.sutar@samsung.com/
>
> Pritam Manohar Sutar (6):
> dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy
> compatible
> phy: exynos5-usbdrd: support HS phy for ExynosAutov920
> dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo hsphy
> phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920
> dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy
> phy: exynos5-usbdrd: support SS combo phy for ExynosAutov920
>
> .../bindings/phy/samsung,usb3-drd-phy.yaml | 48 ++
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 651 ++++++++++++++++++
> include/linux/soc/samsung/exynos-regs-pmu.h | 3 +
> 3 files changed, 702 insertions(+)
>
> --
> 2.34.1

Thank you,

Regards,
Pritam