From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kernel-team@android.com,
"William Mcvicker" <willmcvicker@google.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
neil.armstrong@linaro.org
Subject: Re: [PATCH v4 1/2] phy: add new phy_notify_state() api
Date: Wed, 12 Nov 2025 16:14:06 +0000 [thread overview]
Message-ID: <aRSyTst8Vd-Qb2Ha@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251112-phy-notify-pmstate-v4-1-717d78009d15@linaro.org>
On Wed, Nov 12, 2025 at 04:05:58PM +0000, Peter Griffin wrote:
> +int phy_notify_state(struct phy *phy, union phy_notify state)
...
> @@ -255,6 +266,7 @@ int phy_reset(struct phy *phy);
> int phy_calibrate(struct phy *phy);
> int phy_notify_connect(struct phy *phy, int port);
> int phy_notify_disconnect(struct phy *phy, int port);
> +int phy_notify_state(struct phy *phy, union phy_notify state);
> static inline int phy_get_bus_width(struct phy *phy)
> {
> return phy->attrs.bus_width;
> @@ -412,6 +424,13 @@ static inline int phy_notify_disconnect(struct phy *phy, int index)
> return -ENOSYS;
> }
>
> +static inline int phy_notify_phystate(struct phy *phy, union phy_notify state)
Should this be phy_notify_state() ?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-11-12 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 16:05 [PATCH v4 0/2] Add new phy_notify_state() api Peter Griffin
2025-11-12 16:05 ` [PATCH v4 1/2] phy: add " Peter Griffin
2025-11-12 16:14 ` Russell King (Oracle) [this message]
2025-11-12 16:17 ` Peter Griffin
2025-11-12 16:05 ` [PATCH v4 2/2] phy: samsung: gs101-ufs: Add .notify_phystate() & hibern8 enter/exit values Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRSyTst8Vd-Qb2Ha@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=kernel-team@android.com \
--cc=kishon@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=vkoul@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).