Re: [PATCH v3 04/21] dt-bindings: reset: renesas,rzv2h-usb2phy: Document VBUS_SEL mux

From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
	biju.das.jz@bp.renesas.com, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Peter Rosin <peda@axentia.se>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/21] dt-bindings: reset: renesas,rzv2h-usb2phy: Document VBUS_SEL mux
Date: Mon, 17 Nov 2025 15:44:30 +0100	[thread overview]
Message-ID: <aRs0zpiOPO5nKLml@tom-desktop> (raw)
In-Reply-To: <20251117-sturdy-resourceful-crab-c14bb8@kuoka>

Hi Krzysztof,
Thanks for your review!

On Mon, Nov 17, 2025 at 08:00:27AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 10, 2025 at 01:08:04PM +0100, Tommaso Merciai wrote:
> > Document the 'mux-controller' child node in the Renesas RZ/V2H(P)
> > USB2PHY reset binding to support describing the USB VBUS_SEL
> > multiplexer as a mux-controller.
> > 
> > This is required to properly configure the USB PHY VBUS source on
> > RZ/V2H(P), RZ/G3E SoCs.
> 
> And where did you explain why this cannot be folded into parent node? If
> you do not provide context why reviewer's advice cannot be fulfilled,
> then you will get the same comment.

Ouch, thanks.

The mux-controller cannot be folded into the parent USB2PHY node because
the VBUS source selector is not part of the USB2PHY block itself.

I will add that in v4.

> 
> > 
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > ---
> > v2->v3:
> >  - Manipulate mux-controller as an internal node.
> >  - Improved commit body.
> > 
> > v1->v2:
> >  - New patch
> > 
> >  .../bindings/reset/renesas,rzv2h-usb2phy-reset.yaml   | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/reset/renesas,rzv2h-usb2phy-reset.yaml b/Documentation/devicetree/bindings/reset/renesas,rzv2h-usb2phy-reset.yaml
> > index c1b800a10b53..03da74ff2d08 100644
> > --- a/Documentation/devicetree/bindings/reset/renesas,rzv2h-usb2phy-reset.yaml
> > +++ b/Documentation/devicetree/bindings/reset/renesas,rzv2h-usb2phy-reset.yaml
> > @@ -37,6 +37,12 @@ properties:
> >    '#reset-cells':
> >      const: 0
> >  
> > +  mux-controller:
> > +    $ref: /schemas/mux/mux-controller.yaml#
> > +    description: Mux controller for USB VBUS source selection.
> > +    type: object
> > +    unevaluatedProperties: false
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -44,6 +50,7 @@ required:
> >    - resets
> >    - power-domains
> >    - '#reset-cells'
> > +  - mux-controller
> >  
> >  additionalProperties: false
> >  
> > @@ -58,4 +65,8 @@ examples:
> >          resets = <&cpg 0xaf>;
> >          power-domains = <&cpg>;
> >          #reset-cells = <0>;
> > +
> > +        mux-controller {
> > +          #mux-state-cells = <1>;
> 
> Do not mix up indentation.

Ack, thank you.

> 
> Best regards,
> Krzysztof
> 

Regards,
Tommaso

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy