From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
j.zink@pengutronix.de, linux-kernel@vger.kernel.org,
xu.yang_2@nxp.com, jun.li@nxp.com, Frank.Li@nxp.com,
haibo.chen@nxp.com, linux-phy@lists.infradead.org,
imx@lists.linux.dev, Stefano Radaelli <stefano.r@variscite.com>,
Pierluigi Passaro <pierluigi.p@variscite.com>
Subject: Re: [PATCH v1] phy: fsl-imx8mq-usb: Fix PCS_TX_SWING_FULL register configuration
Date: Thu, 18 Dec 2025 20:36:59 +0100 [thread overview]
Message-ID: <aURX2-jM0FZbLNrc@Lord-Beerus.station> (raw)
In-Reply-To: <CAOMZO5BGtgDemQeLvJ+hjY+zBtpFLp=pkpD9js0SfknE4fHd4w@mail.gmail.com>
Hi Fabio,
>
> The change looks good to me, but the Subject is a bit misleading.
>
> It gives the impression that PCS_TX_SWING_FULL is a register.
>
> What about:
>
> phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it
Thank you for the review! You're absolutely right, the subject was
misleading. I'll send a v2 with the improved subject line you suggested.
Best regards,
Stefano
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2025-12-18 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 17:49 [PATCH v1] phy: fsl-imx8mq-usb: Fix PCS_TX_SWING_FULL register configuration Stefano Radaelli
2025-12-18 18:43 ` Fabio Estevam
2025-12-18 19:36 ` Stefano Radaelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aURX2-jM0FZbLNrc@Lord-Beerus.station \
--to=stefano.radaelli21@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=j.zink@pengutronix.de \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=pierluigi.p@variscite.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefano.r@variscite.com \
--cc=vkoul@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox