* [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override
@ 2025-12-19 17:31 Krishna Kurapati
2025-12-19 17:31 ` [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update Krishna Kurapati
` (4 more replies)
0 siblings, 5 replies; 16+ messages in thread
From: Krishna Kurapati @ 2025-12-19 17:31 UTC (permalink / raw)
To: Neil Armstrong, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Pengyu Luo, Johan Hovold, Luca Weiss
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Krishna Kurapati
Add support for eusb2 repeater squelch detect parameter override via DT.
Squelch detect parameter adjusts the voltage level for the threshold used
to detect valid high-speed data.
Changes in v3:
- Moved status property to end of repeater node.
- Updated commit text as per comments received in bindings patch.
- Retained Krzysztof and Abel RB tags (since its upating commit text adding
information in bindings code and moving status property in dt code)
Link to v2:
https://lore.kernel.org/all/20251204044644.3072086-1-krishna.kurapati@oss.qualcomm.com/
Changes in v2:
- Modified logic to write to squelch related register in driver code
- Added multipleOf property in bindings to reflect values can be multiple
of 1000.
Link to v1:
https://lore.kernel.org/all/20251203083629.2395451-1-krishna.kurapati@oss.qualcomm.com/
Krishna Kurapati (3):
dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param
update
arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters
.../phy/qcom,snps-eusb2-repeater.yaml | 8 +++++++
arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 6 ++++-
.../phy/qualcomm/phy-qcom-eusb2-repeater.c | 22 +++++++++++++++++++
3 files changed, 35 insertions(+), 1 deletion(-)
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
2025-12-19 17:31 [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Krishna Kurapati
@ 2025-12-19 17:31 ` Krishna Kurapati
2025-12-23 14:11 ` Vinod Koul
2025-12-19 17:31 ` [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect " Krishna Kurapati
` (3 subsequent siblings)
4 siblings, 1 reply; 16+ messages in thread
From: Krishna Kurapati @ 2025-12-19 17:31 UTC (permalink / raw)
To: Neil Armstrong, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Pengyu Luo, Johan Hovold, Luca Weiss
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Krishna Kurapati, Krzysztof Kozlowski
Add squelch detect parameter update for synopsys eusb2 repeater. The
values (indicated in basis-points) depict a percentage change with
respect to the nominal value.
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
index 5bf0d6c9c025..f2afcf0e986a 100644
--- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
@@ -59,6 +59,14 @@ properties:
minimum: 0
maximum: 7
+ qcom,squelch-detector-bp:
+ description:
+ This adjusts the voltage level for the threshold used to detect valid
+ high-speed data.
+ minimum: -6000
+ maximum: 1000
+ multipleOf: 1000
+
required:
- compatible
- reg
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update
2025-12-19 17:31 [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Krishna Kurapati
2025-12-19 17:31 ` [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update Krishna Kurapati
@ 2025-12-19 17:31 ` Krishna Kurapati
2025-12-22 9:15 ` Abel Vesa
` (2 more replies)
2025-12-19 17:31 ` [PATCH v3 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters Krishna Kurapati
` (2 subsequent siblings)
4 siblings, 3 replies; 16+ messages in thread
From: Krishna Kurapati @ 2025-12-19 17:31 UTC (permalink / raw)
To: Neil Armstrong, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Pengyu Luo, Johan Hovold, Luca Weiss
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Krishna Kurapati
Add support for overriding Squelch Detect parameter.
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
.../phy/qualcomm/phy-qcom-eusb2-repeater.c | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
index 651a12b59bc8..a75b37d4e16d 100644
--- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
+++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
@@ -37,6 +37,17 @@
#define EUSB2_TUNE_EUSB_EQU 0x5A
#define EUSB2_TUNE_EUSB_HS_COMP_CUR 0x5B
+static const int squelch_detector[] = {
+ [0] = -6000,
+ [1] = -5000,
+ [2] = -4000,
+ [3] = -3000,
+ [4] = -2000,
+ [5] = -1000,
+ [6] = 0,
+ [7] = 1000,
+};
+
struct eusb2_repeater_init_tbl_reg {
unsigned int reg;
unsigned int value;
@@ -120,7 +131,9 @@ static int eusb2_repeater_init(struct phy *phy)
struct regmap *regmap = rptr->regmap;
u32 base = rptr->base;
u32 poll_val;
+ s32 dt_val;
int ret;
+ int i;
u8 val;
ret = regulator_bulk_enable(rptr->cfg->num_vregs, rptr->vregs);
@@ -147,6 +160,15 @@ static int eusb2_repeater_init(struct phy *phy)
if (!of_property_read_u8(np, "qcom,tune-res-fsdif", &val))
regmap_write(regmap, base + EUSB2_TUNE_RES_FSDIF, val);
+ if (!of_property_read_s32(np, "qcom,squelch-detector-bp", &dt_val)) {
+ for (i = 0; i < ARRAY_SIZE(squelch_detector); i++) {
+ if (squelch_detector[i] == dt_val) {
+ regmap_write(regmap, base + EUSB2_TUNE_SQUELCH_U, i);
+ break;
+ }
+ }
+ }
+
/* Wait for status OK */
ret = regmap_read_poll_timeout(regmap, base + EUSB2_RPTR_STATUS, poll_val,
poll_val & RPTR_OK, 10, 5);
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters
2025-12-19 17:31 [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Krishna Kurapati
2025-12-19 17:31 ` [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update Krishna Kurapati
2025-12-19 17:31 ` [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect " Krishna Kurapati
@ 2025-12-19 17:31 ` Krishna Kurapati
2025-12-22 10:14 ` Konrad Dybcio
2025-12-24 7:32 ` [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Vinod Koul
2026-01-05 19:16 ` (subset) " Bjorn Andersson
4 siblings, 1 reply; 16+ messages in thread
From: Krishna Kurapati @ 2025-12-19 17:31 UTC (permalink / raw)
To: Neil Armstrong, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Pengyu Luo, Johan Hovold, Luca Weiss
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Krishna Kurapati, Abel Vesa
Add eusb2 repeater tuning parameters for MTP platform.
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index c8cb521b4c26..e28faee466aa 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1039,10 +1039,14 @@ wifi@0 {
};
&pmih0108_eusb2_repeater {
- status = "okay";
+ qcom,tune-usb2-preem = /bits/ 8 <0x3>;
+ qcom,tune-usb2-amplitude = /bits/ 8 <0xa>;
+ qcom,squelch-detector-bp = <(-2000)>;
vdd18-supply = <&vreg_l15b_1p8>;
vdd3-supply = <&vreg_l5b_3p1>;
+
+ status = "okay";
};
&qupv3_1 {
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update
2025-12-19 17:31 ` [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect " Krishna Kurapati
@ 2025-12-22 9:15 ` Abel Vesa
2025-12-22 10:10 ` Konrad Dybcio
2026-01-01 19:01 ` Abel Vesa
2 siblings, 0 replies; 16+ messages in thread
From: Abel Vesa @ 2025-12-22 9:15 UTC (permalink / raw)
To: Krishna Kurapati
Cc: Neil Armstrong, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Pengyu Luo, Johan Hovold, Luca Weiss, linux-arm-msm, linux-phy,
devicetree, linux-kernel
On 25-12-19 23:01:07, Krishna Kurapati wrote:
> Add support for overriding Squelch Detect parameter.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update
2025-12-19 17:31 ` [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect " Krishna Kurapati
2025-12-22 9:15 ` Abel Vesa
@ 2025-12-22 10:10 ` Konrad Dybcio
2026-01-01 19:01 ` Abel Vesa
2 siblings, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2025-12-22 10:10 UTC (permalink / raw)
To: Krishna Kurapati, Neil Armstrong, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa, Pengyu Luo, Johan Hovold, Luca Weiss
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel
On 12/19/25 6:31 PM, Krishna Kurapati wrote:
> Add support for overriding Squelch Detect parameter.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters
2025-12-19 17:31 ` [PATCH v3 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters Krishna Kurapati
@ 2025-12-22 10:14 ` Konrad Dybcio
0 siblings, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2025-12-22 10:14 UTC (permalink / raw)
To: Krishna Kurapati, Neil Armstrong, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa, Pengyu Luo, Johan Hovold, Luca Weiss
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel, Abel Vesa
On 12/19/25 6:31 PM, Krishna Kurapati wrote:
> Add eusb2 repeater tuning parameters for MTP platform.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
I don't see this override in the random downstream tag I opened,
but I assume you're adding this for a reason
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
2025-12-19 17:31 ` [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update Krishna Kurapati
@ 2025-12-23 14:11 ` Vinod Koul
2025-12-23 14:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 16+ messages in thread
From: Vinod Koul @ 2025-12-23 14:11 UTC (permalink / raw)
To: Krishna Kurapati
Cc: Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Abel Vesa, Pengyu Luo,
Johan Hovold, Luca Weiss, linux-arm-msm, linux-phy, devicetree,
linux-kernel, Krzysztof Kozlowski
On 19-12-25, 23:01, Krishna Kurapati wrote:
> Add squelch detect parameter update for synopsys eusb2 repeater. The
> values (indicated in basis-points) depict a percentage change with
> respect to the nominal value.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> index 5bf0d6c9c025..f2afcf0e986a 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> @@ -59,6 +59,14 @@ properties:
> minimum: 0
> maximum: 7
>
> + qcom,squelch-detector-bp:
> + description:
> + This adjusts the voltage level for the threshold used to detect valid
> + high-speed data.
> + minimum: -6000
6000Volts, mV, can you please document the units?
> + maximum: 1000
> + multipleOf: 1000
> +
> required:
> - compatible
> - reg
> --
> 2.34.1
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
2025-12-23 14:11 ` Vinod Koul
@ 2025-12-23 14:16 ` Krzysztof Kozlowski
2025-12-23 15:48 ` Vinod Koul
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-23 14:16 UTC (permalink / raw)
To: Vinod Koul, Krishna Kurapati
Cc: Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Abel Vesa, Pengyu Luo,
Johan Hovold, Luca Weiss, linux-arm-msm, linux-phy, devicetree,
linux-kernel, Krzysztof Kozlowski
On 23/12/2025 15:11, Vinod Koul wrote:
> On 19-12-25, 23:01, Krishna Kurapati wrote:
>> Add squelch detect parameter update for synopsys eusb2 repeater. The
>> values (indicated in basis-points) depict a percentage change with
>> respect to the nominal value.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> index 5bf0d6c9c025..f2afcf0e986a 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> @@ -59,6 +59,14 @@ properties:
>> minimum: 0
>> maximum: 7
>>
>> + qcom,squelch-detector-bp:
>> + description:
>> + This adjusts the voltage level for the threshold used to detect valid
>> + high-speed data.
>> + minimum: -6000
>
> 6000Volts, mV, can you please document the units?
Code is correct, the '-bp' is the unit here. Unless the suffix was
chosen incorrectly?
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
2025-12-23 14:16 ` Krzysztof Kozlowski
@ 2025-12-23 15:48 ` Vinod Koul
2025-12-23 19:16 ` Dmitry Baryshkov
0 siblings, 1 reply; 16+ messages in thread
From: Vinod Koul @ 2025-12-23 15:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krishna Kurapati, Neil Armstrong, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Abel Vesa, Pengyu Luo, Johan Hovold, Luca Weiss, linux-arm-msm,
linux-phy, devicetree, linux-kernel, Krzysztof Kozlowski
On 23-12-25, 15:16, Krzysztof Kozlowski wrote:
> On 23/12/2025 15:11, Vinod Koul wrote:
> > On 19-12-25, 23:01, Krishna Kurapati wrote:
> >> Add squelch detect parameter update for synopsys eusb2 repeater. The
> >> values (indicated in basis-points) depict a percentage change with
> >> respect to the nominal value.
> >>
> >> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >> ---
> >> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> >> index 5bf0d6c9c025..f2afcf0e986a 100644
> >> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> >> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> >> @@ -59,6 +59,14 @@ properties:
> >> minimum: 0
> >> maximum: 7
> >>
> >> + qcom,squelch-detector-bp:
> >> + description:
> >> + This adjusts the voltage level for the threshold used to detect valid
> >> + high-speed data.
> >> + minimum: -6000
> >
> > 6000Volts, mV, can you please document the units?
>
>
> Code is correct, the '-bp' is the unit here. Unless the suffix was
> chosen incorrectly?
I was hoping it will be commented in the description here.
For my reference, what is bp and where is it documented ?
>
>
> Best regards,
> Krzysztof
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
2025-12-23 15:48 ` Vinod Koul
@ 2025-12-23 19:16 ` Dmitry Baryshkov
2025-12-24 5:28 ` Vinod Koul
0 siblings, 1 reply; 16+ messages in thread
From: Dmitry Baryshkov @ 2025-12-23 19:16 UTC (permalink / raw)
To: Vinod Koul
Cc: Krzysztof Kozlowski, Krishna Kurapati, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Abel Vesa, Pengyu Luo, Johan Hovold, Luca Weiss,
linux-arm-msm, linux-phy, devicetree, linux-kernel,
Krzysztof Kozlowski
On Tue, Dec 23, 2025 at 09:18:37PM +0530, Vinod Koul wrote:
> On 23-12-25, 15:16, Krzysztof Kozlowski wrote:
> > On 23/12/2025 15:11, Vinod Koul wrote:
> > > On 19-12-25, 23:01, Krishna Kurapati wrote:
> > >> Add squelch detect parameter update for synopsys eusb2 repeater. The
> > >> values (indicated in basis-points) depict a percentage change with
> > >> respect to the nominal value.
> > >>
> > >> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > >> ---
> > >> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
> > >> 1 file changed, 8 insertions(+)
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > >> index 5bf0d6c9c025..f2afcf0e986a 100644
> > >> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > >> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > >> @@ -59,6 +59,14 @@ properties:
> > >> minimum: 0
> > >> maximum: 7
> > >>
> > >> + qcom,squelch-detector-bp:
> > >> + description:
> > >> + This adjusts the voltage level for the threshold used to detect valid
> > >> + high-speed data.
> > >> + minimum: -6000
> > >
> > > 6000Volts, mV, can you please document the units?
> >
> >
> > Code is correct, the '-bp' is the unit here. Unless the suffix was
> > chosen incorrectly?
>
> I was hoping it will be commented in the description here.
> For my reference, what is bp and where is it documented ?
Base points, 0.01%
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
2025-12-23 19:16 ` Dmitry Baryshkov
@ 2025-12-24 5:28 ` Vinod Koul
2025-12-24 6:14 ` Dmitry Baryshkov
0 siblings, 1 reply; 16+ messages in thread
From: Vinod Koul @ 2025-12-24 5:28 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Krzysztof Kozlowski, Krishna Kurapati, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Abel Vesa, Pengyu Luo, Johan Hovold, Luca Weiss,
linux-arm-msm, linux-phy, devicetree, linux-kernel,
Krzysztof Kozlowski
On 23-12-25, 21:16, Dmitry Baryshkov wrote:
> On Tue, Dec 23, 2025 at 09:18:37PM +0530, Vinod Koul wrote:
> > On 23-12-25, 15:16, Krzysztof Kozlowski wrote:
> > > On 23/12/2025 15:11, Vinod Koul wrote:
> > > > On 19-12-25, 23:01, Krishna Kurapati wrote:
> > > >> Add squelch detect parameter update for synopsys eusb2 repeater. The
> > > >> values (indicated in basis-points) depict a percentage change with
> > > >> respect to the nominal value.
> > > >>
> > > >> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > >> ---
> > > >> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
> > > >> 1 file changed, 8 insertions(+)
> > > >>
> > > >> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > > >> index 5bf0d6c9c025..f2afcf0e986a 100644
> > > >> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > > >> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > > >> @@ -59,6 +59,14 @@ properties:
> > > >> minimum: 0
> > > >> maximum: 7
> > > >>
> > > >> + qcom,squelch-detector-bp:
> > > >> + description:
> > > >> + This adjusts the voltage level for the threshold used to detect valid
> > > >> + high-speed data.
> > > >> + minimum: -6000
> > > >
> > > > 6000Volts, mV, can you please document the units?
> > >
> > >
> > > Code is correct, the '-bp' is the unit here. Unless the suffix was
> > > chosen incorrectly?
> >
> > I was hoping it will be commented in the description here.
> > For my reference, what is bp and where is it documented ?
>
> Base points, 0.01%
Thanks Dmitry, where is this documented for people who dont know
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
2025-12-24 5:28 ` Vinod Koul
@ 2025-12-24 6:14 ` Dmitry Baryshkov
0 siblings, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2025-12-24 6:14 UTC (permalink / raw)
To: Vinod Koul
Cc: Krzysztof Kozlowski, Krishna Kurapati, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Abel Vesa, Pengyu Luo, Johan Hovold, Luca Weiss,
linux-arm-msm, linux-phy, devicetree, linux-kernel,
Krzysztof Kozlowski
On Wed, 24 Dec 2025 at 07:28, Vinod Koul <vkoul@kernel.org> wrote:
>
> On 23-12-25, 21:16, Dmitry Baryshkov wrote:
> > On Tue, Dec 23, 2025 at 09:18:37PM +0530, Vinod Koul wrote:
> > > On 23-12-25, 15:16, Krzysztof Kozlowski wrote:
> > > > On 23/12/2025 15:11, Vinod Koul wrote:
> > > > > On 19-12-25, 23:01, Krishna Kurapati wrote:
> > > > >> Add squelch detect parameter update for synopsys eusb2 repeater. The
> > > > >> values (indicated in basis-points) depict a percentage change with
> > > > >> respect to the nominal value.
> > > > >>
> > > > >> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > > > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > > >> ---
> > > > >> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
> > > > >> 1 file changed, 8 insertions(+)
> > > > >>
> > > > >> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > > > >> index 5bf0d6c9c025..f2afcf0e986a 100644
> > > > >> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > > > >> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > > > >> @@ -59,6 +59,14 @@ properties:
> > > > >> minimum: 0
> > > > >> maximum: 7
> > > > >>
> > > > >> + qcom,squelch-detector-bp:
> > > > >> + description:
> > > > >> + This adjusts the voltage level for the threshold used to detect valid
> > > > >> + high-speed data.
> > > > >> + minimum: -6000
> > > > >
> > > > > 6000Volts, mV, can you please document the units?
> > > >
> > > >
> > > > Code is correct, the '-bp' is the unit here. Unless the suffix was
> > > > chosen incorrectly?
> > >
> > > I was hoping it will be commented in the description here.
> > > For my reference, what is bp and where is it documented ?
> >
> > Base points, 0.01%
>
> Thanks Dmitry, where is this documented for people who dont know
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml#L48
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override
2025-12-19 17:31 [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Krishna Kurapati
` (2 preceding siblings ...)
2025-12-19 17:31 ` [PATCH v3 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters Krishna Kurapati
@ 2025-12-24 7:32 ` Vinod Koul
2026-01-05 19:16 ` (subset) " Bjorn Andersson
4 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2025-12-24 7:32 UTC (permalink / raw)
To: Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Abel Vesa, Pengyu Luo,
Johan Hovold, Luca Weiss, Krishna Kurapati
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel
On Fri, 19 Dec 2025 23:01:05 +0530, Krishna Kurapati wrote:
> Add support for eusb2 repeater squelch detect parameter override via DT.
>
> Squelch detect parameter adjusts the voltage level for the threshold used
> to detect valid high-speed data.
>
> Changes in v3:
> - Moved status property to end of repeater node.
> - Updated commit text as per comments received in bindings patch.
> - Retained Krzysztof and Abel RB tags (since its upating commit text adding
> information in bindings code and moving status property in dt code)
>
> [...]
Applied, thanks!
[1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update
commit: a590c0f935349b9f3ae72d9fdec002689915519d
[2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update
commit: 5c87da0308f9395700fd3072fcc45b43234366fb
[3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters
(no commit info)
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update
2025-12-19 17:31 ` [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect " Krishna Kurapati
2025-12-22 9:15 ` Abel Vesa
2025-12-22 10:10 ` Konrad Dybcio
@ 2026-01-01 19:01 ` Abel Vesa
2 siblings, 0 replies; 16+ messages in thread
From: Abel Vesa @ 2026-01-01 19:01 UTC (permalink / raw)
To: Krishna Kurapati
Cc: Neil Armstrong, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Pengyu Luo, Johan Hovold, Luca Weiss, linux-arm-msm, linux-phy,
devicetree, linux-kernel
On 25-12-19 23:01:07, Krishna Kurapati wrote:
> Add support for overriding Squelch Detect parameter.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (subset) [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override
2025-12-19 17:31 [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Krishna Kurapati
` (3 preceding siblings ...)
2025-12-24 7:32 ` [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Vinod Koul
@ 2026-01-05 19:16 ` Bjorn Andersson
4 siblings, 0 replies; 16+ messages in thread
From: Bjorn Andersson @ 2026-01-05 19:16 UTC (permalink / raw)
To: Neil Armstrong, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Konrad Dybcio, Abel Vesa, Pengyu Luo, Johan Hovold,
Luca Weiss, Krishna Kurapati
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel
On Fri, 19 Dec 2025 23:01:05 +0530, Krishna Kurapati wrote:
> Add support for eusb2 repeater squelch detect parameter override via DT.
>
> Squelch detect parameter adjusts the voltage level for the threshold used
> to detect valid high-speed data.
>
> Changes in v3:
> - Moved status property to end of repeater node.
> - Updated commit text as per comments received in bindings patch.
> - Retained Krzysztof and Abel RB tags (since its upating commit text adding
> information in bindings code and moving status property in dt code)
>
> [...]
Applied, thanks!
[3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters
commit: 09d87fdd83894bf3df4ecb79296d03c7a1ac24c3
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2026-01-05 19:16 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-19 17:31 [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Krishna Kurapati
2025-12-19 17:31 ` [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update Krishna Kurapati
2025-12-23 14:11 ` Vinod Koul
2025-12-23 14:16 ` Krzysztof Kozlowski
2025-12-23 15:48 ` Vinod Koul
2025-12-23 19:16 ` Dmitry Baryshkov
2025-12-24 5:28 ` Vinod Koul
2025-12-24 6:14 ` Dmitry Baryshkov
2025-12-19 17:31 ` [PATCH v3 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect " Krishna Kurapati
2025-12-22 9:15 ` Abel Vesa
2025-12-22 10:10 ` Konrad Dybcio
2026-01-01 19:01 ` Abel Vesa
2025-12-19 17:31 ` [PATCH v3 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters Krishna Kurapati
2025-12-22 10:14 ` Konrad Dybcio
2025-12-24 7:32 ` [PATCH v3 0/3] Add eusb2 repeater squelch detect parameter override Vinod Koul
2026-01-05 19:16 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).