Re: [PATCH] phy: Kconfig: spacemit: add COMMON_CLK dependency

From: Vinod Koul <vkoul@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: neil.armstrong@linaro.org, dlan@gentoo.org, pjw@kernel.org,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
	guodong@riscstar.com, linux-phy@lists.infradead.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] phy: Kconfig: spacemit: add COMMON_CLK dependency
Date: Mon, 29 Dec 2025 22:27:23 +0530	[thread overview]
Message-ID: <aVKy87c7afpWIx33@vaman> (raw)
In-Reply-To: <20251226173228.2020411-1-elder@riscstar.com>

On 26-12-25, 11:32, Alex Elder wrote:
> The SpacemiT PCIe PHY driver depends on the common clock framework.
> Not specifying that led to a failure when doing a COMPILE_TEST build
> for the SPARC architecture.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512251903.sTVZgg6c-lkp@intel.com/
> Signed-off-by: Alex Elder <elder@riscstar.com>
> ---
> Note:  This is based on phy/next, which I find doesn't currently build
>        cleanly using "arch/riscv/configs/defconfig".

I dont build rsicv, I should add that. What is the failure you see,
looking at changes I dont see anything that might break this

> 
>  drivers/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index aa2d30e0e3261..3bc7378ea8658 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -104,6 +104,7 @@ config PHY_NXP_PTN3222
>  config PHY_SPACEMIT_K1_PCIE
>  	tristate "PCIe and combo PHY driver for the SpacemiT K1 SoC"
>  	depends on ARCH_SPACEMIT || COMPILE_TEST
> +	depends on COMMON_CLK
>  	depends on HAS_IOMEM
>  	depends on OF
>  	select GENERIC_PHY
> 
> base-commit: 27287e3b52b5954b73203d32ee76ffd5f53f5074
> -- 
> 2.48.1

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy