From: Daniel Golle <daniel@makrotopia.org>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: yunbolyu@smu.edu.sg, kexinsun@smail.nju.edu.cn,
ratnadiraw@smu.edu.sg, xutong.ma@inria.fr,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: adjust function name reference
Date: Tue, 30 Dec 2025 16:56:11 +0000 [thread overview]
Message-ID: <aVQEKwj38I1Coj2L@makrotopia.org> (raw)
In-Reply-To: <20251230140601.93474-1-Julia.Lawall@inria.fr>
On Tue, Dec 30, 2025 at 03:06:01PM +0100, Julia Lawall wrote:
> There is no function clk_bulk_prepare_disable. Refer instead to
> clk_bulk_disable_unprepare, which is called in the function
> defined just below.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Thanks for spotting this obviously wrong comment!
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
>
> ---
> drivers/phy/mediatek/phy-mtk-xfi-tphy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-xfi-tphy.c b/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
> index 1a0b7484f525..100a50d0e861 100644
> --- a/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
> +++ b/drivers/phy/mediatek/phy-mtk-xfi-tphy.c
> @@ -353,7 +353,7 @@ static int mtk_xfi_tphy_power_on(struct phy *phy)
> * Disable and unprepare all clocks previously enabled.
> *
> * Return:
> - * See clk_bulk_prepare_disable().
> + * See clk_bulk_disable_unprepare().
> */
> static int mtk_xfi_tphy_power_off(struct phy *phy)
> {
>
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-12-30 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 14:06 [PATCH] phy: adjust function name reference Julia Lawall
2025-12-30 16:56 ` Daniel Golle [this message]
2026-01-01 11:08 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVQEKwj38I1Coj2L@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=Julia.Lawall@inria.fr \
--cc=SkyLake.Huang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=dqfext@gmail.com \
--cc=kexinsun@smail.nju.edu.cn \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ratnadiraw@smu.edu.sg \
--cc=vkoul@kernel.org \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox