* [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
@ 2026-01-08 21:16 ` Brian Masney
2026-01-14 14:17 ` Vinod Koul
2026-01-10 19:11 ` (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Bjorn Andersson
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Brian Masney @ 2026-01-08 21:16 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, Brian Masney, Vinod Koul, Neil Armstrong,
linux-phy
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.
Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:
req->rate = divider_round_rate(...)
This is invalid in the case when an error occurs since it can set the
rate to a negative value.
Fixes: 27287e3b52b5 ("phy: ti: phy-j721e-wiz: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Vinod Koul <vkoul@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-phy@lists.infradead.org
---
drivers/phy/ti/phy-j721e-wiz.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 12a19bf2875c601c60ff5559e1554274ee215918..6e9ecb88dc8b7842745486ae8ad57f82563d6711 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -940,10 +940,7 @@ static int wiz_clk_div_determine_rate(struct clk_hw *hw,
{
struct wiz_clk_divider *div = to_wiz_clk_div(hw);
- req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
- div->table, 2, 0x0);
-
- return 0;
+ return divider_determine_rate(hw, req, div->table, 2, 0x0);
}
static int wiz_clk_div_set_rate(struct clk_hw *hw, unsigned long rate,
--
2.52.0
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()
2026-01-08 21:16 ` [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate() Brian Masney
@ 2026-01-14 14:17 ` Vinod Koul
2026-01-15 14:18 ` Brian Masney
0 siblings, 1 reply; 10+ messages in thread
From: Vinod Koul @ 2026-01-14 14:17 UTC (permalink / raw)
To: Brian Masney
Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel,
Neil Armstrong, linux-phy
On 08-01-26, 16:16, Brian Masney wrote:
> The divider_round_rate() function is now deprecated, so let's migrate
> to divider_determine_rate() instead so that this deprecated API can be
> removed.
>
> Note that when the main function itself was migrated to use
> determine_rate, this was mistakenly converted to:
>
> req->rate = divider_round_rate(...)
>
> This is invalid in the case when an error occurs since it can set the
> rate to a negative value.
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()
2026-01-14 14:17 ` Vinod Koul
@ 2026-01-15 14:18 ` Brian Masney
2026-01-21 7:56 ` Vinod Koul
0 siblings, 1 reply; 10+ messages in thread
From: Brian Masney @ 2026-01-15 14:18 UTC (permalink / raw)
To: Vinod Koul
Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel,
Neil Armstrong, linux-phy
Hi Vinod,
On Wed, Jan 14, 2026 at 07:47:18PM +0530, Vinod Koul wrote:
> On 08-01-26, 16:16, Brian Masney wrote:
> > The divider_round_rate() function is now deprecated, so let's migrate
> > to divider_determine_rate() instead so that this deprecated API can be
> > removed.
> >
> > Note that when the main function itself was migrated to use
> > determine_rate, this was mistakenly converted to:
> >
> > req->rate = divider_round_rate(...)
> >
> > This is invalid in the case when an error occurs since it can set the
> > rate to a negative value.
>
> Acked-by: Vinod Koul <vkoul@kernel.org>
Thanks for the Acked-by.
However, this patch depends on this other series of mine that's merged
into your phy tree:
https://lore.kernel.org/linux-clk/176661322399.4169.14248756511703978007@lazor/
Stephen asked for an Acked-by for that series or an immutable branch.
This will allow us to remove round_rate from the clk core.
I also have a small series to post that's dependent on all of this that
lets us get rid of the noop determine_rate implementations that only
'return 0'. I haven't posted that because of the dependencies.
Brian
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()
2026-01-15 14:18 ` Brian Masney
@ 2026-01-21 7:56 ` Vinod Koul
2026-01-21 12:13 ` Brian Masney
0 siblings, 1 reply; 10+ messages in thread
From: Vinod Koul @ 2026-01-21 7:56 UTC (permalink / raw)
To: Brian Masney
Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel,
Neil Armstrong, linux-phy
On 15-01-26, 09:18, Brian Masney wrote:
> Hi Vinod,
>
> On Wed, Jan 14, 2026 at 07:47:18PM +0530, Vinod Koul wrote:
> > On 08-01-26, 16:16, Brian Masney wrote:
> > > The divider_round_rate() function is now deprecated, so let's migrate
> > > to divider_determine_rate() instead so that this deprecated API can be
> > > removed.
> > >
> > > Note that when the main function itself was migrated to use
> > > determine_rate, this was mistakenly converted to:
> > >
> > > req->rate = divider_round_rate(...)
> > >
> > > This is invalid in the case when an error occurs since it can set the
> > > rate to a negative value.
> >
> > Acked-by: Vinod Koul <vkoul@kernel.org>
>
> Thanks for the Acked-by.
>
> However, this patch depends on this other series of mine that's merged
> into your phy tree:
Should I pick this one then..? If there are no other dependencies...
>
> https://lore.kernel.org/linux-clk/176661322399.4169.14248756511703978007@lazor/
>
> Stephen asked for an Acked-by for that series or an immutable branch.
>
> This will allow us to remove round_rate from the clk core.
>
> I also have a small series to post that's dependent on all of this that
> lets us get rid of the noop determine_rate implementations that only
> 'return 0'. I haven't posted that because of the dependencies.
>
> Brian
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()
2026-01-21 7:56 ` Vinod Koul
@ 2026-01-21 12:13 ` Brian Masney
0 siblings, 0 replies; 10+ messages in thread
From: Brian Masney @ 2026-01-21 12:13 UTC (permalink / raw)
To: Vinod Koul
Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel,
Neil Armstrong, linux-phy
On Wed, Jan 21, 2026 at 01:26:05PM +0530, Vinod Koul wrote:
> On 15-01-26, 09:18, Brian Masney wrote:
> > Hi Vinod,
> >
> > On Wed, Jan 14, 2026 at 07:47:18PM +0530, Vinod Koul wrote:
> > > On 08-01-26, 16:16, Brian Masney wrote:
> > > > The divider_round_rate() function is now deprecated, so let's migrate
> > > > to divider_determine_rate() instead so that this deprecated API can be
> > > > removed.
> > > >
> > > > Note that when the main function itself was migrated to use
> > > > determine_rate, this was mistakenly converted to:
> > > >
> > > > req->rate = divider_round_rate(...)
> > > >
> > > > This is invalid in the case when an error occurs since it can set the
> > > > rate to a negative value.
> > >
> > > Acked-by: Vinod Koul <vkoul@kernel.org>
> >
> > Thanks for the Acked-by.
> >
> > However, this patch depends on this other series of mine that's merged
> > into your phy tree:
>
> Should I pick this one then..? If there are no other dependencies...
Yes, this patch stands on it's own, and it would be great if you could
pick up this patch in your tree this dev cycle.
Thanks,
Brian
> > https://lore.kernel.org/linux-clk/176661322399.4169.14248756511703978007@lazor/
> >
> > Stephen asked for an Acked-by for that series or an immutable branch.
> >
> > This will allow us to remove round_rate from the clk core.
> >
> > I also have a small series to post that's dependent on all of this that
> > lets us get rid of the noop determine_rate implementations that only
> > 'return 0'. I haven't posted that because of the dependencies.
> >
> > Brian
>
> --
> ~Vinod
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
2026-01-08 21:16 ` [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate() Brian Masney
@ 2026-01-10 19:11 ` Bjorn Andersson
2026-01-15 21:05 ` Dmitry Baryshkov
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2026-01-10 19:11 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, linux-arm-msm, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue, linux-stm32,
Michal Simek, Rob Clark, Dmitry Baryshkov, David Airlie,
Simona Vetter, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, dri-devel, freedreno, Vinod Koul, Neil Armstrong,
linux-phy
On Thu, 08 Jan 2026 16:16:18 -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
>
> Note that when I converted some of these drivers from round_rate to
> determine_rate, this was mistakenly converted to the following in some
> cases:
>
> [...]
Applied, thanks!
[14/27] clk: qcom: alpha-pll: convert from divider_round_rate() to divider_determine_rate()
commit: e1f08613e113f02a3ec18c9a7964de97f940acbf
[15/27] clk: qcom: regmap-divider: convert from divider_ro_round_rate() to divider_ro_determine_rate()
commit: 35a48f41b63f67c490f3a2a89b042536be67cf0f
[16/27] clk: qcom: regmap-divider: convert from divider_round_rate() to divider_determine_rate()
commit: b2f36d675e09299d9aee395c6f83d8a95d4c9441
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
2026-01-08 21:16 ` [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate() Brian Masney
2026-01-10 19:11 ` (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Bjorn Andersson
@ 2026-01-15 21:05 ` Dmitry Baryshkov
2026-01-21 22:53 ` Brian Masney
2026-02-04 15:44 ` (subset) " Vinod Koul
4 siblings, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2026-01-15 21:05 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Bjorn Andersson, linux-arm-msm, Orson Zhai,
Baolin Wang, Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
linux-stm32, Michal Simek, Rob Clark, Dmitry Baryshkov,
David Airlie, Simona Vetter, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, dri-devel, freedreno, Vinod Koul,
Neil Armstrong, linux-phy
On Thu, 08 Jan 2026 16:16:18 -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
>
> Note that when I converted some of these drivers from round_rate to
> determine_rate, this was mistakenly converted to the following in some
> cases:
>
> [...]
Applied to msm-next, thanks!
[24/27] drm/msm/dsi_phy_14nm: convert from divider_round_rate() to divider_determine_rate()
https://gitlab.freedesktop.org/lumag/msm/-/commit/1d232f793d4d
Best regards,
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
` (2 preceding siblings ...)
2026-01-15 21:05 ` Dmitry Baryshkov
@ 2026-01-21 22:53 ` Brian Masney
2026-02-04 15:44 ` (subset) " Vinod Koul
4 siblings, 0 replies; 10+ messages in thread
From: Brian Masney @ 2026-01-21 22:53 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Bjorn Andersson, linux-arm-msm, Orson Zhai,
Baolin Wang, Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
linux-stm32, Michal Simek, Rob Clark, Dmitry Baryshkov,
David Airlie, Simona Vetter, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, dri-devel, freedreno, Vinod Koul,
Neil Armstrong, linux-phy
Hi Stephen,
On Thu, Jan 08, 2026 at 04:16:18PM -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
I sent you a GIT PULL for what can go to Linus for the upcoming merge
window from this series:
https://lore.kernel.org/linux-clk/aXFYU324yQ6uBmk0@redhat.com/T/#u
Thanks,
Brian
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
` (3 preceding siblings ...)
2026-01-21 22:53 ` Brian Masney
@ 2026-02-04 15:44 ` Vinod Koul
4 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2026-02-04 15:44 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Bjorn Andersson, linux-arm-msm, Orson Zhai,
Baolin Wang, Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
linux-stm32, Michal Simek, Rob Clark, Dmitry Baryshkov,
David Airlie, Simona Vetter, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, dri-devel, freedreno, Neil Armstrong,
linux-phy
On Thu, 08 Jan 2026 16:16:18 -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
>
> Note that when I converted some of these drivers from round_rate to
> determine_rate, this was mistakenly converted to the following in some
> cases:
>
> [...]
Applied, thanks!
[25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()
commit: dbeea86fecef7cf2b93aded4525d74f6277376ef
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 10+ messages in thread