From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21324D358CC for ; Thu, 29 Jan 2026 07:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zj+oURWvdcPWWZlp1BRN1p8QYa5/6edr1MJhcvdFkho=; b=vKy5P0J2VaYvhh UPL6N/b5j7tBL4QbWmpizHfJ8FOFWmDXodcPUboGOu+yeasybLKKH/2lxEqCjXsBakRoSsCIJboTj jTV/QHiLfMiSm+RugBIAYvdHD2o9p68R7+l1ugqdQIocjssQenOb8HLPkjFyymAizDZlN5xpWgIES 1WbHHbFcnmOpManKla6UZ0XYtKUROMgelhLuZ9/JretSSig+xZF65c1yH5g1X1CcVgH77kPTMIe6G eQrj/toubypHoC3SRrfEt2+0/AKeAZLJl6q31xnE/cZpCfkZuGvBJrFhoeHAoALpWETVScDDHngWL zEqFXyx6eV3IG8k9ywLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vlMQy-0000000HOFZ-3DlM; Thu, 29 Jan 2026 07:27:20 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vlMQv-0000000HOEd-1AbJ for linux-phy@lists.infradead.org; Thu, 29 Jan 2026 07:27:18 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60T2okEL3143767 for ; Thu, 29 Jan 2026 07:27:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=ySOUOkIINh0fLQ8YNyshi4af ZbpfENdrNzzg6IBH0jw=; b=XQZpLCMlWMKYiSGGuigMRDbLlRF0eNdStZr7ltiv gFqnqnzIVXMcJpfmQXcT9igO9cgoFpKrpW1Ciy6YYpHIiInuZPpxK2hO1FAwo14n shAFYbqkzCoanUMiAwMDcChR6p0K300HUyOPjmLEAqLTUhUNQugKAVdruml6UeTS yxErv16vuxLJy9cQ8m2lkHZxIbkvD5TTpPi1ypj7IVaS/y3xcUzFNZ8hpFoFSEUf URLd7hVa2JUkOxIT7w9KzfWerTbTpDMCe7pFzbvUFY2vRdUYvu3PRS9YNHL9lgVf w+JcU/9v7mIOaO6sg1NFh8Zmxv+rX7KauhHIOQq/00UGZg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byqpxj05d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 07:27:15 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c65d08b623aso179414a12.0 for ; Wed, 28 Jan 2026 23:27:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769671635; x=1770276435; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ySOUOkIINh0fLQ8YNyshi4afZbpfENdrNzzg6IBH0jw=; b=kcrG5LK+mS8tNzTtVXnUPnGJVy7e69yWM/hLM8qF4WFJi+n6b8/wbN4w8j04TRdENI WwRCRDlcQKE5JPpJapsiIOuTlgW7IrUocZzc48oA/gF28NIkgepALybOOplSld/JPEV/ EKJe9erNTW4l2G9nlb0Sdm9S2WK8cZwD3UnKzxwr23gxNaR4BsXqzEkWguRi1/iOkh4s maa2LOpf0as7OkRlaMIKT6Lm7xfKvbjhskJSGwJlG0/RiqnqAXwIGZPYd+/NfitK69QF 2STYBpw/BbVNS+Ciyey3IVE7VwrMJ2TVeTH4w2At+XCENsC/4thMZxqHqioptoDMOtGy rOOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769671635; x=1770276435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ySOUOkIINh0fLQ8YNyshi4afZbpfENdrNzzg6IBH0jw=; b=nikkuJmGcn0ba1qJ4jUOC0b02zl4F7DAYu6/XM9BXkW+xJj6HxhVwyuiT2kfGKFycS snZJJn0Kz9+gkEGLoaKGDvwJUNk+kJg+8CentHXCDiPcqIFFbGOKD190yhOjPx5mHPgY HQhH18ESskv7gjRgWz78u1J++5TTSNGtDxyDBQeRDeC+jQNZEX/FbLPjKbx6NiDta87T yl0smm2Gj2da+ZaPGYuImmTX8Z9joISENaF9bSWmvDhURogkdQhWdZnmZUVfwqjh4G1n RfSe56ovEDh8uVw6Qzex09MjZgNtvl3Qn5exYC4oy9jML0OBNPKN0X76dwVe9ZYHWisj UOcw== X-Forwarded-Encrypted: i=1; AJvYcCXMNBlqN4UewtDOE1mCgLsUv6uCegwlF/UklYZIekT4KOo4q6FOBZ/Ne0ZTIzhad5ND1So8WlkMvSw=@lists.infradead.org X-Gm-Message-State: AOJu0YxXWTii6iop+cnjwQOnrfa5FRqcM4F9W0sxGwTqwWUEkdXvIe+T 11iTdedvS4Z4xVy/5Kvb7x8X2uozpkz1Ut0wQQMi8qPyz+irI0M9pzC/f0rroOkLqJ8gDhghy2R aYsTIaJgUg/Jx+SwRpuJULztjN3LtexwBa252unV+b+KtuJY5p0hMslOjcJaRgEe7InZX X-Gm-Gg: AZuq6aJr9S24QYkb3FvEMH4ztyiLeOFtn//T/1dtnxPtlOdRhOGmczXdzXcsJ4NH/j6 ufdgefNKzMgQ7SzbDv7FJX8IKKjttIEDNskWX7lUs7ZfBxGMKPy3iCYfjUQRBgjXkbhHmbR5Wzm Jy4DxGWS9YPujKA4mlj4pubY27CcgToY2o34oD6glRTbT9vpU1OG81GbWiG31U2WwmYAMiZyRzB uOseGPjcU+BhGoccNTVePduEeY5vuNA64DFDcXpJf26NqxXLdn73MnPj5VbzpvwH47GXatjItbl wh3vBCBzO7sy4cYA++c5JuDmUPcibkShx+QNXWuFf4fZ5jkvr9SqouZcOdZYO0FkXD8pQQOQy+T 73w1BXF30SMePPKDdQPxpoy0= X-Received: by 2002:a05:6a00:94ee:b0:823:5745:cfd8 with SMTP id d2e1a72fcca58-823920ddbd2mr2231132b3a.32.1769671634922; Wed, 28 Jan 2026 23:27:14 -0800 (PST) X-Received: by 2002:a05:6a00:94ee:b0:823:5745:cfd8 with SMTP id d2e1a72fcca58-823920ddbd2mr2231101b3a.32.1769671634411; Wed, 28 Jan 2026 23:27:14 -0800 (PST) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379b2305fsm5035336b3a.10.2026.01.28.23.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 23:27:13 -0800 (PST) Date: Thu, 29 Jan 2026 12:57:05 +0530 From: Mohd Ayaan Anwar To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH net-next v2 00/14] net: stmmac: SerDes, PCS, BASE-X, and inband goodies Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: yaOuC0udyaZ1I78WMohY1PtvXldvMH8i X-Proofpoint-ORIG-GUID: yaOuC0udyaZ1I78WMohY1PtvXldvMH8i X-Authority-Analysis: v=2.4 cv=dfSNHHXe c=1 sm=1 tr=0 ts=697b0bd4 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u3xWUgpTUxrHMWPZussA:9 a=CjuIK1q_8ugA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA0MiBTYWx0ZWRfX6KCLAUmKmFS6 L7oZkgjnY9XObO6/hJ5qEUkyyKIDPYay5EoJYUiONBhxidQJuZPjq6EytP3JyQlmK70Lb6hJFIE LWjozK79OOvJdvBfVMwKF8ESXsHeFrUcBk/J9UKVf0peVX/XNEayUM+q2MKiKZaJBeosRQbmx3x Z1YaxEOKsTezoPTnaV0TVV92oH3KO9SvVFu4BslNHltCPDREfOESNziDynS3wbleADJxo5kSCYG Iqk7p3jrIy7ZnGvWJpwvQOOfk8B8aLAqUUgFuIrGpKEH1TInGkJ/J0LsSAJvp0BcLKwjCWMuojx nOHy7e/KiU3gXcdi0OfHSFFFgx7LB16/bY4+T6qxwZ+w63xQ/raZ0FhT9YkoOa6GVEst78squE6 3EyzIoMiTDdmrDoUv+hd67X/RGDDtb0KwRSsVifoVjwCYFN5hZgp1no1sEU11lm2KjEH4DSsZXP 1mzB03UEULbocSCqETQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_01,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290042 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260128_232717_454077_166D493A X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, Jan 27, 2026 at 03:42:57PM +0000, Russell King (Oracle) wrote: > On Tue, Jan 27, 2026 at 08:27:50PM +0530, Mohd Ayaan Anwar wrote: > > During pcs_init, BIT(8) of GMAC_AN_STATUS is 0: > > [ 7.985913] [DBG] GMAC_AN_STATUS = 8 > > Hmm. This means that your hardware doesn't support TBI or RTBI modes > (which is what the dwmac core uses for BASE-X) and what it's actually > offering is an up-clocked Cisco SGMII implementation. > > With AN disabled, this is compatible with 2500BASE-X implementations > that do not require AN. Yes, this hardware implements what some vendors call OCSGMII (i.e. 2500BASE-X without in-band signalling). > > I also tried enabling comma detect during dwmac_integrated_pcs_config, > > but I am still seeing the Tx timeouts. I remember that when I had > > tested the patches in October (without the SerDes driver changes), > > the link state used to flap, but the data path became functional > > after the link stabilized. > > I wonder whether the SerDes needs to be calibrated after the link has > come up and the clocks configured. phy_calibdate() will re-invoke the > programming of the SerDes, so you could try adding that at the bottom > of ethqos_configure_sgmii(): > > return phy_calibrate(priv->plat->serdes); > > which will do the calibration after the clocks have been set, and see > whether that stabilises the link. Somehow booting up with a 2.5G link is more unstable after adding this. Behaviour at 1G is pretty similar. I kept comma detection disabled during these tests. I was thinking about the "good" sequence (i.e., the current net-next tree): -> phylink_up -> mac_link_up -> fix_mac_speed -> SerDes configured via phy_set_speed -> stmmac_pcs_ctrl_ane(priv, enable/disable, 0) Please let me know if you want me to try any other experiments. Maybe I need to do some more testing after playing around with the sequence followed by this series? Ayaan -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy