From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Abel Vesa <abelvesa@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 4/6] phy: qcom-qmp-usbc: Rename QCS615 DP PHY variables and functions
Date: Sat, 14 Mar 2026 20:18:47 +0800 [thread overview]
Message-ID: <abVSJ2-mMFf-rsw1@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <ckj6c2rute5bzachye3tl6hs3fgw7wtafoldsdutkszxjc2vsp@nplvcpzqzwfn>
On Sat, Mar 14, 2026 at 11:14:56AM +0200, Dmitry Baryshkov wrote:
> On Sat, Mar 14, 2026 at 01:13:23PM +0800, Shawn Guo wrote:
> > Commit 81791c45c8e0 ("phy: qcom: qmp-usbc: Add QCS615 USB/DP PHY config
> > and DP mode support") chose to name QCS615 DP PHY variables/functions
> > with qmp_v2 prefix, by assuming that QMP PHY registers are versioned
> > as a whole. However, the reality is that the registers are versioned
> > in sub-modules like QSERDES COM and QSERDES TXRX respectively, e.g.
> > QCS615 DP PHY has registers of QSERDES COM v2 and QSERDES TXRX v3.
> > Thus it may cause confusion that qmp_v2_xxx table and functions access
> > QSERDES TXRX v3 registers.
> >
> > Rename QCS615 DP PHY variables and functions to be prefixed by qcs615
> > instead of qmp_v2. This better aligns with how the driver names USB3 PHY
> > variables for QCM2290 etc.
>
> Well... I'm a bit reluctant with this one. The driver needs to support
> DP programming on three platforms: qcs615/sm6150, sdm660 and msm8998. As
> far as I can see, most of the DP setup between SDM660 and QCS615 is
> common.
In that case, could we just reuse QCS615 DP tables/functions for SDM660,
just like QCM2290 USB3 tables being reused for QCS615 and SDM660?
Shawn
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-03-14 12:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 5:13 [PATCH 0/6] phy: qcom-qmp: Clean up QSERDES COM and TXRX register headers Shawn Guo
2026-03-14 5:13 ` [PATCH 1/6] phy: qcom-qmp: Add missing QSERDES COM v2 registers Shawn Guo
2026-03-14 8:15 ` Dmitry Baryshkov
2026-03-14 5:13 ` [PATCH 2/6] phy: qcom-qmp: Use explicit QSERDES COM v2 register definitions Shawn Guo
2026-03-14 8:19 ` Dmitry Baryshkov
2026-03-14 5:13 ` [PATCH 3/6] phy: qcom-qmp-usbc: Use register definitions in qserdes-txrx-v3 Shawn Guo
2026-03-14 9:16 ` Dmitry Baryshkov
2026-03-14 5:13 ` [PATCH 4/6] phy: qcom-qmp-usbc: Rename QCS615 DP PHY variables and functions Shawn Guo
2026-03-14 9:14 ` Dmitry Baryshkov
2026-03-14 12:18 ` Shawn Guo [this message]
2026-03-31 18:52 ` Dmitry Baryshkov
2026-03-14 5:13 ` [PATCH 5/6] phy: qcom-qmp: Drop unused register headers Shawn Guo
2026-03-14 9:15 ` Dmitry Baryshkov
2026-03-14 5:13 ` [PATCH 6/6] phy: qcom-qmp: Make QSERDES TXRX v2 registers explicit Shawn Guo
2026-03-14 9:15 ` Dmitry Baryshkov
2026-03-31 11:24 ` [PATCH 0/6] phy: qcom-qmp: Clean up QSERDES COM and TXRX register headers Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abVSJ2-mMFf-rsw1@QCOM-aGQu4IUr3Y \
--to=shengchao.guo@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=luca.weiss@fairphone.com \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
--cc=xiangxu.yin@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox