From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C19ABCA5FED for ; Wed, 7 Oct 2026 00:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bBSVSQJxdFyoAOFgZoXAoRix+BOkz6N7It4miXQbzx8=; b=Enry6ygFnZ4it2 Ta2V0xkx6QR0Izu7LaQ3eZIb0dYXtF2sIFgz1MtcPPqBYvZVoUrTc5EZa9MoQ980kvOBw6CBr4CD9 w7ZEB0tD70hNWbAfWcTrz9u5kVJYaOBUtYWZj3v57OjK9SpggG9lvmwmYydjrtI7gg2uIa2zr438Q 0Zjq1Ki8Hkl6beS0Q6zSg0W35jrh38qO7tCQ3Lp8LWaGuVtNC+f0FZvf+w0YlvdxaOVAV6lzd+P7U ANK/K386GuxTPOkJeT60fmU8J7vXaHUrqY1UoXXZ03twFd1F3Hj76y/MEBtwkPkHmhH5vCvv80vEU 7u7w98IBCS8vGa1TmjzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEFuV-00000001YLE-0kBa; Wed, 07 Oct 2026 00:53:31 +0000 Received: from mail-m8314.xmail.ntesmail.com ([156.224.83.14]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEFuS-00000001YJr-0k0Z; Wed, 07 Oct 2026 00:53:30 +0000 Received: from [172.16.12.48] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 501f3a86f; Wed, 7 Oct 2026 08:53:17 +0800 (GMT+08:00) Message-ID: Date: Wed, 7 Oct 2026 08:53:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: shawn.lin@rock-chips.com, Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Vinod Koul Subject: Re: [PATCH v13 2/2] phy: rockchip: naneng-combphy: add SGMII MAC selection for RK3568 To: Coia Prant References: <20261006162807.2843858-1-coiaprant@gmail.com> <20261006162807.2843858-3-coiaprant@gmail.com> From: Shawn Lin In-Reply-To: <20261006162807.2843858-3-coiaprant@gmail.com> X-HM-Tid: 0aa113d9b55103a4kunm37190398c7e909 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZTEIaVh8aGEtLSEkYGR9NSFYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQkxVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=LVXOYYrg7BT+nd5C/HPHiD661/6mZnPBVItwHAXs7TdiTEyAuM3iLBra6IVsJdrjJ82lOVy7sh81k/sLLbiXE7mKJnpYVoMe7Klk0SO+0VL/aPI8EkBunY4XUJKgouHCq8i+TfqLFVpPZnGA1OXmhuEjQEwYQq5jPrStu/tXl+4=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=uv0E972XvkHZpc86P2YGE1FsEYyLKJDTtXbuIBu+qC0=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261006_175329_008646_A494E5C1 X-CRM114-Status: GOOD ( 27.77 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org 5ZyoIDIwMjYvMTAvMDcg5pif5pyf5LiJIDA6MjgsIENvaWEgUHJhbnQg5YaZ6YGTOgo+IE9uIFJL MzU2OCwgdGhlIFNHTUlJIGludGVyZmFjZSBjYW4gYmUgcm91dGVkIHRvIGVpdGhlciBHTUFDMCBv cgo+IEdNQUMxIHZpYSB0aGUgR1JGIHJlZ2lzdGVyIHBpcGVfc2dtaWlfbWFjX3NlbC4KPiAKPiBB ZGQgc3VwcG9ydCBmb3IgdGhpcyBzZWxlY3Rpb24gYnkgaW50cm9kdWNpbmcgdGhlCj4gInJvY2tj aGlwLHNnbWlpLW1hYy1zZWwiIERUIHByb3BlcnR5Lgo+IAo+ICBGcm9tIHRoZSBSSzM1NjggVFJN IChQYXJ0MSwgUGFnZSAyMjkpLCB0aGUgUElQRV9HUkZfWFBDU19DT04wCj4gYml0IDEgKHBpcGVf c2dtaWlfbWFjX3NlbCkgaXMgZGVmaW5lZCBhczoKPiAKPiAgICAgIDA6IFNHTUlJIHJvdXRlZCB0 byBHTUFDMAo+ICAgICAgMTogU0dNSUkgcm91dGVkIHRvIEdNQUMxCj4gCj4gVGhlIGhhcmR3YXJl IHJlc2V0IHZhbHVlIGlzIDEgKEdNQUMxKS4gSWYgdGhlIHByb3BlcnR5IGlzIHNldCB0byAwLAo+ IHRoZSBkcml2ZXIgcm91dGVzIFNHTUlJIHRvIEdNQUMwOyBpZiBzZXQgdG8gMSwgaXQgcm91dGVz IHRvIEdNQUMxLgo+IElmIHRoZSBwcm9wZXJ0eSBpcyBhYnNlbnQsIHRoZSBkcml2ZXIgbGVhdmVz IHRoZSByb3V0aW5nIHVuY2hhbmdlZCwKPiBzbyB0aGUgZWZmZWN0aXZlIHZhbHVlIGlzIHdoYXRl dmVyIHRoZSBib290bG9hZGVyIG9yIGhhcmR3YXJlIHJlc2V0Cj4gbGVmdC4KPiAKPiBUaGUgZHJp dmVyIHZhbGlkYXRlcyB0aGUgdmFsdWUgYW5kIHJlamVjdHMgYW55dGhpbmcgb3RoZXIgdGhhbiAw IG9yIDEuCj4gCj4gVGhpcyBpcyBuZWNlc3NhcnkgZm9yIGJvYXJkcyBzdWNoIGFzIHRoZSBBcmlh Ym9hcmQgUGhvdG9uaWNhdCwgd2hpY2gKPiB1c2VzIHRoZSBTR01JSSBpbnRlcmZhY2UgY29ubmVj dGVkIHRvIEdNQUMwLgo+IAo+IExpbms6IGh0dHBzOi8vZGwucmFkeGEuY29tL3JvY2szL2RvY3Mv aHcvZGF0YXNoZWV0L1JvY2tjaGlwJTIwUkszNTY4JTIwVFJNJTIwUGFydDElMjBWMS4xLTIwMjEw MzAxLnBkZiAoUGFnZSAyMjkpCj4gU2lnbmVkLW9mZi1ieTogQ29pYSBQcmFudCA8Y29pYXByYW50 QGdtYWlsLmNvbT4KPiAtLS0KPiAgIC4uLi9yb2NrY2hpcC9waHktcm9ja2NoaXAtbmFuZW5nLWNv bWJwaHkuYyAgICB8IDQyICsrKysrKysrKysrKysrKysrKysKPiAgIDEgZmlsZSBjaGFuZ2VkLCA0 MiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3Bo eS1yb2NrY2hpcC1uYW5lbmctY29tYnBoeS5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJv Y2tjaGlwLW5hbmVuZy1jb21icGh5LmMKPiBpbmRleCA3ODQzMzU2YTRkZDQ3Li5mNzZiNDgwMDk2 NzNkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1uYW5l bmctY29tYnBoeS5jCj4gKysrIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLW5h bmVuZy1jb21icGh5LmMKPiBAQCAtMTg2LDYgKzE4Niw3IEBAIHN0cnVjdCByb2NrY2hpcF9jb21i cGh5X2dyZmNmZyB7Cj4gICAJc3RydWN0IGNvbWJwaHlfcmVnIHBpcGVfeHBjc19waHlfcmVhZHk7 Cj4gICAJc3RydWN0IGNvbWJwaHlfcmVnIHBpcGVfcGNpZTFsMF9zZWw7Cj4gICAJc3RydWN0IGNv bWJwaHlfcmVnIHBpcGVfcGNpZTFsMV9zZWw7Cj4gKwlzdHJ1Y3QgY29tYnBoeV9yZWcgcGlwZV9z Z21paV9tYWNfc2VsOwo+ICAgCXN0cnVjdCBjb21icGh5X3JlZyB1M290ZzBfcG9ydF9lbjsKPiAg IAlzdHJ1Y3QgY29tYnBoeV9yZWcgdTNvdGcxX3BvcnRfZW47Cj4gICB9Owo+IEBAIC0yMTIsNiAr MjEzLDggQEAgc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfcHJpdiB7Cj4gICAJYm9vbCBlbmFibGVf c3NjOwo+ICAgCWJvb2wgZXh0X3JlZmNsazsKPiAgIAlzdHJ1Y3QgY2xrICpyZWZjbGs7Cj4gKwli b29sIHNnbWlpX21hY19zZWxfcHJlc2VudDsKPiArCXUzMiBzZ21paV9tYWNfc2VsOwo+ICAgfTsK PiAgIAo+ICAgc3RhdGljIHZvaWQgcm9ja2NoaXBfY29tYnBoeV91cGRhdGVsKHN0cnVjdCByb2Nr Y2hpcF9jb21icGh5X3ByaXYgKnByaXYsCj4gQEAgLTM0MSw2ICszNDQsNyBAQCBzdGF0aWMgc3Ry dWN0IHBoeSAqcm9ja2NoaXBfY29tYnBoeV94bGF0ZShzdHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0 IHN0cnVjdCBvZl9waAo+ICAgc3RhdGljIGludCByb2NrY2hpcF9jb21icGh5X3BhcnNlX2R0KHN0 cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfcHJpdiAqcHJpdikKPiAg IHsKPiAgIAlpbnQgaTsKPiArCWludCByZXQ7Cj4gICAKPiAgIAlwcml2LT5udW1fY2xrcyA9IGRl dm1fY2xrX2J1bGtfZ2V0X2FsbChkZXYsICZwcml2LT5jbGtzKTsKPiAgIAlpZiAocHJpdi0+bnVt X2Nsa3MgPCAxKQo+IEBAIC0zNzUsNiArMzc5LDE2IEBAIHN0YXRpYyBpbnQgcm9ja2NoaXBfY29t YnBoeV9wYXJzZV9kdChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCByb2NrY2hpcF9jb21icGh5 Cj4gICAKPiAgIAlwcml2LT5leHRfcmVmY2xrID0gZGV2aWNlX3Byb3BlcnR5X3ByZXNlbnQoZGV2 LCAicm9ja2NoaXAsZXh0LXJlZmNsayIpOwo+ICAgCj4gKwlpZiAoZGV2aWNlX3Byb3BlcnR5X3By ZXNlbnQoZGV2LCAicm9ja2NoaXAsc2dtaWktbWFjLXNlbCIpKSB7Cj4gKwkJcmV0ID0gZGV2aWNl X3Byb3BlcnR5X3JlYWRfdTMyKGRldiwgInJvY2tjaGlwLHNnbWlpLW1hYy1zZWwiLCAmcHJpdi0+ c2dtaWlfbWFjX3NlbCk7Cj4gKwkJaWYgKHJldCkgewo+ICsJCQlkZXZfZXJyKGRldiwgImZhaWxl ZCB0byByZWFkIHNnbWlpLW1hYy1zZWwgcHJvcGVydHlcbiIpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ ICsJCX0KPiArCgpkZXZpY2VfcHJvcGVydHlfcmVhZF91MzIoKSBzaG91bGQgcmV0dXJuIG5vbi16 ZXJvIHZhbHVlIGlmIGl0J3MgYWJzZW50LgpIb3cgYWJvdXQgdGhpczoKCglzdHJ1Y3Qgcm9ja2No aXBfY29tYnBoeV9wcml2IHsKCQlpbnQgc2dtaWlfbWFjX3NlbDsKCX0KCnN0YXRpYyBpbnQgcm9j a2NoaXBfY29tYnBoeV9wYXJzZV9kdDoKCXUzMiB2YWw7CgogICAgICAgICBwcml2LT5zZ21paV9t YWNfc2VsID0gLTE7CiAgICAgICAgIGlmICghZGV2aWNlX3Byb3BlcnR5X3JlYWRfdTMyKGRldiwg InJvY2tjaGlwLHNnbWlpLW1hYy1zZWwiLCAKJnZhbCkpIHsKICAgICAgICAgICAgICAgICBpZiAo dmFsID4gMSkKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBkZXZfZXJyX3Byb2JlKGRl diwgLUVJTlZBTCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJpbnZhbGlkIHNnbWlpLW1hYy1zZWwgCiV1XG4iLCB2YWwpOwogICAgICAgICAgICAgICAgIHBy aXYtPnNnbWlpX21hY19zZWwgPSB2YWw7CiAgICAgICAgIH0KCgpzdGF0aWMgaW50IHJrMzU2OF9j b21icGh5X2NmZzoKICAgICAgICAgY2FzZSBQSFlfVFlQRV9TR01JSToKICAgICAgICAgICAgICAg ICBpZiAocHJpdi0+c2dtaWlfbWFjX3NlbCA+PSAwKQogICAgICAgICAgICAgICAgICAgICAgICAg cm9ja2NoaXBfY29tYnBoeV9wYXJhbV93cml0ZShwcml2LT5waXBlX2dyZiwKICAKJmNmZy0+cGlw ZV9zZ21paV9tYWNfc2VsLAogIApwcml2LT5zZ21paV9tYWNfc2VsID4gMCk7Cgo+ICsJCXByaXYt PnNnbWlpX21hY19zZWxfcHJlc2VudCA9IHRydWU7Cj4gKwl9Cj4gKwo+ICAgCXByaXYtPnBoeV9y c3QgPSBkZXZtX3Jlc2V0X2NvbnRyb2xfZ2V0X2V4Y2x1c2l2ZShkZXYsICJwaHkiKTsKPiAgIAkv KiBmYWxsYmFjayB0byBvbGQgYmVoYXZpb3VyICovCj4gICAJaWYgKFBUUl9FUlIocHJpdi0+cGh5 X3JzdCkgPT0gLUVOT0VOVCkKPiBAQCAtODAzLDExICs4MTcsMzQgQEAgc3RhdGljIGNvbnN0IHN0 cnVjdCByb2NrY2hpcF9jb21icGh5X2NmZyByazM1NjJfY29tYnBoeV9jZmdzID0gewo+ICAgCS5j b21icGh5X2NmZwk9IHJrMzU2Ml9jb21icGh5X2NmZywKPiAgIH07Cj4gICAKPiArc3RhdGljIGlu dCByazM1NjhfY29tYnBoeV9zZWxlY3Rfc2dtaWlfbWFjKHN0cnVjdCByb2NrY2hpcF9jb21icGh5 X3ByaXYgKnByaXYpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCByb2NrY2hpcF9jb21icGh5X2dyZmNm ZyAqY2ZnID0gcHJpdi0+Y2ZnLT5ncmZjZmc7Cj4gKwo+ICsJaWYgKCFwcml2LT5zZ21paV9tYWNf c2VsX3ByZXNlbnQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJc3dpdGNoIChwcml2LT5zZ21paV9t YWNfc2VsKSB7Cj4gKwljYXNlIDA6Cj4gKwkJcm9ja2NoaXBfY29tYnBoeV9wYXJhbV93cml0ZShw cml2LT5waXBlX2dyZiwgJmNmZy0+cGlwZV9zZ21paV9tYWNfc2VsLCBmYWxzZSk7Cj4gKwkJYnJl YWs7Cj4gKwljYXNlIDE6Cj4gKwkJcm9ja2NoaXBfY29tYnBoeV9wYXJhbV93cml0ZShwcml2LT5w aXBlX2dyZiwgJmNmZy0+cGlwZV9zZ21paV9tYWNfc2VsLCB0cnVlKTsKPiArCQlicmVhazsKPiAr CWRlZmF1bHQ6Cj4gKwkJZGV2X2Vycihwcml2LT5kZXYsICJpbnZhbGlkIHNnbWlpLW1hYy1zZWwg dmFsdWUgJXVcbiIsIHByaXYtPnNnbWlpX21hY19zZWwpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ ICsJfQo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCByazM1NjhfY29t YnBoeV9jZmcoc3RydWN0IHJvY2tjaGlwX2NvbWJwaHlfcHJpdiAqcHJpdikKPiAgIHsKPiAgIAlj b25zdCBzdHJ1Y3Qgcm9ja2NoaXBfY29tYnBoeV9ncmZjZmcgKmNmZyA9IHByaXYtPmNmZy0+Z3Jm Y2ZnOwo+ICAgCXVuc2lnbmVkIGxvbmcgcmF0ZTsKPiAgIAl1MzIgdmFsOwo+ICsJaW50IHJldDsK PiAgIAo+ICAgCXN3aXRjaCAocHJpdi0+dHlwZSkgewo+ICAgCWNhc2UgUEhZX1RZUEVfUENJRToK PiBAQCAtODczLDYgKzkxMCwxMCBAQCBzdGF0aWMgaW50IHJrMzU2OF9jb21icGh5X2NmZyhzdHJ1 Y3Qgcm9ja2NoaXBfY29tYnBoeV9wcml2ICpwcml2KQo+ICAgCQlicmVhazsKPiAgIAo+ICAgCWNh c2UgUEhZX1RZUEVfU0dNSUk6Cj4gKwkJcmV0ID0gcmszNTY4X2NvbWJwaHlfc2VsZWN0X3NnbWlp X21hYyhwcml2KTsKPiArCQlpZiAocmV0KQo+ICsJCQlyZXR1cm4gcmV0Owo+ICsKPiAgIAkJcm9j a2NoaXBfY29tYnBoeV9wYXJhbV93cml0ZShwcml2LT5waXBlX2dyZiwgJmNmZy0+cGlwZV94cGNz X3BoeV9yZWFkeSwgdHJ1ZSk7Cj4gICAJCXJvY2tjaGlwX2NvbWJwaHlfcGFyYW1fd3JpdGUocHJp di0+cGh5X2dyZiwgJmNmZy0+cGlwZV9waHltb2RlX3NlbCwgdHJ1ZSk7Cj4gICAJCXJvY2tjaGlw X2NvbWJwaHlfcGFyYW1fd3JpdGUocHJpdi0+cGh5X2dyZiwgJmNmZy0+cGlwZV9zZWxfcXNnbWlp LCB0cnVlKTsKPiBAQCAtOTg0LDYgKzEwMjUsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJvY2tj aGlwX2NvbWJwaHlfZ3JmY2ZnIHJrMzU2OF9jb21icGh5X2dyZmNmZ3MgPSB7Cj4gICAJLmNvbjNf Zm9yX3NhdGEJCT0geyAweDAwMGMsIDE1LCAwLCAweDAwLCAweDQ0MDcgfSwKPiAgIAkvKiBwaXBl LWdyZiAqLwo+ICAgCS5waXBlX2NvbjBfZm9yX3NhdGEJPSB7IDB4MDAwMCwgMTUsIDAsIDB4MDAs IDB4MjIyMCB9LAo+ICsJLnBpcGVfc2dtaWlfbWFjX3NlbAk9IHsgMHgwMDQwLCAxLCAxLCAweDAw LCAweDAxIH0sCj4gICAJLnBpcGVfeHBjc19waHlfcmVhZHkJPSB7IDB4MDA0MCwgMiwgMiwgMHgw MCwgMHgwMSB9LAo+ICAgCS51M290ZzBfcG9ydF9lbgkJPSB7IDB4MDEwNCwgMTUsIDAsIDB4MDE4 MSwgMHgxMTAwIH0sCj4gICAJLnUzb3RnMV9wb3J0X2VuCQk9IHsgMHgwMTQ0LCAxNSwgMCwgMHgw MTgxLCAweDExMDAgfSwKCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1waHkK