From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Yongxing Mou <yongxing.mou@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] phy: qcom: edp: Add eDP phy mode switch support
Date: Fri, 6 Feb 2026 12:02:24 +0100 [thread overview]
Message-ID: <af15838f-6a31-4017-ae5d-7b5e30f24aa4@oss.qualcomm.com> (raw)
In-Reply-To: <20260205-edp_phy-v1-3-231882bbf3f1@oss.qualcomm.com>
On 2/5/26 10:20 AM, Yongxing Mou wrote:
> Add DP/eDP switch support by splitting the PHY swing/pre-emphasis tables
> into separate DP and eDP configurations. This allows the driver to select
> the correct table based on the is_edp flag.
>
> Add a dedicated table for the SC7280/glymur platforms, as they are not
> compatible with the others.
>
> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> ---
[...]
> +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = {
> + { 0x0b, 0x11, 0x16, 0x1b },
> + { 0x0b, 0x19, 0x1f, 0xff },
> + { 0x18, 0x1f, 0xff, 0xff },
> + { 0x1f, 0xff, 0xff, 0xff }
> +};
> +
> +static const u8 edp_pre_emp_hbr2_hbr3_v3[4][4] = {
> + { 0x0c, 0x15, 0x19, 0x1e },
> + { 0x09, 0x14, 0x19, 0xff },
> + { 0x0f, 0x14, 0xff, 0xff },
> + { 0x0d, 0xff, 0xff, 0xff }
> +};
This is not quite in line with docs for kodiak. Now, if you have
better/newer sequences than the HPG, I'm not objecting, but please
cross-check
the rest of this patch I think looks fine
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-02-06 11:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 9:20 [PATCH 0/3] phy: qcom: edp: Add DP/eDP switch for phys Yongxing Mou
2026-02-05 9:20 ` [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo PHY configuration values Yongxing Mou
2026-02-06 10:47 ` Konrad Dybcio
2026-02-09 9:00 ` Yongxing Mou
2026-02-09 12:46 ` Dmitry Baryshkov
2026-02-10 6:13 ` Yongxing Mou
2026-02-13 11:08 ` Konrad Dybcio
2026-02-07 10:22 ` Dmitry Baryshkov
2026-02-09 9:52 ` Yongxing Mou
2026-02-09 12:47 ` Dmitry Baryshkov
2026-02-10 10:17 ` Yongxing Mou
2026-02-10 12:33 ` Dmitry Baryshkov
2026-02-05 9:20 ` [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback Yongxing Mou
2026-02-06 10:52 ` Konrad Dybcio
2026-02-10 10:19 ` Yongxing Mou
2026-02-12 9:04 ` Yongxing Mou
2026-02-13 11:14 ` Konrad Dybcio
2026-02-25 7:21 ` Yongxing Mou
2026-02-07 10:17 ` Dmitry Baryshkov
2026-02-10 10:21 ` Yongxing Mou
2026-02-05 9:20 ` [PATCH 3/3] phy: qcom: edp: Add eDP phy mode switch support Yongxing Mou
2026-02-06 11:02 ` Konrad Dybcio [this message]
2026-02-10 10:29 ` Yongxing Mou
2026-02-13 11:06 ` Konrad Dybcio
2026-02-25 8:00 ` Yongxing Mou
2026-02-07 10:20 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af15838f-6a31-4017-ae5d-7b5e30f24aa4@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox