From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, cristian.ciocaltea@collabora.com,
detlev.casanova@collabora.com, krzk+dt@kernel.org,
vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
sebastian.reichel@collabora.com, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH] dt-bindings: phy: add rk3576 hdptx phy
Date: Sat, 28 Dec 2024 10:36:59 +0100 [thread overview]
Message-ID: <af945132-1ff3-41bd-a958-4241a9d171d5@kernel.org> (raw)
In-Reply-To: <5de24299.9cde.19407b99e5c.Coremail.andyshrk@163.com>
On 27/12/2024 11:46, Andy Yan wrote:
>>
>>> + - rockchip,rk3576-hdptx-phy
>>
>> So that's just enum with previous entry... but you said compatible, yet
>> nothing is here. Test your patches - DTS will fail on this. Driver as
>> well (assuming you expressed properly compatibility).
>
> Is this the right way to write it ？：
>
> properties:
> compatible:
> - enum:
> - - rockchip,rk3588-hdptx-phy
> + oneOf:
> + - enum:
> + - rockchip,rk3588-hdptx-phy
> + - items:
> + - enum:
> + - rockchip,rk3576-hdptx-phy
> + - const: rockchip,rk3588-hdptx-phy
Yes, assuming they are compatible.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-12-28 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 9:19 [PATCH] dt-bindings: phy: add rk3576 hdptx phy Andy Yan
2024-12-27 8:55 ` Krzysztof Kozlowski
2024-12-27 10:46 ` Andy Yan
2024-12-28 9:36 ` Krzysztof Kozlowski [this message]
2024-12-27 8:55 ` Krzysztof Kozlowski
2024-12-27 20:08 ` Heiko Stübner
2024-12-28 7:00 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af945132-1ff3-41bd-a958-4241a9d171d5@kernel.org \
--to=krzk@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox