From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Peng Fan <peng.fan@nxp.com>,
linux-can@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Josua Mayer <josua@solid-run.com>, Ulf Hansson <ulfh@kernel.org>
Subject: Re: [PATCH v3 0/4] phy: phy-can-transceiver: Ad-hoc cleanups and refactoring
Date: Sun, 10 May 2026 15:51:54 +0300 [thread overview]
Message-ID: <agB_aj_2hzF3ON2h@ashevche-desk.local> (raw)
In-Reply-To: <agBjOmnpKuZoDfWG@vaman>
On Sun, May 10, 2026 at 04:21:38PM +0530, Vinod Koul wrote:
> On 04-05-26, 08:58, Andy Shevchenko wrote:
> > The driver does two things that need to be addressed:
> > - includes subject to remove gpio.h
> > - checks for error code from device property APIs when it can be done in
> > a robust way
> >
> > This series addresses the above and adds a couple of additional refactoring.
>
> Sashiko flagged some issues, some of them not introduced by this, can
> you please check this:
>
> https://sashiko.dev/#/patchset/20260504070054.29508-1-andriy.shevchenko%40linux.intel.com
"Could this result in a null pointer dereference if device_get_match_data()
returns null?"
Yes, it sounds legit but not introduced here.
"In the original code, the warning was suppressed when the property was missing
because err evaluated to -EINVAL. Now, if the property is absent, max_bitrate
is explicitly set to 0 in the else block, which then unconditionally triggers
this warning."
True, but I don't know which is better here, I consider that it's
good to inform user about default being used as a fallback. I can change
this back to the original logic. What do you prefer?
The third one is the repetition of the first one (see above).
TL;DR: The only one legitimated question is about a (new old) warning.
--
With Best Regards,
Andy Shevchenko
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-05-10 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 6:58 [PATCH v3 0/4] phy: phy-can-transceiver: Ad-hoc cleanups and refactoring Andy Shevchenko
2026-05-04 6:58 ` [PATCH v3 1/4] phy: phy-can-transceiver: use device_get_match_data() Andy Shevchenko
2026-05-04 6:58 ` [PATCH v3 2/4] phy: phy-can-transceiver: Move OF ID table closer to their user Andy Shevchenko
2026-05-04 6:58 ` [PATCH v3 3/4] phy: phy-can-transceiver: Don't check for specific errors when parsing properties Andy Shevchenko
2026-05-04 6:58 ` [PATCH v3 4/4] phy: phy-can-transceiver: Drop unused include Andy Shevchenko
2026-05-10 10:51 ` [PATCH v3 0/4] phy: phy-can-transceiver: Ad-hoc cleanups and refactoring Vinod Koul
2026-05-10 12:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agB_aj_2hzF3ON2h@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=josua@solid-run.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=ulfh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox