From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: sashiko-reviews@lists.linux.dev
Cc: vkoul@kernel.org, linux-phy@lists.infradead.org,
olteanv@gmail.com, neil.armstrong@linaro.org
Subject: Re: [PATCH v4 2/5] phy: phy-can-transceiver: use device_get_match_data()
Date: Thu, 14 May 2026 00:51:00 +0300 [thread overview]
Message-ID: <agTyRALNTLTagy6y@ashevche-desk.local> (raw)
In-Reply-To: <20260513212611.EDC78C19425@smtp.kernel.org>
On Wed, May 13, 2026 at 09:26:11PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The error check for `device_get_match_data(dev)` is inverted, causing the driver probe to fail on success and triggering a NULL pointer dereference on failure.
Right, the typo due to rebase. Will fix in v5.
--
With Best Regards,
Andy Shevchenko
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-05-13 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 13:01 [PATCH v4 0/5] phy: phy-can-transceiver: Ad-hoc cleanups and refactoring Andy Shevchenko
2026-05-12 13:01 ` [PATCH v4 1/5] phy: phy-can-transceiver: Check driver match and driver data against NULL Andy Shevchenko
2026-05-12 13:01 ` [PATCH v4 2/5] phy: phy-can-transceiver: use device_get_match_data() Andy Shevchenko
2026-05-13 21:26 ` sashiko-bot
2026-05-13 21:51 ` Andy Shevchenko [this message]
2026-05-12 13:01 ` [PATCH v4 3/5] phy: phy-can-transceiver: Move OF ID table closer to their user Andy Shevchenko
2026-05-13 21:31 ` sashiko-bot
2026-05-12 13:01 ` [PATCH v4 4/5] phy: phy-can-transceiver: Don't check for specific errors when parsing properties Andy Shevchenko
2026-05-13 21:38 ` sashiko-bot
2026-05-12 13:01 ` [PATCH v4 5/5] phy: phy-can-transceiver: Drop unused include Andy Shevchenko
2026-05-13 21:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agTyRALNTLTagy6y@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox