From: Vinod Koul <vkoul@kernel.org>
To: aidenisik@member.fsf.org
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: exynos5-usbdrd: Add support for the Exynos5515 usbdrd phy
Date: Thu, 12 Nov 2026 16:38:22 +0530 [thread overview]
Message-ID: <avWeJqbpbLcWgq_R@parshuram> (raw)
In-Reply-To: <20261022-for-next-lucky7-usb-phy-v1-2-2e47f8484bf4@member.fsf.org>
On 22-10-26, 17:46, Aiden Isik via B4 Relay wrote:
> From: Aiden Isik <aidenisik@member.fsf.org>
>
> The Exynos5515 USBDRD PHY is a USB PHY which supports USB Super-Speed
> and High-Speed. Add support for High-Speed (UTMI+) operation.
>
> Signed-off-by: Aiden Isik <aidenisik@member.fsf.org>
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 43 ++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index f10cf7b6e0aa..8718e8f01e46 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -2075,6 +2075,46 @@ static const struct exynos5_usbdrd_phy_drvdata exynos5433_usbdrd_phy = {
> .n_regulators = ARRAY_SIZE(exynos5_regulator_names),
> };
>
> +static const struct exynos5_usbdrd_phy_tuning exynos5515_tunes_utmi_postinit[] = {
> + PHY_TUNING_ENTRY_PHY(EXYNOS850_DRD_HSPPARACON,
> + (HSPPARACON_TXVREF | HSPPARACON_TXRISE |
> + HSPPARACON_TXRES |
> + HSPPARACON_TXPREEMPPULSE |
> + HSPPARACON_TXPREEMPAMP |
> + HSPPARACON_TXHSXV | HSPPARACON_TXFSLS |
> + HSPPARACON_SQRX | HSPPARACON_OTG |
> + HSPPARACON_COMPDIS),
> + (FIELD_PREP_CONST(HSPPARACON_TXVREF, 15) |
> + FIELD_PREP_CONST(HSPPARACON_TXRISE, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXRES, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXPREEMPPULSE, 0) |
> + FIELD_PREP_CONST(HSPPARACON_TXPREEMPAMP, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXHSXV, 3) |
> + FIELD_PREP_CONST(HSPPARACON_TXFSLS, 3) |
> + FIELD_PREP_CONST(HSPPARACON_SQRX, 7) |
> + FIELD_PREP_CONST(HSPPARACON_OTG, 2) |
> + FIELD_PREP_CONST(HSPPARACON_COMPDIS, 7))),
> + PHY_TUNING_ENTRY_LAST
> +};
> +
> +static const struct exynos5_usbdrd_phy_tuning *exynos5515_tunes[PTS_MAX] = {
> + [PTS_UTMI_POSTINIT] = exynos5515_tunes_utmi_postinit,
> +};
> +
> +static const struct exynos5_usbdrd_phy_drvdata exynos5515_usbdrd_phy = {
> + .phy_cfg = phy_cfg_exynos850,
> + .n_phy_cfg = ARRAY_SIZE(phy_cfg_exynos850),
.n_phy_cfg does not exist.. Please fix this
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-11-12 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 16:46 [PATCH 0/2] Add Exynos5515 USB PHY support Aiden Isik via B4 Relay
2026-10-22 16:46 ` [PATCH 1/2] dt-bindings: phy: samsung,usb3-drd-phy: Add Exynos5515 compatible Aiden Isik via B4 Relay
2026-10-27 7:49 ` Krzysztof Kozlowski
2026-10-22 16:46 ` [PATCH 2/2] phy: exynos5-usbdrd: Add support for the Exynos5515 usbdrd phy Aiden Isik via B4 Relay
2026-11-01 11:04 ` Manivannan Sadhasivam
2026-11-12 11:08 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avWeJqbpbLcWgq_R@parshuram \
--to=vkoul@kernel.org \
--cc=aidenisik@member.fsf.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox