From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 676F5C433F5 for ; Thu, 28 Apr 2022 07:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8/qldDH+BMKfC5p6k/taBM2BOuiQnpw06C+E6K4k9OU=; b=zQyTKZZLxt/BOx zRizWxwx9vKnC0yXleQFU/+mUxLTszlau18Dq2QJCW1/j3ZnBKr8Vb/mC8BqLOw/7J3nUq16nfRjO Yc0OEg0M3+dsYbOpppT4W//J0/y4858ip0aMxJ+lRRwRt/rrCYuFWJpcqvPZXLS3phBTFIk21TjkM bJ3AQycFWZO5hbRThURh1b5x6l6RM/bWu899aHLlktFrFxArhk7ngGdzG0SiolMA6vGA+C6xeFsx/ lF/9NOyOsu7lHIn1+MsXsv8ryvKAg0JW6yHAsxyn1OR/M8jY1EaEZRyzfmMTsNFD0UBtAEVqB3wqS +o8cJGq+53c3Pl+9oqCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njyjv-005GEo-Of; Thu, 28 Apr 2022 07:39:03 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njyjf-005G63-9H for linux-phy@lists.infradead.org; Thu, 28 Apr 2022 07:38:48 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njyjA-0002DT-UD; Thu, 28 Apr 2022 09:38:16 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1njyjA-005iCB-4B; Thu, 28 Apr 2022 09:38:14 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1njyj7-0002Na-Pf; Thu, 28 Apr 2022 09:38:13 +0200 Message-ID: Subject: Re: [RFC/RFT v2 04/11] phy: rockchip: Support PCIe v3 From: Philipp Zabel To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , Lorenzo Pieralisi , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Johan Jonker , Peter Geis , Michael Riesch , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Date: Thu, 28 Apr 2022 09:38:13 +0200 In-Reply-To: <20220426132139.26761-5-linux@fw-web.de> References: <20220426132139.26761-1-linux@fw-web.de> <20220426132139.26761-5-linux@fw-web.de> User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_003847_368502_14237486 X-CRM114-Status: UNSURE ( 6.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Frank, On Di, 2022-04-26 at 15:21 +0200, Frank Wunderlich wrote: > + priv->p30phy = devm_reset_control_get_exclusive(dev, "phy"); > + if (IS_ERR(priv->p30phy)) { > + dev_warn(dev, "no phy reset control specified\n"); > + priv->p30phy = NULL; > + } Please use devm_reset_control_get_optional_exclusive() [1] instead, which already returns NULL if no reset control is specified, and return on errors. [1] https://docs.kernel.org/driver-api/reset.html#c.devm_reset_control_get_optional_exclusive regards Philipp -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy