From: Yijie Yang <quic_yijiyang@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
<netdev@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <quic_tingweiz@quicinc.com>,
<quic_aiquny@quicinc.com>
Subject: Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300
Date: Tue, 15 Oct 2024 14:21:44 +0800 [thread overview]
Message-ID: <b2f027d1-5b4a-4b73-aa26-a332df2a561b@quicinc.com> (raw)
In-Reply-To: <da45vocnwnnnlo6nrxh6x4xwmnsgdp5axfvomzniw5vxlmerer@6ntl3ae4q2ci>
On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>> Add compatible for the MAC controller on qcs8300 platforms.
>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>> compatible.
>>
>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> index 8cf29493b822..3ee5367bdde1 100644
>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> @@ -23,6 +23,10 @@ properties:
>> - enum:
>> - qcom,qcs615-ethqos
>> - const: qcom,sm8150-ethqos
>> + - items:
>> + - enum:
>> + - qcom,qcs8300-ethqos
>> + - const: qcom,sa8775p-ethqos
>
> This block should go before earlier qcs615, to keep order by fallback.
Why this block should positioned before qcs615, given that it comes
later in alphabetical order?
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-10-15 6:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 2:03 [PATCH 0/3] Add ethernet dts schema for qcs615/qcs8300 Yijie Yang
2024-10-10 2:03 ` [PATCH 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615 Yijie Yang
2024-10-10 6:14 ` Krzysztof Kozlowski
2024-10-10 2:03 ` [PATCH 2/3] dt-bindings: phy: describe the Qualcomm SGMII PHY Yijie Yang
2024-10-10 6:14 ` Krzysztof Kozlowski
2024-10-10 2:03 ` [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300 Yijie Yang
2024-10-10 6:15 ` Krzysztof Kozlowski
2024-10-15 6:21 ` Yijie Yang [this message]
2024-10-15 6:27 ` Krzysztof Kozlowski
2024-10-15 7:22 ` Yijie Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2f027d1-5b4a-4b73-aa26-a332df2a561b@quicinc.com \
--to=quic_yijiyang@quicinc.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_aiquny@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox