From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Wesley Cheng <wesley.cheng@oss.qualcomm.com>,
krzk+dt@kernel.org, conor+dt@kernel.org,
dmitry.baryshkov@oss.qualcomm.com, kishon@kernel.org,
vkoul@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings
Date: Thu, 25 Sep 2025 12:43:19 +0200 [thread overview]
Message-ID: <bc866f21-9b41-43dc-b450-59a25d547b88@oss.qualcomm.com> (raw)
In-Reply-To: <20250925022850.4133013-8-wesley.cheng@oss.qualcomm.com>
On 9/25/25 4:28 AM, Wesley Cheng wrote:
> For SuperSpeed USB to work properly, there is a set of HW settings that
> need to be programmed into the USB blocks within the QMP PHY. Ensure that
> these settings follow the latest settings mentioned in the HW programming
> guide. The QMP USB PHY on Glymur is a USB43 based PHY that will have some
> new ways to define certain registers, such as the replacement of TXA/RXA
> and TXB/RXB register sets. This was replaced with the LALB register set.
[...]
> + /* override hardware control for reset of qmp phy */
> + if (pcs_aon && cfg->regs[QPHY_AON_TOGGLE_ENABLE])
> + qphy_clrbits(pcs_aon, cfg->regs[QPHY_AON_TOGGLE_ENABLE], 0x1);
Clearing this field is going to prevent the PHY from ever going offline
The HPG says this should only be necessary for keeping the phy active
during MX retention (and the listed usecases are USB4 wakeup clock
generation via a respective _USB4 register and/or USB3 autonomous mode
operation), both of which are currently unsupported.
Are you sure it's necessary / desired?
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-09-25 10:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 2:28 [PATCH v3 00/10] Introduce Glymur USB support Wesley Cheng
2025-09-25 2:28 ` [PATCH v3 01/10] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible Wesley Cheng
2025-09-25 2:50 ` Dmitry Baryshkov
2025-09-25 2:28 ` [PATCH v3 02/10] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible Wesley Cheng
2025-09-25 2:28 ` [PATCH v3 03/10] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible Wesley Cheng
2025-09-25 2:28 ` [PATCH v3 04/10] dt-bindings: usb: qcom,snps-dwc3: " Wesley Cheng
2025-09-25 2:28 ` [PATCH v3 05/10] dt-bindings: phy: qcom,snps-eusb2-repeater: Add SMB2370 compatible Wesley Cheng
2025-09-25 2:28 ` [PATCH v3 06/10] phy: qualcomm: Update the QMP clamp register for V6 Wesley Cheng
2025-09-25 2:28 ` [PATCH v3 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings Wesley Cheng
2025-09-25 2:54 ` Dmitry Baryshkov
2025-09-26 0:14 ` Wesley Cheng
2025-09-26 2:11 ` Dmitry Baryshkov
2025-09-27 0:26 ` Wesley Cheng
2025-09-25 10:43 ` Konrad Dybcio [this message]
2025-09-25 23:03 ` Wesley Cheng
2025-10-01 9:41 ` Konrad Dybcio
2025-09-26 6:41 ` Abel Vesa
2025-09-25 2:28 ` [PATCH v3 08/10] phy: qualcomm: qmp-usb: Add support for Glymur USB UNI PHY Wesley Cheng
2025-09-25 2:55 ` Dmitry Baryshkov
2025-09-25 2:28 ` [PATCH v3 09/10] phy: qualcomm: m31-eusb2: Make clkref an optional resource Wesley Cheng
2025-09-25 9:27 ` Konrad Dybcio
2025-09-25 2:28 ` [PATCH v3 10/10] phy: qualcomm: eusb2-repeater: Add SMB2370 eUSB2 repeater support Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc866f21-9b41-43dc-b450-59a25d547b88@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=wesley.cheng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox