From: Konrad Dybcio <konradybcio@kernel.org>
To: Sricharan R <quic_srichara@quicinc.com>,
bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
p.zabel@pengutronix.de, dmitry.baryshkov@linaro.org,
quic_nsekar@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
robimarko@gmail.com
Subject: Re: [PATCH V3 3/6] phy: qcom: Introduce PCIe UNIPHY 28LP driver
Date: Thu, 5 Sep 2024 15:47:35 +0200 [thread overview]
Message-ID: <bf114807-c56c-4209-ab26-9e90ac00cedf@kernel.org> (raw)
In-Reply-To: <20240830081132.4016860-4-quic_srichara@quicinc.com>
On 30.08.2024 10:11 AM, Sricharan R wrote:
> From: Nitheesh Sekar <quic_nsekar@quicinc.com>
>
> Add Qualcomm PCIe UNIPHY 28LP driver support present
> in Qualcomm IPQ5018 SoC and the phy init sequence.
>
> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com>
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> ---
[...]
> +static const struct qcom_uniphy_pcie_data ipq5018_2x1_data = {
> + .lanes = 1,
> + .lane_offset = 0x800,
> + .phy_type = PHY_TYPE_PCIE_GEN2,
> + .init_seq = ipq5018_regs,
> + .init_seq_num = ARRAY_SIZE(ipq5018_regs),
> +};
> +
> +static const struct qcom_uniphy_pcie_data ipq5018_2x2_data = {
> + .lanes = 2,
> + .lane_offset = 0x800,
> + .phy_type = PHY_TYPE_PCIE_GEN2,
> + .init_seq = ipq5018_regs,
> + .init_seq_num = ARRAY_SIZE(ipq5018_regs),
> +};
As krzk suggested, the difference is just num-lanes
[...]
> +static int qcom_uniphy_pcie_power_off(struct phy *x)
> +{
> + struct qcom_uniphy_pcie *phy = phy_get_drvdata(x);
> +
> + reset_control_assert(phy->resets);
Is the reset line supposed to be kept asserted?
[...]
> +MODULE_LICENSE("Dual BSD/GPL");
Was that intended?
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-09-05 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 8:11 [PATCH V3 0/6] Enable IPQ5018 PCI support Sricharan R
2024-08-30 8:11 ` [PATCH V3 1/6] dt-bindings: phy: qcom,uniphy-pcie: Document PCIe uniphy Sricharan R
2024-08-30 8:23 ` Krzysztof Kozlowski
2024-09-04 17:20 ` Sricharan Ramabadhran
2024-09-04 18:16 ` Krzysztof Kozlowski
2024-08-30 8:11 ` [PATCH V3 2/6] dt-bindings: PCI: qcom: Add IPQ5108 SoC Sricharan R
2024-08-30 8:11 ` [PATCH V3 3/6] phy: qcom: Introduce PCIe UNIPHY 28LP driver Sricharan R
2024-09-05 13:47 ` Konrad Dybcio [this message]
2024-08-30 8:11 ` [PATCH V3 4/6] PCI: qcom: Add support for IPQ5018 Sricharan R
2024-08-30 8:11 ` [PATCH V3 5/6] arm64: dts: qcom: ipq5018: Add PCIe related nodes Sricharan R
2024-08-30 8:11 ` [PATCH V3 6/6] arm64: dts: qcom: ipq5018: Enable PCIe Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf114807-c56c-4209-ab26-9e90ac00cedf@kernel.org \
--to=konradybcio@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_nsekar@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).