Re: [PATCH v2 2/4] phy: rockchip-samsung-dcphy: factor MIPI D-PHY power on/off into helpers

From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: jason98166@gmail.com, Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Guochun Huang <hero.huang@rock-chips.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] phy: rockchip-samsung-dcphy: factor MIPI D-PHY power on/off into helpers
Date: Fri, 7 Aug 2026 10:09:23 +0100	[thread overview]
Message-ID: <c3cbebcf-19f5-4944-9e20-04dbb442c4d9@linaro.org> (raw)
In-Reply-To: <anTgZiqnol4226Le@venus>

On 06/08/2026 20:31, Sebastian Reichel wrote:
>> This looks a bit funny.
>>
>> Do you have an int method() {} with a final path that returns no value ?
>>
>> Tooling/compilers will definitely and rightly complain about that.
> int function() {
>      ...
> 
>      switch(foo) {
>      case 42:
>          return 1;
>      default:
>          return 0;
>      }
>      /* cannot be reached */
> }
> 
> Greetings,
> 
> -- Sebastian

Hmm.

The LLM tells me there is no compiler version that will generate a 
warning for this.

Entertaining overdone too

"Across compilers that will ever see this code: yes, and I can now show 
it rather than assert it — I installed the spread. gcc 12, 13, 14 and 
clang 18, from -Wall -Wextra -Wpedantic upward: clean. Then the decisive 
one: clang -Weverything — every diagnostic clang possesses, a strict 
superset of any CI configuration that can exist — on Sebastian's exact 
function: zero output."

Meh

---
bod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy