From: Roger Quadros <rogerq@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
vkoul@kernel.org, kishon@kernel.org
Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH 1/2] phy: ti: gmii-sel: Add support for CPSW9G GMII SEL in J784S4
Date: Fri, 31 Mar 2023 10:45:00 +0300 [thread overview]
Message-ID: <cfcdb25b-5426-2532-ab8c-224a5e33baf3@kernel.org> (raw)
In-Reply-To: <20230331062521.529005-2-s-vadapalli@ti.com>
On 31/03/2023 09:25, Siddharth Vadapalli wrote:
> Each of the CPSW9G ports in TI's J784S4 SoC support modes such as QSGMII.
>
> Add a new compatible for it and allow the usage of "ti,qsgmii-main-ports"
> property for J784S4.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
> drivers/phy/ti/phy-gmii-sel.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
> index c87118cb2af9..fba5c0c0771c 100644
> --- a/drivers/phy/ti/phy-gmii-sel.c
> +++ b/drivers/phy/ti/phy-gmii-sel.c
> @@ -235,6 +235,15 @@ struct phy_gmii_sel_soc_data phy_gmii_sel_cpsw9g_soc_j721e = {
> .num_qsgmii_main_ports = 2,
> };
>
> +static const
> +struct phy_gmii_sel_soc_data phy_gmii_sel_cpsw9g_soc_j784s4 = {
Please make it into one line
> + .use_of_data = true,
> + .regfields = phy_gmii_sel_fields_am654,
> + .extra_modes = BIT(PHY_INTERFACE_MODE_QSGMII),
> + .num_ports = 8,
> + .num_qsgmii_main_ports = 2,
> +};
> +
> static const struct of_device_id phy_gmii_sel_id_table[] = {
> {
> .compatible = "ti,am3352-phy-gmii-sel",
> @@ -264,6 +273,10 @@ static const struct of_device_id phy_gmii_sel_id_table[] = {
> .compatible = "ti,j721e-cpsw9g-phy-gmii-sel",
> .data = &phy_gmii_sel_cpsw9g_soc_j721e,
> },
> + {
> + .compatible = "ti,j784s4-cpsw9g-phy-gmii-sel",
> + .data = &phy_gmii_sel_cpsw9g_soc_j784s4,
> + },
> {}
> };
> MODULE_DEVICE_TABLE(of, phy_gmii_sel_id_table);
--
cheers,
-roger
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-03-31 7:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 6:25 [PATCH 0/2] PHY-GMII-SEL: Add support for J784S4 SoC Siddharth Vadapalli
2023-03-31 6:25 ` [PATCH 1/2] phy: ti: gmii-sel: Add support for CPSW9G GMII SEL in J784S4 Siddharth Vadapalli
2023-03-31 7:45 ` Roger Quadros [this message]
2023-03-31 7:49 ` Siddharth Vadapalli
2023-03-31 7:53 ` Roger Quadros
2023-03-31 6:25 ` [PATCH 2/2] phy: ti: gmii-sel: Enable USXGMII mode for J784S4 Siddharth Vadapalli
2023-03-31 7:45 ` Roger Quadros
2023-03-31 13:33 ` [PATCH 0/2] PHY-GMII-SEL: Add support for J784S4 SoC Vinod Koul
2023-03-31 13:49 ` Siddharth Vadapalli
2023-05-16 14:31 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfcdb25b-5426-2532-ab8c-224a5e33baf3@kernel.org \
--to=rogerq@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).