[PATCH v2 0/3] LAN966x PCIe endpoint cleanups

[PATCH v2 0/3] LAN966x PCIe endpoint cleanups

[Geert Uytterhoeven]

	Hi all,

This patch series contains various cleanups related to the recent
addition of LAN966x PCIe endpoint support.  They can be applied
independently.

Changes compared to v1[1]:
  - Drop dependency on SOC_LAN966, as the OIC is used only in LAN966x
    PCI endpoint mode,
  - Replace MFD_LAN966X_PCI by MCHP_LAN966X_PCI, as the latter is the
    symbol that ended upstream.
  - New patches [1/3] and [3/3],

Thanks for your comments!

[1] "[PATCH] irqchip: LAN966X_OIC should depend on SOC_LAN966 || MFD_LAN966X_PCI"
    https://lore.kernel.org/578dafcbdf8287e73dd30e96e23814b8c029ea96.1721719060.git.geert+renesas@glider.be

Geert Uytterhoeven (3):
  dt-bindings: interrupt-controller: microchip,lan966x-oic: Clarify
    endpoint use
  irqchip: LAN966X_OIC should depend on MFD_LAN966X_PCI
  phy: PHY_LAN966X_SERDES should depend on SOC_LAN966 ||
    MCHP_LAN966X_PCI

 .../bindings/interrupt-controller/microchip,lan966x-oic.yaml | 5 ++---
 drivers/irqchip/Kconfig                                      | 1 +
 drivers/phy/microchip/Kconfig                                | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.43.0

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

[PATCH v2 1/3] dt-bindings: interrupt-controller: microchip,lan966x-oic: Clarify endpoint use

[Geert Uytterhoeven]

Reword the description, to make it clear that the LAN966x Outbound
Interrupt Controller is used only in PCI endpoint mode.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 .../bindings/interrupt-controller/microchip,lan966x-oic.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/microchip,lan966x-oic.yaml b/Documentation/devicetree/bindings/interrupt-controller/microchip,lan966x-oic.yaml
index b2adc71741770940..dca16e202da992cd 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/microchip,lan966x-oic.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/microchip,lan966x-oic.yaml
@@ -14,9 +14,8 @@ allOf:
 
 description: |
   The Microchip LAN966x outband interrupt controller (OIC) maps the internal
-  interrupt sources of the LAN966x device to an external interrupt.
-  When the LAN966x device is used as a PCI device, the external interrupt is
-  routed to the PCI interrupt.
+  interrupt sources of the LAN966x device to a PCI interrupt when the LAN966x
+  device is used as a PCI device.
 
 properties:
   compatible:
-- 
2.43.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

[PATCH v2 2/3] irqchip: LAN966X_OIC should depend on MFD_LAN966X_PCI

[Geert Uytterhoeven]

The Microchip LAN966x outband interrupt controller is only present on
Microchip LAN966x SoCs, and only used in PCI endpoint mode.  Hence add a
dependency on MCHP_LAN966X_PCI, to prevent asking the user about this
driver when configuring a kernel without Microchip LAN966x PCIe support.

Fixes: 3e3a7b35332924c8 ("irqchip: Add support for LAN966x OIC")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop dependency on SOC_LAN966, as the OIC is used only in LAN966x
    PCI endpoint mode,
  - Replace MFD_LAN966X_PCI by MCHP_LAN966X_PCI, as the latter is the
    symbol that ended upstream.
---
 drivers/irqchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 22f5fbd41f65d97e..cf713b6e9cc9346f 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -169,6 +169,7 @@ config IXP4XX_IRQ
 
 config LAN966X_OIC
 	tristate "Microchip LAN966x OIC Support"
+	depends on MCHP_LAN966X_PCI || COMPILE_TEST
 	select GENERIC_IRQ_CHIP
 	select IRQ_DOMAIN
 	help
-- 
2.43.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

[PATCH v2 3/3] phy: PHY_LAN966X_SERDES should depend on SOC_LAN966 || MCHP_LAN966X_PCI

[Geert Uytterhoeven]

The Microchip LAN966X SerDes PHY is only present on Microchip LAN966x
SoCs.  However, when used as a PCI endpoint, all peripherals of the
LAN966x SoC can be accessed by the PCI host.  Hence add dependencies on
SOC_LAN966 and MFD_LAN966X_PCI, to prevent asking the user about this
driver when configuring a kernel without Microchip LAN966x SoC and PCIe
support.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 drivers/phy/microchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig
index 38039ed0754c6548..2f0045e874ac81ad 100644
--- a/drivers/phy/microchip/Kconfig
+++ b/drivers/phy/microchip/Kconfig
@@ -15,6 +15,7 @@ config PHY_SPARX5_SERDES
 config PHY_LAN966X_SERDES
 	tristate "SerDes PHY driver for Microchip LAN966X"
 	select GENERIC_PHY
+	depends on SOC_LAN966 || MCHP_LAN966X_PCI || COMPILE_TEST
 	depends on OF
 	depends on MFD_SYSCON
 	help
-- 
2.43.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v2 1/3] dt-bindings: interrupt-controller: microchip,lan966x-oic: Clarify endpoint use

[Krzysztof Kozlowski]

On 17/01/2025 14:04, Geert Uytterhoeven wrote:
> Reword the description, to make it clear that the LAN966x Outbound
> Interrupt Controller is used only in PCI endpoint mode.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v2 1/3] dt-bindings: interrupt-controller: microchip,lan966x-oic: Clarify endpoint use

[Herve Codina]

Hi Geert,

On Fri, 17 Jan 2025 14:04:36 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> Reword the description, to make it clear that the LAN966x Outbound
> Interrupt Controller is used only in PCI endpoint mode.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - New.
> ---
>  .../bindings/interrupt-controller/microchip,lan966x-oic.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Acked-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v2 2/3] irqchip: LAN966X_OIC should depend on MFD_LAN966X_PCI

[Herve Codina]

Hi Geert,

On Fri, 17 Jan 2025 14:04:37 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> The Microchip LAN966x outband interrupt controller is only present on
> Microchip LAN966x SoCs, and only used in PCI endpoint mode.  Hence add a
> dependency on MCHP_LAN966X_PCI, to prevent asking the user about this
> driver when configuring a kernel without Microchip LAN966x PCIe support.
> 
> Fixes: 3e3a7b35332924c8 ("irqchip: Add support for LAN966x OIC")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Drop dependency on SOC_LAN966, as the OIC is used only in LAN966x
>     PCI endpoint mode,
>   - Replace MFD_LAN966X_PCI by MCHP_LAN966X_PCI, as the latter is the
>     symbol that ended upstream.
> ---
>  drivers/irqchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Thanks for this patch!

Acked-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v2 3/3] phy: PHY_LAN966X_SERDES should depend on SOC_LAN966 || MCHP_LAN966X_PCI

[Herve Codina]

Hi Geert,

On Fri, 17 Jan 2025 14:04:38 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> The Microchip LAN966X SerDes PHY is only present on Microchip LAN966x
> SoCs.  However, when used as a PCI endpoint, all peripherals of the
> LAN966x SoC can be accessed by the PCI host.  Hence add dependencies on
                                              ^^ Two spaces

> SOC_LAN966 and MFD_LAN966X_PCI, to prevent asking the user about this

s/MFD_LAN966X_PCI/MCHP_LAN966X_PCI/

> driver when configuring a kernel without Microchip LAN966x SoC and PCIe
> support.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

With those minor things fixed,

Acked-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v2 3/3] phy: PHY_LAN966X_SERDES should depend on SOC_LAN966 || MCHP_LAN966X_PCI

[Geert Uytterhoeven]

Hi Hervé,

On Mon, Jan 20, 2025 at 9:07 AM Herve Codina <herve.codina@bootlin.com> wrote:
> On Fri, 17 Jan 2025 14:04:38 +0100
> Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > The Microchip LAN966X SerDes PHY is only present on Microchip LAN966x
> > SoCs.  However, when used as a PCI endpoint, all peripherals of the
> > LAN966x SoC can be accessed by the PCI host.  Hence add dependencies on
>                                               ^^ Two spaces

That's intentional: more space after a period terminating a sentence...

> > SOC_LAN966 and MFD_LAN966X_PCI, to prevent asking the user about this
>
> s/MFD_LAN966X_PCI/MCHP_LAN966X_PCI/

Bummer, how did I miss that?

> > driver when configuring a kernel without Microchip LAN966x SoC and PCIe
> > support.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> With those minor things fixed,
>
> Acked-by: Herve Codina <herve.codina@bootlin.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v2 2/3] irqchip: LAN966X_OIC should depend on MFD_LAN966X_PCI

[Geert Uytterhoeven]

On Fri, 17 Jan 2025 at 14:04, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> The Microchip LAN966x outband interrupt controller is only present on
> Microchip LAN966x SoCs, and only used in PCI endpoint mode.  Hence add a
> dependency on MCHP_LAN966X_PCI, to prevent asking the user about this
> driver when configuring a kernel without Microchip LAN966x PCIe support.
>
> Fixes: 3e3a7b35332924c8 ("irqchip: Add support for LAN966x OIC")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Drop dependency on SOC_LAN966, as the OIC is used only in LAN966x
>     PCI endpoint mode,
>   - Replace MFD_LAN966X_PCI by MCHP_LAN966X_PCI, as the latter is the
>     symbol that ended upstream.

Bummer, I messed up the subject here as well...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy