[PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains

[PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains

[André Draszik]

The UFS phy can be part of a power domain, so we need to allow the
relevant property 'power-domains'.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
index d70ffeb6e824bfc19668e0f678276acd879a6217..2b20c0a5e5094889eb3e80dcc21b505943c68523 100644
--- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
@@ -36,6 +36,9 @@ properties:
     minItems: 1
     maxItems: 4
 
+  power-domains:
+    maxItems: 1
+
   samsung,pmu-syscon:
     $ref: /schemas/types.yaml#/definitions/phandle-array
     maxItems: 1

---
base-commit: 3b9b1f8df454caa453c7fb07689064edb2eda90a
change-id: 20251007-power-domains-dt-bindings-phy-samsung-ufs-phy-fce95e2eae38

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains

[Peter Griffin]

On Tue, 7 Oct 2025 at 17:01, André Draszik <andre.draszik@linaro.org> wrote:
>
> The UFS phy can be part of a power domain, so we need to allow the
> relevant property 'power-domains'.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---

Reviewed-by: Peter Griffin <peter.griffin@linaro.org>

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains

[Krzysztof Kozlowski]

On 08/10/2025 01:01, André Draszik wrote:
> The UFS phy can be part of a power domain, so we need to allow the
> relevant property 'power-domains'.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

RE: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains

[Alim Akhtar]

> -----Original Message-----
> From: André Draszik <andre.draszik@linaro.org>
> Sent: Tuesday, October 7, 2025 9:32 PM
> To: Vinod Koul <vkoul@kernel.org>; Kishon Vijay Abraham I
> <kishon@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Alim Akhtar
> <alim.akhtar@samsung.com>
> Cc: Peter Griffin <peter.griffin@linaro.org>; Tudor Ambarus
> <tudor.ambarus@linaro.org>; Will McVicker <willmcvicker@google.com>;
> kernel-team@android.com; linux-phy@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; André Draszik
> <andre.draszik@linaro.org>
> Subject: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains
> 
> The UFS phy can be part of a power domain, so we need to allow the
> relevant property 'power-domains'.
> 
Can you cross check if there is a separate power domain control for ufs-phy? 

> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> index
> d70ffeb6e824bfc19668e0f678276acd879a6217..2b20c0a5e5094889eb3e80dcc2
> 1b505943c68523 100644
> --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> @@ -36,6 +36,9 @@ properties:
>      minItems: 1
>      maxItems: 4
> 
> +  power-domains:
> +    maxItems: 1
> +
>    samsung,pmu-syscon:
>      $ref: /schemas/types.yaml#/definitions/phandle-array
>      maxItems: 1
> 
> ---
> base-commit: 3b9b1f8df454caa453c7fb07689064edb2eda90a
> change-id: 20251007-power-domains-dt-bindings-phy-samsung-ufs-phy-
> fce95e2eae38
> 
> Best regards,
> --
> André Draszik <andre.draszik@linaro.org>




-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains

[André Draszik]

Hi Alim,

On Wed, 2025-10-08 at 11:56 +0530, Alim Akhtar wrote:
> 
> 
> > -----Original Message-----
> > From: André Draszik <andre.draszik@linaro.org>
> > Sent: Tuesday, October 7, 2025 9:32 PM
> > To: Vinod Koul <vkoul@kernel.org>; Kishon Vijay Abraham I
> > <kishon@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Alim Akhtar
> > <alim.akhtar@samsung.com>
> > Cc: Peter Griffin <peter.griffin@linaro.org>; Tudor Ambarus
> > <tudor.ambarus@linaro.org>; Will McVicker <willmcvicker@google.com>;
> > kernel-team@android.com; linux-phy@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; André Draszik
> > <andre.draszik@linaro.org>
> > Subject: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains
> > 
> > The UFS phy can be part of a power domain, so we need to allow the
> > relevant property 'power-domains'.
> > 
> Can you cross check if there is a separate power domain control for ufs-phy? 

I'm still having some other troubles with the hsi2 (UFS) power domain on gs101,
but I can confirm the usb-phy is part of the hsi0 (USB) power domain. So for the
ufs-phy I presume it's similar: it should be part of the hsi2 power domain. There
certainly is no separate domain for the ufs-phy itself.

See also my reply to the other patch:
https://lore.kernel.org/all/ff3a0b96980669f326ed02ed81b97d34c104b09d.camel@linaro.org/

Does that answer your question?

Cheers,
Andre'

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains

[André Draszik]

Alim,

On Wed, 2025-10-08 at 09:07 +0100, André Draszik wrote:
> Hi Alim,
> 
> On Wed, 2025-10-08 at 11:56 +0530, Alim Akhtar wrote:
> > 
> > 
> > > -----Original Message-----
> > > From: André Draszik <andre.draszik@linaro.org>
> > > Sent: Tuesday, October 7, 2025 9:32 PM
> > > To: Vinod Koul <vkoul@kernel.org>; Kishon Vijay Abraham I
> > > <kishon@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> > > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Alim Akhtar
> > > <alim.akhtar@samsung.com>
> > > Cc: Peter Griffin <peter.griffin@linaro.org>; Tudor Ambarus
> > > <tudor.ambarus@linaro.org>; Will McVicker <willmcvicker@google.com>;
> > > kernel-team@android.com; linux-phy@lists.infradead.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; André Draszik
> > > <andre.draszik@linaro.org>
> > > Subject: [PATCH] dt-bindings: phy: samsung,ufs-phy: add power-domains
> > > 
> > > The UFS phy can be part of a power domain, so we need to allow the
> > > relevant property 'power-domains'.
> > > 
> > Can you cross check if there is a separate power domain control for ufs-phy? 
> 
> I'm still having some other troubles with the hsi2 (UFS) power domain on gs101,
> but I can confirm the usb-phy is part of the hsi0 (USB) power domain. So for the
> ufs-phy I presume it's similar: it should be part of the hsi2 power domain. There
> certainly is no separate domain for the ufs-phy itself.

After double checking the HSI2 HDD, the ufs-phy is indeed part of PD_HSI2.


Cheers,
Andre'

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy