From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E826C636CC for ; Tue, 7 Feb 2023 13:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BT69V0qEfGmSMl+uz7Zv+aWN9gsHmcxEa3/UgXD0hWc=; b=3PMrg+VASvXEDx +H3gA9c5WY+9WPu0r0XRGY/qOQAb1zHMwf6NpIEuauB9mbJiCy1B99s1J26mTxmv0stMrmqFVwPPI fkqu8QfFxgbLGR6TwtiZdlVCo05RWpmHcXFjgGyIV9/84HBHVR61oZeK1mGbLHKxqghs+pJRC93Qx VuFHKPc7ch+9cWMUkDaJNmFlbftOsodvAreT0UBQ6x3Igy6UN+AQ2J6wsJ/VWdxYlppqPwFz2R4js AA9ieWiioDsKn+SbKo2ivgN6vsUO8ef1mCdJ6TJasUWnl36bdfI3n03j4mcCUhR3VM2eFxeM+VRi0 UpESrrED9KPMoC8Qtcpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPO4x-00CIhj-3I; Tue, 07 Feb 2023 13:32:11 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPO4t-00CIeu-EY; Tue, 07 Feb 2023 13:32:09 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 317ArI1e008460; Tue, 7 Feb 2023 14:31:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=DvaNpdrSgE+lHP2IkmzvxSLVAaIdRRvLf0BwPPBEci4=; b=aQaSbkCpRXS5PTBvs/7A4rURHj3O8ll9TldW/dJbYL96OW9dyidgNbpqQ2IMwlJcHYfV PCVnikmHA0+/GU/YHrkk37G8Rh1vwsakP87ID7Au4i9IPIaHZeIDNhs3YvOTq1WTSruH P/8HpNo2WO25T81982igFgAtil5zgYjG1s7tQEMU059ZhJ/Ri0m3Ps7/HUr6/6js0yXH 74wlbwkqH4zm93ascw8YJ8mG5y0V5j0ZKxb4kjWICzncOKYOnHM36Ik5nhtQdo8YyV1/ CkELeSEYnoaCyUnTE4l4Y2LIuOvGfr53WsS7P8Z1L0NcrxY6EwxnjvkuyxgzkO+gacI9 kw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3nhdcfk48x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Feb 2023 14:31:34 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B91DA10002A; Tue, 7 Feb 2023 14:31:21 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id F17372194F5; Tue, 7 Feb 2023 14:31:20 +0100 (CET) Received: from [10.201.20.249] (10.201.20.249) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 14:31:19 +0100 Message-ID: Date: Tue, 7 Feb 2023 14:31:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 3/6] dt-bindings: bus: add STM32 System Bus To: Jonathan Cameron CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Loic PALLARDY References: <20230127164040.1047583-1-gatien.chevallier@foss.st.com> <20230127164040.1047583-4-gatien.chevallier@foss.st.com> <20230128154827.4f23534e@jic23-huawei> Content-Language: en-US From: Gatien CHEVALLIER In-Reply-To: <20230128154827.4f23534e@jic23-huawei> X-Originating-IP: [10.201.20.249] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-07_05,2023-02-06_03,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_053207_816558_27A559D5 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hello Jonathan, On 1/28/23 16:48, Jonathan Cameron wrote: > On Fri, 27 Jan 2023 17:40:37 +0100 > Gatien Chevallier wrote: > >> Document STM32 System Bus. This bus is intended to control firewall >> access for the peripherals connected to it. >> >> Signed-off-by: Gatien Chevallier >> Signed-off-by: Loic PALLARDY > Trivial comment on formatting. > >> + >> +examples: >> + - | >> + // In this example, the rng1 device refers to etzpc as its domain controller. >> + // Same goes for fmc. >> + // Access rights are verified before creating devices. >> + >> + #include >> + #include >> + #include >> + >> + etzpc: bus@5c007000 { >> + compatible = "st,stm32mp15-sys-bus"; >> + reg = <0x5c007000 0x400>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + feature-domain-controller; >> + #feature-domain-cells = <1>; >> + >> + rng1: rng@54003000 { > > Odd mixture of 4 spacing and 2 spacing in this example. > I'd suggest one or the other (slight preference for 4 space indents). > Thank you for spotting this, I'll change to 4 space indents > >> + compatible = "st,stm32-rng"; >> + reg = <0x54003000 0x400>; >> + clocks = <&rcc RNG1_K>; >> + resets = <&rcc RNG1_R>; >> + feature-domains = <&etzpc 7>; >> + status = "disabled"; >> + }; Best regards, Gatien -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy