From: Frank Wang <frawang.cn@gmail.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
william.wu@rock-chips.com, tim.chen@rock-chips.com,
yubing.zhang@rock-chips.com,
Frank Wang <frank.wang@rock-chips.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: rockchip: add rk3576 vo1-grf syscon
Date: Fri, 18 Oct 2024 14:18:35 +0800 [thread overview]
Message-ID: <d2a200aa-1301-4940-a39c-0412fe741994@gmail.com> (raw)
In-Reply-To: <ca0ee8752791f53bac23933e1582dd86@manjaro.org>
Hi Dragan,
On 2024/10/18 13:02, Dragan Simic wrote:
> Hello Frank,
>
> On 2024-10-17 04:52, Frank Wang wrote:
>> From: Frank Wang <frank.wang@rock-chips.com>
>>
>> Add rockchip,rk3576-vo1-grf syscon compatible, the vo1-grf is
>> configured in usbdp phy driver.
>>
>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>> ---
>> Changelog:
>> v2:
>> - This is a new patch adds rk3576-vo1-grf syscon.
>
> Could you, please, clarify a bit why is this additional patch
> needed in this series?
>
I mentioned in the commit content. The usbdp-phy driver select dp lanes
via configuring the vo1-grf.
Best regards,
Frank
>> v1:
>> - none
>>
>> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> index 50d727f4b76c6..fd42217ab85e7 100644
>> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
>> @@ -33,6 +33,7 @@ properties:
>> - rockchip,rk3576-usb-grf
>> - rockchip,rk3576-usbdpphy-grf
>> - rockchip,rk3576-vo0-grf
>> + - rockchip,rk3576-vo1-grf
>> - rockchip,rk3576-vop-grf
>> - rockchip,rk3588-bigcore0-grf
>> - rockchip,rk3588-bigcore1-grf
>> @@ -283,6 +284,7 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> + - rockchip,rk3576-vo1-grf
>> - rockchip,rk3588-vo-grf
>> - rockchip,rk3588-vo0-grf
>> - rockchip,rk3588-vo1-grf
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-10-18 6:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 2:52 [PATCH v2 1/3] dt-bindings: soc: rockchip: add rk3576 vo1-grf syscon Frank Wang
2024-10-17 2:52 ` [PATCH v2 2/3] dt-bindings: phy: rockchip-usbdp: add rk3576 Frank Wang
2024-10-17 2:52 ` [PATCH v2 3/3] phy: rockchip: usbdp: add rk3576 device match data Frank Wang
2024-10-17 8:25 ` [PATCH v2 1/3] dt-bindings: soc: rockchip: add rk3576 vo1-grf syscon Krzysztof Kozlowski
2024-10-17 15:35 ` (subset) " Vinod Koul
2024-10-18 5:02 ` Dragan Simic
2024-10-18 6:18 ` Frank Wang [this message]
2024-10-18 6:37 ` Dragan Simic
2024-10-18 7:34 ` Frank Wang
2024-10-18 10:52 ` Dragan Simic
2024-10-21 15:44 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2a200aa-1301-4940-a39c-0412fe741994@gmail.com \
--to=frawang.cn@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=frank.wang@rock-chips.com \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=tim.chen@rock-chips.com \
--cc=vkoul@kernel.org \
--cc=william.wu@rock-chips.com \
--cc=yubing.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox