From: Sven Peter <sven@kernel.org>
To: Janne Grunau <j@jannau.net>, Vinod Koul <vkoul@kernel.org>
Cc: asahi@lists.linux.dev, Neal Gompa <neal@gompa.dev>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH phy-next] phy: apple: apple: Check the actual ioremap return value
Date: Mon, 9 Feb 2026 17:46:20 +0100 [thread overview]
Message-ID: <d476ecff-03fc-4520-a228-662aa6752733@kernel.org> (raw)
In-Reply-To: <20260207-phy-apple-resource-err-ptr-v1-1-78735b07ed2d@jannau.net>
On 07.02.26 17:40, Janne Grunau wrote:
> The address where the devm_ioremap_resource() return value is stored is
> always a valid pointer. Check the actual return value instead as that
> that might be an error value.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/asahi/aYXvX1bYOXtYCgfC@stanley.mountain/
> Fixes: 8e98ca1e74db ("phy: apple: Add Apple Type-C PHY")
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
Reviewed-by: Sven Peter <sven@kernel.org>
Thanks,
Sven
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-02-09 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 16:40 [PATCH phy-next] phy: apple: apple: Check the actual ioremap return value Janne Grunau
2026-02-09 16:46 ` Sven Peter [this message]
2026-02-10 20:48 ` Vladimir Oltean
2026-02-15 7:58 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d476ecff-03fc-4520-a228-662aa6752733@kernel.org \
--to=sven@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=j@jannau.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neal@gompa.dev \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox