Re: [PATCH v3 01/12] dt-bindings: phy: qcom,ipq5332-uniphy-pcie: Change to PCIe/USB3 combo PHY

From: Krzysztof Kozlowski <krzk@kernel.org>
To: George Moussalem <george.moussalem@outlook.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Praveenkumar I <praveenkumar.i@oss.qualcomm.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
	Nitheesh Sekar <quic_nsekar@quicinc.com>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 01/12] dt-bindings: phy: qcom,ipq5332-uniphy-pcie: Change to PCIe/USB3 combo PHY
Date: Mon, 31 Aug 2026 14:30:23 +0200	[thread overview]
Message-ID: <d69efb1c-4ab3-4148-8b98-035377852da6@kernel.org> (raw)
In-Reply-To: <SN7PR19MB6736B881B203BF5746F0DEE39DAC2@SN7PR19MB6736.namprd19.prod.outlook.com>

On 28/08/2026 12:51, George Moussalem wrote:
> On 8/28/26 14:09, Krzysztof Kozlowski wrote:
>> On Tue, Aug 25, 2026 at 04:37:18PM +0400, George Moussalem wrote:
>>> This PHY is a PCIE/USB3 multi-purpose PHY. Initial support was added for
>>> PCIe only, so rename the binding and add support for USB3 PHY mode.
>>>
>>> The PCIe and USB physical pads are muxed and selection is done via a
>>> control register in TCSR. Add a new property to the binding to enable
>>> switching the default PCIe mux selection to USB3 mode.
>>>
>>> In addition, USB3 mode requires a 5V supply, so add a vdd-supply
>>> property for it.
>>>
>>> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
>>> ---
>>>  .../bindings/phy/qcom,ipq5332-uniphy-pcie-phy.yaml | 109 ----------------
>>>  .../phy/qcom,ipq5332-uniphy-pcie-usb3-phy.yaml     | 141 +++++++++++++++++++++
>>>  include/dt-bindings/phy/phy-qcom-qmp.h             |   4 +
>>>  3 files changed, 145 insertions(+), 109 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/phy/qcom,ipq5332-uniphy-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,ipq5332-uniphy-pcie-phy.yaml
>>> deleted file mode 100644
>>> index 6e9df81441e9..000000000000
>>
>> Please do not rename the binding. Old name was correct. New one is not,
>> otherwise please point me to the compatible like that.
> 
> I thought we had come to the conclusion it's the same device in the
> discussion in v2:
> https://lore.kernel.org/all/gn43qixdtbq5iyfqvzibdtx4lmwpkt2ieahr7oqsxxjfpldb6d@xbxhbdrq4e6b/
> 

How is it relevant to renaming of the file?

> I've split up this series into 3 as in the cover letter:
> 1. Flatten USB Controller Nodes on IPQ SoCs
>    link:
> https://lore.kernel.org/r/20260825-ipq-flatten-usb-v1-0-5c1f3170bbe9@outlook.com
> 2. Enable USB3 for Qualcomm IPQ5018 (this patch series)
> 3. Enable USB3 for Qualcomm IPQ5332 (to be submitted)

How is this relevant?

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy