Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback

[Yongxing Mou <yongxing.mou@oss.qualcomm.com>]

On 2/13/2026 7:14 PM, Konrad Dybcio wrote:
> On 2/12/26 10:04 AM, Yongxing Mou wrote:
>>
>>
>> On 2/6/2026 6:52 PM, Konrad Dybcio wrote:
>>> On 2/5/26 10:20 AM, Yongxing Mou wrote:
>>>> Introduce the com_ldo_config callback to support per‑PHY LDO
>>>> configuration.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>
>>> [...]
>>>
>>>> +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp)
>>>> +{
>>>> +    const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts;
>>>> +    u32 ldo_config;
>>>> +
>>>> +    if (!edp->is_edp)
>>>> +        ldo_config = 0x0;
>>>> +    else if (dp_opts->link_rate <= 2700)
>>>> +        ldo_config = 0xC1;
>>>
>>> lowercase hex, please
>>>
>>>> +    else
>>>> +        ldo_config = 0x81;
>>>> +
>>>> +    writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG);
>>>> +    writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG);
>>>
>>> tx1 should be dp_ops->lanes ? 2 : ldo_config : 0x00, in all cases,
>>> I believe
>>>
>>> Konrad
>> Hi, here i want to confirm again.. In the HPG main link brinup sequence, it not say write TX0/TX1 ldo_config based on the lane count. Only when we switch the lane mode,  the LDO config will be updated according to the lane count. so here do we really need this condition?
> 
> I don't believe these two cases are differentiated in your patch, unless
> you're trying to say that the hardware is smart enough to turn off the LDO
> for TX23 on its own as we switch modes, which I wouldn't bet it is and can't
> find confirmation for
> 
> Konrad
Got it. will update next patch.


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy