Re: [PATCH 5/7] media: nxp: add DesignWare MIPI CSI2 controller driver

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>, Rui Miguel Silva <rmfrfs@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Martin Kepplinger <martink@posteo.de>,
	Purism Kernel Team <kernel@puri.sm>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Eugen Hristev <eugen.hristev@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
	Alice Yuan <alice.yuan@nxp.com>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-phy@lists.infradead.org,
	"Guoniu.zhou" <guoniu.zhou@nxp.com>
Subject: Re: [PATCH 5/7] media: nxp: add DesignWare MIPI CSI2 controller driver
Date: Wed, 2 Jul 2025 08:35:42 +0200	[thread overview]
Message-ID: <daf6fb72-5849-49f7-b17a-818944eb9f1e@kernel.org> (raw)
In-Reply-To: <20250701-95_cam-v1-5-c5172bab387b@nxp.com>

On 02/07/2025 00:06, Frank Li wrote:
> +
> +static const struct of_device_id dwc_csi_device_of_match[] = {
> +	{ .compatible = "snps,dw-mipi-csi2-v150" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, dwc_csi_device_of_match);
> +
> +static struct platform_driver dwc_csi_device_driver = {
> +	.driver = {
> +		.owner          = THIS_MODULE,

That's 12 or 15 year old downstream code. Drop.

> +		.name           = "dwc-mipi-csi2",
> +		.of_match_table = dwc_csi_device_of_match,
> +		.pm             = &dwc_csi_device_pm_ops,
> +	},
> +	.probe  = dwc_csi_device_probe,
> +	.remove = dwc_csi_device_remove,
> +};
> +
> +module_platform_driver(dwc_csi_device_driver);
> +
> +MODULE_DESCRIPTION("DesignWare Core MIPI CSI2 driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform: dwc-mipi-csi2");

No, drop.

> +MODULE_AUTHOR("NXP Semiconductor, Inc.");
> 

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy