From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
Pengcheng Li <lpc.li@hisilicon.com>,
Shawn Guo <shawn.guo@linaro.org>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
David Yang <mmyangfl@gmail.com>
Subject: Re: [PATCH RFC 0/4] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy
Date: Sat, 17 Feb 2024 11:18:08 +0100 [thread overview]
Message-ID: <dd1f1b28-4bde-4d40-8022-b57d201c70ee@linaro.org> (raw)
In-Reply-To: <20240216-inno-phy-v1-0-1ab912f0533f@outlook.com>
On 16/02/2024 16:21, Yang Xiwen via B4 Relay wrote:
> This should be considered a dirty hack. The proper solution would be
> extracting write_reg logic to a separate regmap driver. Leaving only
> "write BIT(2) to address 0x6" to the PHY driver.
>
> The initial commit is already doing things wrong. The following patches
> adding hi3798mv100 support is also very confusing. The name of the
> enumeration "PHY_TYPE_x" is very misleading as if it's the phy which is
> different across SoCs. But actually it's the bus (i.e. how to write to a
> given address) which is different, not the PHY.
I have many bounces from your emails. Please do not Cc unrelated,
non-working hisilicon emails.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-02-17 10:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 15:21 [PATCH RFC 0/4] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy Yang Xiwen via B4 Relay
2024-02-16 15:21 ` [PATCH RFC 1/4] dt-binding: phy: hisi-inno-usb2: convert to YAML Yang Xiwen via B4 Relay
2024-02-17 10:14 ` Krzysztof Kozlowski
2024-02-17 10:24 ` Yang Xiwen
2024-02-17 10:29 ` Krzysztof Kozlowski
2024-02-17 10:54 ` Yang Xiwen
2024-02-17 13:39 ` Krzysztof Kozlowski
2024-02-17 13:46 ` Yang Xiwen
2024-02-17 13:14 ` Yang Xiwen
2024-02-17 13:40 ` Krzysztof Kozlowski
2024-02-16 15:21 ` [PATCH RFC 2/4] phy: hisilicon: enable clocks for every ports Yang Xiwen via B4 Relay
2024-02-16 15:21 ` [PATCH RFC 3/4] phy: hisi-inno-usb2: add support for direct MMIO Yang Xiwen via B4 Relay
2024-02-16 15:21 ` [PATCH RFC 4/4] dt-binding: phy: hisi-inno-usb2: add compatible of hisilicon,hi3798mv200-usb2-phy Yang Xiwen via B4 Relay
2024-02-17 10:16 ` Krzysztof Kozlowski
2024-02-17 10:18 ` Krzysztof Kozlowski [this message]
2024-02-17 10:58 ` [PATCH RFC 0/4] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy Yang Xiwen
2024-02-17 11:06 ` Yang Xiwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1f1b28-4bde-4d40-8022-b57d201c70ee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=kishon@kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpc.li@hisilicon.com \
--cc=mmyangfl@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox