From: Neil Armstrong <neil.armstrong@linaro.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Algea Cao <algea.cao@rock-chips.com>,
Dmitry Baryshkov <lumag@kernel.org>
Cc: kernel@collabora.com, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v6 02/11] phy: rockchip: samsung-hdptx: Use usleep_range() instead of udelay()
Date: Tue, 13 Jan 2026 09:13:11 +0100 [thread overview]
Message-ID: <ea0a9ee9-3cb1-4d08-aa6f-91bb91bda816@linaro.org> (raw)
In-Reply-To: <20260113-phy-hdptx-frl-v6-2-8d5f97419c0b@collabora.com>
On 1/13/26 00:20, Cristian Ciocaltea wrote:
> rk_hdptx_dp_reset() is allowed to sleep, hence replace the busy waiting
> with usleep_range(), to allow other threads to run.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
> index a65e96694237..89710066d70c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
> +++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
> @@ -1042,7 +1042,7 @@ static void rk_hdptx_dp_reset(struct rk_hdptx_phy *hdptx)
> reset_control_assert(hdptx->rsts[RST_INIT].rstc);
>
> reset_control_assert(hdptx->rsts[RST_APB].rstc);
> - udelay(10);
> + usleep_range(10, 15);
> reset_control_deassert(hdptx->rsts[RST_APB].rstc);
>
> regmap_update_bits(hdptx->regmap, LANE_REG(0301),
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-01-13 8:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 23:20 [PATCH v6 00/11] Add HDMI 2.1 FRL support to phy-rockchip-samsung-hdptx Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 01/11] phy: hdmi: Add HDMI 2.1 FRL configuration options Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 02/11] phy: rockchip: samsung-hdptx: Use usleep_range() instead of udelay() Cristian Ciocaltea
2026-01-13 8:13 ` Neil Armstrong [this message]
2026-01-12 23:20 ` [PATCH v6 03/11] phy: rockchip: samsung-hdptx: Fix coding style alignment Cristian Ciocaltea
2026-01-13 8:11 ` Neil Armstrong
2026-01-12 23:20 ` [PATCH v6 04/11] phy: rockchip: samsung-hdptx: Consistently use [rk_]hdptx_[tmds_] prefixes Cristian Ciocaltea
2026-01-13 8:12 ` Neil Armstrong
2026-01-12 23:20 ` [PATCH v6 05/11] phy: rockchip: samsung-hdptx: Enable lane output in common helper Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 06/11] phy: rockchip: samsung-hdptx: Cleanup *_cmn_init_seq lists Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 07/11] phy: rockchip: samsung-hdptx: Compute clk rate from PLL config Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 08/11] phy: rockchip: samsung-hdptx: Drop hw_rate driver data Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 09/11] phy: rockchip: samsung-hdptx: Switch to driver specific HDMI config Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 10/11] phy: rockchip: samsung-hdptx: Extend rk_hdptx_phy_verify_hdmi_config() helper Cristian Ciocaltea
2026-01-12 23:20 ` [PATCH v6 11/11] phy: rockchip: samsung-hdptx: Add HDMI 2.1 FRL support Cristian Ciocaltea
2026-01-21 8:52 ` [PATCH v6 00/11] Add HDMI 2.1 FRL support to phy-rockchip-samsung-hdptx Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea0a9ee9-3cb1-4d08-aa6f-91bb91bda816@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=algea.cao@rock-chips.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox