From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD347D2D108 for ; Tue, 13 Jan 2026 14:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QRsm8nHIuWNlZTb2om2H7HdcZTpz1fXdA0c91jwVgYo=; b=Q2M6hCmzg+dS+N KUZM/qK86aRZIbI8bBE59LEO1VGY8pLF6DwZp+rJk5lTdqHu1UVacaPVcSRWjSewpuDPCtHzaJh7Y qef9hgiQlzuPprkcqe7MR4WW9lKRX4N2evtUbt7iH/wJ3E+xNBmKQxtWASjV+ooIq2OofKbsnUjf5 EyrfapDzdsjbiKeLLpN8YEfjmhuSYkg+4y+i60lHdiECwVYll6t74Y/98+lWjU46v5fUBd7IwJZhX 1uX4Bo0BAycuR7QMaKjdhGBPNBoFn7O6kYNGaegRyyohyQhCO+6IRboozI0X97gmNoHjIdXGOUtjM UHa60QSDHQAVTZaWBWeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vffGE-00000007Euf-2A3j; Tue, 13 Jan 2026 14:20:42 +0000 Received: from smtp1.tecnico.ulisboa.pt ([2001:690:2100:1::15]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vffGB-00000007Et5-1CQV for linux-phy@lists.infradead.org; Tue, 13 Jan 2026 14:20:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp1.tecnico.ulisboa.pt (Postfix) with ESMTP id 5139F6003C03; Tue, 13 Jan 2026 14:20:37 +0000 (WET) X-Virus-Scanned: by amavis-2.13.0 (20230106) (Debian) at tecnico.ulisboa.pt Received: from smtp1.tecnico.ulisboa.pt ([127.0.0.1]) by localhost (smtp1.tecnico.ulisboa.pt [127.0.0.1]) (amavis, port 10025) with LMTP id 9-I0FvP7k-o5; Tue, 13 Jan 2026 14:20:34 +0000 (WET) Received: from mail1.tecnico.ulisboa.pt (mail1.ist.utl.pt [IPv6:2001:690:2100:1::b3dd:b9ac]) by smtp1.tecnico.ulisboa.pt (Postfix) with ESMTPS id 3A9A16003C17; Tue, 13 Jan 2026 14:20:34 +0000 (WET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tecnico.ulisboa.pt; s=mail2; t=1768314034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rtTEO7u089b0r7hQr05Hu+7UDpMKL6cZI20/qSEFFrs=; b=SpNlV70tDLvGsv3x3Ag8L3/ByS87trHOSx91ZCtzendOUhrwPQsi0TkZCwEVNuO3gZXq2Z NK+kwyAE39sWcdvU6G5T2y5HfERW9nro0D4aVMxFZNUBsVPj+1ITsAp+MsPl4k6UEgLG/n +jeB33YNN/WSK2qc4k97aj+APwgzT7ypkJ3fVE+7EmjwgFFD5VzJn0j7YK++BF7ID9WRWS 5MRuYHzJl6YzrMACiS9jbqT/gPuQKnkIwtO3AxiCoQpPph92k4HHbiUheYaWfOo/MI4/1v JjqHti0vi45JCB4yadfb9HHjhm2ps3cu1K3JWAfrkP4Hifytk/zEJtT3RK41cQ== Received: from [192.168.2.110] (unknown [148.63.39.39]) (Authenticated sender: ist187313) by mail1.tecnico.ulisboa.pt (Postfix) with ESMTPSA id C170A360147; Tue, 13 Jan 2026 14:20:33 +0000 (WET) Message-ID: Date: Tue, 13 Jan 2026 14:20:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] arm64: tegra: smaug: Add usb-role-switch support To: Jon Hunter , Mathias Nyman , Greg Kroah-Hartman , Thierry Reding , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20251204-diogo-tegra_phy-v1-0-51a2016d0be8@tecnico.ulisboa.pt> <20251204-diogo-tegra_phy-v1-5-51a2016d0be8@tecnico.ulisboa.pt> Content-Language: en-US From: Diogo Ivo In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260113_062039_467745_0F07A132 X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 1/12/26 22:03, Jon Hunter wrote: > > On 04/12/2025 21:27, Diogo Ivo wrote: >> The USB2 port on Smaug is configured for OTG operation but lacked the >> required 'usb-role-switch' property, leading to a failed probe and a >> non-functioning USB port. Add the property along with setting the default >> role to host. >> >> Signed-off-by: Diogo Ivo >> --- >> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/ >> arm64/boot/dts/nvidia/tegra210-smaug.dts >> index b8d854f90be7..49bf23d6f593 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts >> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts >> @@ -1809,6 +1809,8 @@ usb2-0 { >> status = "okay"; >> vbus-supply = <&usbc_vbus>; >> mode = "otg"; >> + usb-role-switch; >> + role-switch-default-mode = "host"; >> }; > > > This change does add the following warning when building with CHECK_DTBS > ... > > arch/arm64/boot/dts/nvidia/tegra210-smaug.dtb: padctl@7009f000 > (nvidia,tegra210-xusb-padctl): ports:usb2-0: 'role-switch-default-mode' > does not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra210- > xusb-padctl.yaml > > I know that there are many warnings seen for the smaug DTB, but it would > be good to ensure we don't add more. The 'role-switch-default-mode' property is read by the driver to set the initial role for the port [0] and is needed in order for the port to work when booting so in order to fix the warning this property needs to be added to the binding. As for the other warning ('connector' is a dependency of 'usb-role-switch') again I think the binding needs to be adjusted since in the Pixel C the connector node should be under the (as for now not present) cros-ec-typec node and the usb2-0 is then modeled as a remote-endpoint for the full connector. I am currently working on fixing the cros-ec-typec driver and already have a working fix for automatic role switching but in any case I think the binding is what needs changing. If you agree with this then I will add the necessary changes to the DT binding in v2. Thanks, Diogo [0]: https://elixir.bootlin.com/linux/v6.18.4/source/drivers/phy/tegra/xusb.c#L730 > Cheers > Jon -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy