From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60BA8C61DF4 for ; Fri, 24 Nov 2023 14:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2/dgpCuzi2zEKZ0dIuN9mO9kJx3KFLizsiGw9ROl538=; b=dDCKqumvGbTVUM+PO4tmzu/4C6 taf2K5VLlyYcg+M68PL4jC0UGzvYBoHvb6SnCBjr+V195yN+7reCsLZ6Y0xIZ4fc5DL3ZD9MmVhaA odMKercRBflnqteZkCixKo1bkXFliLL6w56k9G9qBUe2Ilvs2ycrRp9oB0fnqNBl6HQkmH4+CfI8P otj5cwiatk6PdDvMR8Gn+KqgfPSQLmS62KTad9k2v/Pnj7ofWFUD8HP7VpIIxngsRsP0rIz0xz2fc w/XgTfRG/y7ICCVrPjgJrEKFkWrn29G74NqYhRwX1Ycvz54IIuBnJ2IO2uxFeUWWNQ/mqY42Q5f68 MIQWziIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6XPa-007RgQ-0P; Fri, 24 Nov 2023 14:44:06 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6XPW-007Rer-2P for linux-phy@lists.infradead.org; Fri, 24 Nov 2023 14:44:04 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-332d2948170so1304359f8f.2 for ; Fri, 24 Nov 2023 06:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700837040; x=1701441840; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=JUgLL7DRnYWbwIfG5gCXLaKp2PO1r1BS/La7eMtACoY=; b=KQWK/uqP/eUfwGH3ZUaqFc6jKtcsBFJG+CuzbsqHeSwHcnkmosEsCSBpb8xz/i5Dnw KmF3DKWzBypA04KERTOWYILK/vSsU0Dh6pjGOur8nxXdE4JWOdB4/hr7ZxPTH286bseL //Q6lduZTrVHFEuxIRIpwFGqeQ7H7/V/Lt+gwNNa4Dop9/yEVqBfND6crFUOokJpzEf+ AzjaP38uUyWpSWycehyRbkExVDy3qHncHSBx9D/TagZxIGiHglOwYbM3/+8ng1/dwnKW UVeH7fyaOBzGZ2sCHxLNgoTGnok7TT+S2NpLhpJdjUT98EVhiNTQv3IHAfxY1xiLDj/Q 57ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700837040; x=1701441840; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JUgLL7DRnYWbwIfG5gCXLaKp2PO1r1BS/La7eMtACoY=; b=OCXwNFbim4cZJrlHq81yO+eZ8Nu2cxCV46MPsgIRAsWy6TzxGkNMhye7S9lXGNRp9G riONRcTNfSpw0YuOMxEo0vwNr0yA+wDs8T3l8D4M5BRdaMF8oM0h8eKpaywlx52kxeDw Ntej+OnkJ4mlAt4RQQ7XTguph6pZ40oRjE0kLQLbc4GvHpO17nbiPo1Hn4qYHDj0KQmq 799LTM6FpN3PBTmNkcGlvvIZJMp3DrsCWdlUYipfv5AIUhZyX5PxeCjNYAezxsKmwY2r HNpZzGcALtdrA4+lwrdTa6ddGJddc/ZcRvOJvEeUUjXwhtGN2yIDi1nwRXILSiTHkt8L XQ4w== X-Gm-Message-State: AOJu0YzJC3xP0spD/eQj/WmsTsjpgNfAAq0DhBui36v5ihFcoYzJ1jnj oFcSinv0xBZlljglqjs/RR8w1g== X-Google-Smtp-Source: AGHT+IG4lHpHegujO0VJykD6EDhiniG+n+uhhSQbk7AaE6VVt77PJjj8KwqZ9FApeIjXsVryvPNchA== X-Received: by 2002:a5d:6a42:0:b0:32f:8a7f:f00f with SMTP id t2-20020a5d6a42000000b0032f8a7ff00fmr2494855wrw.60.1700837040476; Fri, 24 Nov 2023 06:44:00 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:4611:6dae:b5a3:b6a4? ([2a01:e0a:982:cbb0:4611:6dae:b5a3:b6a4]) by smtp.gmail.com with ESMTPSA id i2-20020adffc02000000b00327de0173f6sm4511051wrr.115.2023.11.24.06.43.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Nov 2023 06:44:00 -0800 (PST) Message-ID: Date: Fri, 24 Nov 2023 15:43:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v9 04/12] dt-bindings: phy: amlogic,g12a-mipi-dphy-analog: drop unneeded reg property and example Content-Language: en-US, fr To: Conor Dooley Cc: Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , David Airlie , Daniel Vetter , Jagan Teki , Nicolas Belin , Vinod Koul , Kishon Vijay Abraham I , Remi Pommarel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, Rob Herring References: <20231124-amlogic-v6-4-upstream-dsi-ccf-vim3-v9-0-95256ed139e6@linaro.org> <20231124-amlogic-v6-4-upstream-dsi-ccf-vim3-v9-4-95256ed139e6@linaro.org> <20231124-felt-tip-everybody-f2a6836e52af@spud> <20231124-vowel-reversing-619f7c4e5060@spud> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20231124-vowel-reversing-619f7c4e5060@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_064402_786250_4B93D4D9 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 24/11/2023 15:41, Conor Dooley wrote: > On Fri, Nov 24, 2023 at 02:50:58PM +0100, Neil Armstrong wrote: >> Hi Conor, >> >> On 24/11/2023 13:36, Conor Dooley wrote: >>> On Fri, Nov 24, 2023 at 09:41:15AM +0100, Neil Armstrong wrote: >>>> The amlogic,g12a-mipi-dphy-analog is a feature of the simple-mfd >>>> amlogic,meson-axg-hhi-sysctrl system control register zone which is an >>>> intermixed registers zone, thus it's very hard to define clear ranges for >>>> each SoC controlled features even if possible. >>>> >>>> The amlogic,g12a-mipi-dphy-analog was wrongly documented as an independent >>>> register range, which is not the reality, thus fix the bindings by dropping >>>> the reg property now it's referred from amlogic,meson-gx-hhi-sysctrl.yaml >>>> and documented as a subnode of amlogic,meson-axg-hhi-sysctrl. >>>> >>>> Also drop the unnecessary example, the top level bindings example should >>>> be enough. >>>> >>>> Fixes: 76ab79f9726c ("dt-bindings: phy: add Amlogic G12A Analog MIPI D-PHY bindings") >>>> Signed-off-by: Neil Armstrong >>> >>> I feel like I left a tag on this one before, but I can't remember. >>> Perhaps I missed the conclusion to the discussion to the discussion with >>> Rob about whether having "reg" was desirable that lead to a tag being >>> dropped? >> >> I checked again and nope, not tag, but Rob's question was legitimate and I reworded >> and clarified the commit message following your reviews. >> On the other side you suggested a Fixes tag, which I added. >> >> The rewording is about why reg doesn't make sense on the nature of the memory >> region and it doesn't make sense here like other similar nodes. > > Okay, I thought that I had given you one. Perhaps I forgot to send, or > Rob's message came in between me asking about the Fixes tag & replying > with an Ack. Sorry about that, > Acked-by: Conor Dooley No problem thanks for your review. Neil > > Cheers, > Conor. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy