public inbox for linux-phy@lists.infradead.org
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: Roy Luo <royluo@google.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	 Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Joy Chakraborty	 <joychakr@google.com>,
	Naveen Kumar <mnkumar@google.com>,
	 linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	 kernel test robot	 <lkp@intel.com>
Subject: Re: [PATCH next] phy: google: fix build dependency for Google Tensor USB PHY
Date: Sat, 24 Jan 2026 06:52:14 +0000	[thread overview]
Message-ID: <eebefae5273bccce2d0fcd97afe3ea28bedf27cd.camel@linaro.org> (raw)
In-Reply-To: <CA+zupgwEWM4c9yK1f-Y_Cv5gk=0zYNuUb3kZyZ6O3FDRbPPvKw@mail.gmail.com>

Hi Roy,

On Fri, 2026-01-23 at 15:51 -0800, Roy Luo wrote:
> On Thu, Jan 22, 2026 at 10:28 PM André Draszik <andre.draszik@linaro.org> wrote:
> > 
> > 
> > COMPILE_TEST is not limited to ARCH_xxx. It allows drivers to be
> > compile tested even if the current build doesn't enable whatever
> > option (like TYPEC).
> > 
> > See also https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#compile-testing
> 
> "If a config symbol has a dependency, but the code controlled by the
> config symbol can still be compiled if the dependency is not met",
> TYPEC doesn't fall into this category as it's mandatory for compiling
> PHY_GOOGLE_USB.
> With "depends on TYPEC || COMPILE_TEST", this very build error
> would resurface when TYPEC=n, COMPILE_TEST=y and
> PHY_GOOGLE_USB=y. Please let me know if I missed anything.

No it wouldn't. If you look at the build log & .config from the reported 
failure, the error was because:

CONFIG_PHY_GOOGLE_USB=y
CONFIG_TYPEC=m

built-in code can not link against code from a module.

The typec APIs are all stubbed out when TYPEC=n.

Cheers,
Andre'



> 
> Thanks,
> Roy
> 
> > 
> > Cheers,
> > Andre'
> > 
> > 
> > > 
> > > [1] https://lore.kernel.org/all/CA+zupgwgfKwPYqj8G2tNf4pEXNEWA+vL2WYJPhJ16xExgko7Dw@mail.gmail.com/
> > > 
> > > Regards,
> > > Roy

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-01-24  6:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 22:21 [PATCH next] phy: google: fix build dependency for Google Tensor USB PHY Roy Luo
2026-01-21 23:06 ` Peter Griffin
2026-01-22 10:39 ` André Draszik
2026-01-22 19:00   ` Roy Luo
2026-01-23  6:28     ` André Draszik
2026-01-23 23:51       ` Roy Luo
2026-01-24  6:52         ` André Draszik [this message]
2026-01-27  2:34           ` Roy Luo
2026-01-28 19:57             ` André Draszik
2026-01-28 21:22               ` Roy Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eebefae5273bccce2d0fcd97afe3ea28bedf27cd.camel@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=joychakr@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mnkumar@google.com \
    --cc=neil.armstrong@linaro.org \
    --cc=peter.griffin@linaro.org \
    --cc=royluo@google.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox