From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
fange.zhang@oss.qualcomm.com, yongxing.mou@oss.qualcomm.com,
li.liu@oss.qualcomm.com, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH v5 07/14] phy: qcom: qmp-usbc: Move USB-only init to usb_power_on
Date: Mon, 22 Sep 2025 19:33:36 +0800 [thread overview]
Message-ID: <f53fd974-f3a9-4efa-8cca-ff639d75196f@oss.qualcomm.com> (raw)
In-Reply-To: <zjegjucwluzzh2x56mn7dpk4ocmbdrhyvubkxprpiuko5cifvv@ygvbal3vpssv>
On 9/20/2025 2:48 AM, Dmitry Baryshkov wrote:
> On Fri, Sep 19, 2025 at 10:24:24PM +0800, Xiangxu Yin wrote:
>> Move USB-only register setup from com_init to qmp_usbc_usb_power_on,
>> so it runs only for USB mode.
>
> Please rewrite the commit message to start from the problem description.
>
> With that fixed:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
Ack.
>> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
>> ---
>> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 22 ++++++++++------------
>> 1 file changed, 10 insertions(+), 12 deletions(-)
>>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-09-22 11:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 14:24 [PATCH v5 00/14] Add DisplayPort support for QCS615 platform Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 01/14] dt-bindings: phy: Add QMP USB3+DP PHY for QCS615 Xiangxu Yin
2025-09-22 19:57 ` Rob Herring (Arm)
2025-09-19 14:24 ` [PATCH v5 02/14] phy: qcom: qmp-usbc: Rename USB-specific ops to prepare for DP support Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 03/14] phy: qcom: qmp-usbc: Add DP-related fields for USB/DP switchable PHY Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 04/14] phy: qcom: qmp-usbc: Add regulator init_load support Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 05/14] phy: qcom: qmp-usbc: Move reset config into PHY cfg Xiangxu Yin
2025-09-19 16:45 ` Dmitry Baryshkov
2025-09-22 8:04 ` Xiangxu Yin
2025-09-22 9:40 ` Dmitry Baryshkov
2025-09-22 10:38 ` Xiangxu Yin
2025-09-22 9:39 ` Dmitry Baryshkov
2025-09-22 10:39 ` Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 06/14] phy: qcom: qmp-usbc: Add USB/DP switchable PHY clk register Xiangxu Yin
2025-09-19 16:46 ` Dmitry Baryshkov
2025-09-22 8:26 ` Xiangxu Yin
2025-09-22 9:40 ` Dmitry Baryshkov
2025-09-19 14:24 ` [PATCH v5 07/14] phy: qcom: qmp-usbc: Move USB-only init to usb_power_on Xiangxu Yin
2025-09-19 18:48 ` Dmitry Baryshkov
2025-09-22 11:33 ` Xiangxu Yin [this message]
2025-09-19 14:24 ` [PATCH v5 08/14] phy: qcom: qmp-usbc: Add TCSR parsing and PHY mode setting Xiangxu Yin
2025-09-19 18:29 ` Dmitry Baryshkov
2025-09-19 14:24 ` [PATCH v5 09/14] phy: qcom: qmp-usbc: Add DP PHY ops for USB/DP switchable Type-C PHYs Xiangxu Yin
2025-09-19 18:42 ` Dmitry Baryshkov
2025-09-19 14:24 ` [PATCH v5 10/14] phy: qcom: qmp-usbc: Add USB/DP exclude handling Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 11/14] phy: qcom: qmp: Add DP v2 PHY register definitions Xiangxu Yin
2025-09-19 18:42 ` Dmitry Baryshkov
2025-09-19 14:24 ` [PATCH v5 12/14] phy: qcom: qmp-usbc: Add QCS615 USB/DP PHY config and DP mode support Xiangxu Yin
2025-09-19 18:41 ` Dmitry Baryshkov
2025-09-22 6:58 ` Xiangxu Yin
2025-09-22 9:45 ` Dmitry Baryshkov
2025-09-22 11:24 ` Xiangxu Yin
2025-09-22 11:28 ` Xiangxu Yin
2025-09-22 23:38 ` Dmitry Baryshkov
2025-09-23 3:48 ` Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 13/14] drm/msm/dp: move link-specific parsing from dp_panel to dp_link Xiangxu Yin
2025-09-19 14:24 ` [PATCH v5 14/14] drm/msm/dp: Add support for lane mapping configuration Xiangxu Yin
2025-09-19 18:35 ` Dmitry Baryshkov
2025-09-22 3:23 ` Xiangxu Yin
2025-09-22 15:13 ` Rob Clark
2025-09-22 23:39 ` Dmitry Baryshkov
2025-09-23 3:38 ` Xiangxu Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f53fd974-f3a9-4efa-8cca-ff639d75196f@oss.qualcomm.com \
--to=xiangxu.yin@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fange.zhang@oss.qualcomm.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=li.liu@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=vkoul@kernel.org \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).