From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3B84EB64DB for ; Wed, 14 Jun 2023 07:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9UrPMFbL5sXCeDiyYPrZz1G5ofs2Aqo+lXdXiS2/crY=; b=B4QmsFvTW1vT0j KicagzSJTpvmsXlBamIP4FHXDRkm2JaUCOrvX+qDYWssgM9iUkPMKnUsWS1X70bYBAxfTA+vfSzgn /0lB9zZcsCPiiIi77PfWbTsjkCyztN1dE/bbrK22YvGRL6r8iJ7TQ+RtKYbf8bUTlKRjbxouiDpSX NIv4G1eU2MBlnyDoHghl91XFottC/6Z1fE5NXdpuOv//i6MJt8FhyUN6sMZjWH1IJ+kEj9QCqSvoe cCnUlrdwOARZ96wd2iM0+QS/WbR3NY/f6xRcihKj/IjEK232niqN2iLqcwFM0yp4DttOpC2NSJXsk 00fa5OuLa62k07dack2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9KhP-00AcC1-1g; Wed, 14 Jun 2023 07:13:47 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9KhK-00Ac8t-2Z for linux-phy@lists.infradead.org; Wed, 14 Jun 2023 07:13:46 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5196a728d90so85657a12.0 for ; Wed, 14 Jun 2023 00:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686726819; x=1689318819; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=esjhB6FNbC1EpA195+AAnAhSVw66W/f4eIwLMazyni8=; b=Qdmt9FtZE9pDCTgj2b/5u43jUbAH+QGW34yMXH8ELwLQaPlaOaQqFvONc/VLmRbzzv mbRB1WjOKYWr8ChYE+wGsye+zvj3Rf9QG6GUf3YAjax+r/sPr5KbZwES2CQslsL5cGd8 Dsi+K0uIjfSK7N5dwOF7yy6uGJKEXyQChR6wWtjFdHbXJbMcP+ewflU2MLR7VNZev3yn nkwayUyejXjvlCwFVASsYYy/vZ2qSPjvVmdf9wzQqSMgmquEGMOEjdY845CoGc6imcY6 jnaY2CgDyYrSZtePupztTtufCgdstxTql2RDns+378YujR/unp8diGu43Beq+wsCZj9t eM0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686726819; x=1689318819; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=esjhB6FNbC1EpA195+AAnAhSVw66W/f4eIwLMazyni8=; b=GLpqkvQRpOEWCU2/DtewcnZfyi1o12witSX2VJjdOaZPWhockyNW3eFsT8Qh2oSzLo YGa6zddWAw8wXUefhFnlwO9Krmkw6dD+Zcgl/nVb75mOOtdQn7av+5P6Fv9zVaypLbE9 Ygxf7/RBLfTfPdBbhYAS7xlJ44Vr1DVddBhORHM+ey42yGlaZzMmi3ovPZfroPi28IS5 imen3a2tv3o5lJe8f8DuNTIyULJtJVgtJssePl+Q+/xqd8ZTGj0c5dv1WoyTP4xmnRpT 36fe/brwZ089fOaRDybb4TPf0z31CyW7Uk6xMH/8I642luGU4VJSLUP4vBSzHEtEXVfu LE7w== X-Gm-Message-State: AC+VfDwLho7IFk62sa0ygc7/8CopAbHmQ+9ysYWZOCcXpyYzaxcADQzi lH8Tx0fHUVzTmu04MqpP525iSA== X-Google-Smtp-Source: ACHHUZ74GqZI5n7DD7l+seK7RspzJy2be50nrAxgF0QALAzfeJz/QPWtgJwKx1qQM3opxU4IOBMSyQ== X-Received: by 2002:aa7:d9c1:0:b0:518:6e09:425c with SMTP id v1-20020aa7d9c1000000b005186e09425cmr3395161eds.9.1686726818958; Wed, 14 Jun 2023 00:13:38 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id v26-20020aa7dbda000000b0050cc4461fc5sm7296614edt.92.2023.06.14.00.13.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 00:13:38 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 09:13:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 02/26] dt-bindings: phy: describe the Qualcomm SGMII PHY Content-Language: en-US To: Bartosz Golaszewski , Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-3-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230612092355.87937-3-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_001342_846850_43EFC729 X-CRM114-Status: UNSURE ( 8.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 12/06/2023 11:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Describe the SGMII/SerDes PHY present on the sa8775p platforms. > > Signed-off-by: Bartosz Golaszewski > +properties: > + compatible: > + const: qcom,sa8775p-dwmac-sgmii-phy > + > + reg: > + items: > + - description: serdes > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: sgmi_ref > + > + "#phy-cells": > + const: 0 > + > +additionalProperties: false Please put it after required: block. > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + - clocks > + - clock-names > + > +examples: > + - | > + #include > + serdes_phy: phy@8901000 { > + compatible = "qcom,sa8775p-dwmac-sgmii-phy"; > + reg = <0x08901000 0xe10>; > + clocks = <&gcc GCC_SGMI_CLKREF_EN>; > + clock-names = "sgmi_ref"; > + #phy-cells = <0>; > + status = "disabled"; Drop the status. With above: Reviewed-by: Krzysztof Kozlowski > + }; Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy