From: Markus Elfring <Markus.Elfring@web.de>
To: Chen Ni <nichen@iscas.ac.cn>,
linux-phy@lists.infradead.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: marvell: phy-mvebu-cp110-comphy: Remove unnecessary NULL check before clk_disable_unprepare()
Date: Tue, 27 Jan 2026 16:16:19 +0100 [thread overview]
Message-ID: <fa1ed8c5-a424-4585-914d-6d2b5b27b44a@web.de> (raw)
In-Reply-To: <20260126035551.1615453-1-nichen@iscas.ac.cn>
> clk_disable_unprepare() already checks NULL by using IS_ERR_OR_NULL.
This function calls further functions which perform known input parameter validation.
> Remove unneeded NULL check for clk here.
May two blank lines be omitted accordingly?
Regards,
Markus
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-01-27 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 3:55 [PATCH] phy: marvell: phy-mvebu-cp110-comphy: Remove unnecessary NULL check before clk_disable_unprepare() Chen Ni
2026-01-27 15:16 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1ed8c5-a424-4585-914d-6d2b5b27b44a@web.de \
--to=markus.elfring@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=nichen@iscas.ac.cn \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox