From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, vkoul@kernel.org,
neil.armstrong@linaro.org, conor+dt@kernel.org, robh@kernel.org,
olteanv@gmail.com, linux-phy@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock
Date: Thu, 08 Oct 2026 01:58:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-163502@kernel.org> (raw)
In-Reply-To: <20261008015017.3359804-3-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: fallback incompatibility for qcom,nord-snps-eusb2-phy
--
commit fde27e15de912af2a37a383a23a0f964bc729bf2
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock
This patch allows an optional second bus clock for the AHB2PHY bridge.
It requires this clock specifically for qcom,nord-snps-eusb2-phy, while
keeping other compatibles limited to the single ref clock.
> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> index 931cd0e7d297e..67f2a587e65cc 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
[ ... ]
> @@ -77,6 +81,24 @@ allOf:
> required:
> - resets
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,nord-snps-eusb2-phy
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + clock-names:
> + minItems: 2
[Severity: Medium]
Since Nord requires an additional bus clock for register access, is it
truly backward compatible with the sm8550 fallback?
Currently, properties:compatible requires Nord to use the sm8550 fallback:
properties:
compatible:
oneOf:
- items:
- enum:
- qcom,nord-snps-eusb2-phy
...
- const: qcom,sm8550-snps-eusb2-phy
If an older kernel uses the fallback driver to probe the Nord hardware, it
will only enable the ref clock. This will leave the AHB2PHY bridge clock
disabled, leading to register access timeouts (-110) during probe.
Should qcom,nord-snps-eusb2-phy be removed from the sm8550 fallback list
since it cannot be safely driven by the sm8550 driver?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008015017.3359804-1-shengchao.guo@oss.qualcomm.com?part=2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-10-08 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 1:50 [PATCH 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord Shawn Guo
2026-10-08 1:50 ` [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Nord cfg_ahb clock Shawn Guo
2026-10-08 1:59 ` sashiko-bot
2026-10-08 1:50 ` [PATCH 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock Shawn Guo
2026-10-08 1:58 ` sashiko-bot [this message]
2026-10-08 1:50 ` [PATCH 3/3] phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-163502@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox