Re: [PATCH v2 3/8] dt-bindings: media: Add CAMSS device for Hawi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: media: missing data-lanes required property in CAMSS endpoint schema
--

commit 18094c7169d82b9037445f511f9e26e4a55cc448
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

dt-bindings: media: Add CAMSS device for Hawi

This patch adds bindings for the Camera Subsystem (CAMSS) on the Qualcomm Hawi
platform. The CAMSS IP includes various components like CSIPHY, TPG, CSID,
and VFE.

> diff --git a/Documentation/devicetree/bindings/media/qcom,hawi-camss.yaml b/Documentation/devicetree/bindings/media/qcom,hawi-camss.yaml
> new file mode 100644
> index 0000000000000..5bf0dca3d2462
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,hawi-camss.yaml
[ ... ]
> +    patternProperties:
> +      "^port@[0-5]$":
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description:
> +          Input ports for receiving CSI data on CSIPHY 0-5.
> +
> +        properties:
> +          endpoint:
> +            $ref: video-interfaces.yaml#
> +            unevaluatedProperties: false
> +
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +              bus-type:
> +                enum:
> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY

[Severity: Medium]
Should data-lanes be added to a required array for this endpoint?

Device tree configurations missing the data-lanes property will silently pass
schema validation but fail at runtime. The V4L2 CAMSS driver relies on the
data-lanes property to properly program the CSID hardware for lane extraction.

Omitting it from a required array defeats the purpose of the YAML schema
constraints.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-hawi-maili-camss-v2-0-fc93222da89c@oss.qualcomm.com?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy