Re: [PATCH v5 2/3] phy: cix: Add CIX Sky1 USB3 PHY driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] phy: cix: missing select REGMAP for PHY_CIX_USB3 in Kconfig
--

commit d964298ad6351b3e6e7c48b5d622d1449937080f
Author: Hongliang Yang (杨宏亮) <hongliang.yang@cixtech.com>

phy: cix: Add CIX Sky1 USB3 PHY driver

This commit adds a PHY driver for the multi-port Cadence SD0803 USB3 PHY found
on CIX Sky1 SoCs, handling initialization, reset, and clock management.

> diff --git a/drivers/phy/cix/Kconfig b/drivers/phy/cix/Kconfig
> new file mode 100644
> index 0000000000000..aaa2eb9d45527
> --- /dev/null
> +++ b/drivers/phy/cix/Kconfig
> @@ -0,0 +1,20 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Phy drivers for Cix PHYs
> +#
> +
> +if ARCH_CIX || COMPILE_TEST
> +
> +config PHY_CIX_USB3
> +	tristate "Cix USB3 PHY Driver"
> +	depends on OF && HAS_IOMEM
> +	select GENERIC_PHY

[Severity: Low]
Does PHY_CIX_USB3 in drivers/phy/cix/Kconfig also need to select REGMAP?

In drivers/phy/cix/phy-cix-usb3.c, the driver defines cix_u3phy_regmap_cfg as
struct regmap_config, calls regmap_multi_reg_write() in sky1_u3phy_init(), and
calls devm_regmap_init() in cix_u3phy_probe():

drivers/phy/cix/phy-cix-usb3.c:sky1_u3phy_init() {
	...
		ret = regmap_multi_reg_write(u3phy->phy_regmap, sky1_u3phy_conf,
					     ARRAY_SIZE(sky1_u3phy_conf));
	...
}

drivers/phy/cix/phy-cix-usb3.c:cix_u3phy_probe() {
	...
	u3phy->phy_regmap = devm_regmap_init(dev, NULL, u3phy, &cix_u3phy_regmap_cfg);
	...
}

In include/linux/regmap.h, struct regmap_config, devm_regmap_init(), and
regmap_multi_reg_write() are guarded by CONFIG_REGMAP without fallback stubs
when CONFIG_REGMAP is disabled. If CONFIG_PHY_CIX_USB3 is enabled in a
configuration where no other option selects REGMAP, building phy-cix-usb3.o
will fail due to an incomplete struct regmap_config type and implicit function
declarations.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103074913.1971025-1-hongliang.yang@cixtech.com?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy