From: sashiko-bot@kernel.org
To: Soheyb <soheyb_boulaa@proton.me>
Cc: linux-phy@lists.infradead.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v2 1/3] phy: exynos5-usbdrd: power the Exynos2200 phy down when its init fails
Date: Wed, 11 Nov 2026 03:32:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-208200@kernel.org> (raw)
In-Reply-To: <20261111032309.3365794-2-soheyb_boulaa@proton.me>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] phy: exynos5-usbdrd: single-word name in Signed-off-by and
Author trailers
--
commit ea360718642a10fc523396c37cb054fd6d6668fb
Author: Soheyb <soheyb_boulaa@proton.me>
> phy: exynos5-usbdrd: power the Exynos2200 phy down when its init fails
>
> exynos2200_usbdrd_phy_init() enables the regulators of the UTMI phy and
> takes the phy out of isolation in the PMU before it enables the clocks.
> When clk_bulk_prepare_enable() fails, it returns without undoing
> either. The phy core does not count a failed init, so no exit undoes
> them later: the phy stays out of isolation, and its supplies stay
> enabled, until an init and an exit succeed.
>
> Isolate the phy again and disable the UTMI regulators when the clocks
> or the phy-specific init fail. The phy-specific init does not fail yet;
> the next patch makes the UTMI init return the result of the init of the
> high-speed phy.
>
> Fixes: cc52a697f87e ("phy: exynos5-usbdrd: support Exynos USBDRD 3.2 4nm controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Soheyb <soheyb_boulaa@proton.me>
[Severity: High]
Could the Author header and Signed-off-by tag use a full real name (for
example, Soheyb Boulaa) instead of a single-word name, as required by
Documentation/process/submitting-patches.rst for the Developer's
Certificate of Origin?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111032309.3365794-1-soheyb_boulaa@proton.me?part=1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-11 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 3:23 [PATCH v2 0/3] phy: exynos5-usbdrd: fix HS phy init count on Exynos2200 Soheyb
2026-11-11 3:23 ` [PATCH v2 1/3] phy: exynos5-usbdrd: power the Exynos2200 phy down when its init fails Soheyb
2026-11-11 3:32 ` sashiko-bot [this message]
2026-11-11 3:23 ` [PATCH v2 2/3] phy: exynos5-usbdrd: return the Exynos2200 high-speed phy init error Soheyb
2026-11-11 3:23 ` [PATCH v2 3/3] phy: exynos5-usbdrd: fix HS phy init count imbalance on Exynos2200 Soheyb
2026-11-11 3:39 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208200@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=soheyb_boulaa@proton.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox