From: sashiko-bot@kernel.org
To: "Krishna Kurapati" <krishna.kurapati@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v2] phy: qualcomm: phy-qcom-eusb2-repeater: Fix SMB Power leakage issue
Date: Thu, 12 Nov 2026 08:46:59 +0000 [thread overview]
Message-ID: <sashiko-outbox-210782@kernel.org> (raw)
In-Reply-To: <20261112-smb-repeater-power-leakage-v2-1-0f8ee55c4962@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] phy: qcom: eusb2-repeater: missing Fixes trailer for
eusb2_repeater_exit()
--
commit 586f2c8bff99c34d26b4b891f2ddab55f000c68f
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> phy: qualcomm: phy-qcom-eusb2-repeater: Fix SMB Power leakage issue
>
> On Glymur, it is observed that although the exit call is done, there is a
> power leakage seen on SMB2370 charger (which embeds the eUSB2 module as
> well). As per recommendation of HW team, disable the repeater during the
> exit call to prevent this power leakage.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
[Severity: Low]
Since eusb2_repeater_exit() has left EUSB2_EN_CTL1 enabled since the
driver was introduced, should this include a Fixes tag?
Fixes: 56d77c9a10d9 ("phy: qcom: Add QCOM SNPS eUSB2 repeater driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-smb-repeater-power-leakage-v2-1-0f8ee55c4962@oss.qualcomm.com?part=1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-12 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:37 [PATCH v2] phy: qualcomm: phy-qcom-eusb2-repeater: Fix SMB Power leakage issue Krishna Kurapati
2026-11-12 8:46 ` sashiko-bot [this message]
2026-11-12 9:07 ` Vinod Koul
2026-11-12 9:13 ` Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210782@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox