Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, robh@kernel.org,
	conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
	olteanv@gmail.com
Subject: Re: [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header
Date: Mon, 16 Nov 2026 13:30:21 +0000	[thread overview]
Message-ID: <sashiko-outbox-217079@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-10-e3d3bf0e2c49@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] phy: qcom: edp: duplicate QSERDES v6 COM register definitions in
  v8-nord header
--

commit 6ae0c395ca0665ea9d8f96120d2aff620150f574
Author: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>

phy: qcom: edp: Add Nord-specific QSERDES COM register header

This commit adds a header defining the QSERDES COM register offsets for
the Nord DisplayPort QMP PHY.

> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h
> new file mode 100644
> index 0000000000000..f38b48dae39e3
> --- /dev/null
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h
> @@ -0,0 +1,51 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2026 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#ifndef QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_
> +#define QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_
> +
> +/* Nord DP QMP PHY - QSERDES COM registers (relocated from v8 base offsets) */
> +#define NORD_DP_QSERDES_COM_HSCLK_SEL_1			0x03c
> +#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE1_MODE0	0x058
> +#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE2_MODE0	0x05c
> +#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE1_MODE0	0x060
> +#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE2_MODE0	0x064
> +#define NORD_DP_QSERDES_COM_CP_CTRL_MODE0		0x070
> +#define NORD_DP_QSERDES_COM_PLL_RCTRL_MODE0		0x074
> +#define NORD_DP_QSERDES_COM_PLL_CCTRL_MODE0		0x078
> +#define NORD_DP_QSERDES_COM_CORECLK_DIV_MODE0		0x07c
> +#define NORD_DP_QSERDES_COM_LOCK_CMP1_MODE0		0x080
> +#define NORD_DP_QSERDES_COM_LOCK_CMP2_MODE0		0x084
> +#define NORD_DP_QSERDES_COM_DEC_START_MODE0		0x088
> +#define NORD_DP_QSERDES_COM_DIV_FRAC_START1_MODE0	0x090
> +#define NORD_DP_QSERDES_COM_DIV_FRAC_START2_MODE0	0x094
> +#define NORD_DP_QSERDES_COM_DIV_FRAC_START3_MODE0	0x098
> +#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN0_MODE0	0x0a0
> +#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN1_MODE0	0x0a4
> +#define NORD_DP_QSERDES_COM_VCO_TUNE1_MODE0		0x0a8
> +#define NORD_DP_QSERDES_COM_VCO_TUNE2_MODE0		0x0ac
> +#define NORD_DP_QSERDES_COM_BG_TIMER			0x0bc
> +#define NORD_DP_QSERDES_COM_SSC_EN_CENTER		0x0c0
> +#define NORD_DP_QSERDES_COM_SSC_ADJ_PER1		0x0c4
> +#define NORD_DP_QSERDES_COM_SSC_PER1			0x0cc
> +#define NORD_DP_QSERDES_COM_SSC_PER2			0x0d0
> +#define NORD_DP_QSERDES_COM_BIAS_EN_CLKBUFLR_EN	0x0dc
> +#define NORD_DP_QSERDES_COM_CLK_ENABLE1			0x0e0
> +#define NORD_DP_QSERDES_COM_SYS_CLK_CTRL		0x0e4
> +#define NORD_DP_QSERDES_COM_SYSCLK_BUF_ENABLE		0x0e8
> +#define NORD_DP_QSERDES_COM_PLL_IVCO			0x0f4
> +#define NORD_DP_QSERDES_COM_SYSCLK_EN_SEL		0x110
> +#define NORD_DP_QSERDES_COM_RESETSM_CNTRL		0x118
> +#define NORD_DP_QSERDES_COM_LOCK_CMP_EN			0x120
> +#define NORD_DP_QSERDES_COM_VCO_TUNE_CTRL		0x13c
> +#define NORD_DP_QSERDES_COM_VCO_TUNE_MAP		0x140
> +#define NORD_DP_QSERDES_COM_CLK_SELECT			0x164
> +#define NORD_DP_QSERDES_COM_CORE_CLK_EN			0x170
> +#define NORD_DP_QSERDES_COM_CMN_CONFIG_1		0x174
> +#define NORD_DP_QSERDES_COM_SVS_MODE_CLK_SEL		0x17c
> +#define NORD_DP_QSERDES_COM_CMN_STATUS			0x1d0
> +#define NORD_DP_QSERDES_COM_C_READY_STATUS		0x1f8

[Severity: Low]
Can Nord reuse the existing QSERDES_V6_COM_* definitions from
drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h instead of introducing
this SoC-specific header?

All 40 NORD_DP_QSERDES_COM_* register offsets defined here are identical to
the existing QSERDES_V6_COM_* definitions.  Moreover,
drivers/phy/qualcomm/phy-qcom-edp.c already includes
phy-qcom-qmp-qserdes-com-v6.h and provides v6 COM helpers (such as
qcom_edp_phy_power_on_v6(), qcom_edp_phy_com_resetsm_cntrl_v6(), and
qcom_edp_com_bias_en_clkbuflr_v6()), and nord_usb3dpphy_cfg in
drivers/phy/qualcomm/phy-qcom-qmp-combo.c already uses qmp_v6_dp_serdes_tbl
with the QSERDES_V6_COM_* definitions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=10

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-11-16 13:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
2026-11-16 13:31   ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
2026-11-16 13:38   ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
2026-11-16 13:47   ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
2026-11-16 13:29   ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
2026-11-16 13:30   ` sashiko-bot [this message]
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
2026-11-16 13:44   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217079@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=nabige.aala@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox