Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Louis-Alexis Eyraud" <louisalexis.eyraud@collabora.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-scsi@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v15 13/23] scsi: ufs: mediatek: Remove vendor kernel quirks cruft
Date: Thu, 19 Nov 2026 15:17:51 +0000	[thread overview]
Message-ID: <sashiko-outbox-223360@kernel.org> (raw)
In-Reply-To: <20261119-mt8196-ufs-v15-13-aae1eb0382e8@collabora.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] scsi: ufs: mediatek: dead VCC definitions left in
  ufs-mediatek-sip.h
--

commit 6eb15fdb7923519860f06ff3289f50b279237ee3
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

scsi: ufs: mediatek: Remove vendor kernel quirks cruft

This commit removes the ufs_mtk_vreg_fix_vcc() and
ufs_mtk_vreg_fix_vccqx() regulator fixup helpers and their calls from
ufs_mtk_fixup_dev_quirks().

> diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
> index 907b5fe6eb22c..fec0fb24e7a2c 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -1068,73 +1068,6 @@ static void ufs_mtk_init_clocks(struct ufs_hba *hba)
>  	}
>  }
>  
> -#define MAX_VCC_NAME 30
> -static int ufs_mtk_vreg_fix_vcc(struct ufs_hba *hba)
> -{
> -	struct ufs_vreg_info *info = &hba->vreg_info;
> -	struct device_node *np = hba->dev->of_node;
> -	struct device *dev = hba->dev;
> -	char vcc_name[MAX_VCC_NAME];
> -	struct arm_smccc_res res;
> -	int err, ver;
> -
> -	if (info->vcc)
> -		return 0;
> -
> -	if (of_property_read_bool(np, "mediatek,ufs-vcc-by-num")) {
> -		ufs_mtk_get_vcc_num(res);
> -		if (res.a1 > UFS_VCC_NONE && res.a1 < UFS_VCC_MAX)
> -			snprintf(vcc_name, MAX_VCC_NAME, "vcc-opt%lu", res.a1);
> -		else
> -			return -ENODEV;

[Severity: Low]
Should UFS_MTK_SIP_GET_VCC_NUM, enum ufs_mtk_vcc_num, and
ufs_mtk_get_vcc_num() in drivers/ufs/host/ufs-mediatek-sip.h also be
removed now that ufs_mtk_vreg_fix_vcc() was their only user?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-mt8196-ufs-v15-0-aae1eb0382e8@collabora.com?part=13

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-11-19 15:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:05 [PATCH v15 00/23] MediaTek UFS Cleanup and MT8196 Enablement Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 01/23] dt-bindings: phy: Add mediatek,mt8196-ufsphy variant Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 02/23] dt-bindings: ufs: mediatek,ufs: Complete the binding Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 03/23] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 04/23] scsi: ufs: mediatek: Move MTK_SIP_UFS_CONTROL to mtk_sip_svc.h Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 05/23] phy: mediatek: ufs: Add support for resets Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 06/23] scsi: ufs: mediatek: Rework resets Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 07/23] scsi: ufs: mediatek: Rework 0.9V regulator Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 08/23] scsi: ufs: mediatek: Add dual 0.9V supply support Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 09/23] scsi: ufs: mediatek: Rework init function Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 10/23] scsi: ufs: mediatek: Rework the crypt-boost stuff Louis-Alexis Eyraud
2026-11-19 15:05 ` [PATCH v15 11/23] scsi: ufs: mediatek: Handle misc host voltage regulators Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 12/23] scsi: ufs: mediatek: Remove undocumented downstream reset cruft Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 13/23] scsi: ufs: mediatek: Remove vendor kernel quirks cruft Louis-Alexis Eyraud
2026-11-19 15:17   ` sashiko-bot [this message]
2026-11-19 15:06 ` [PATCH v15 14/23] scsi: ufs: mediatek: Use the common PHY framework Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 15/23] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 16/23] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 17/23] scsi: ufs: mediatek: Clean up logging prints Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 18/23] scsi: ufs: mediatek: Rework ufs_mtk_wait_idle_state Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 19/23] scsi: ufs: mediatek: Don't acquire dvfsrc-vcore twice Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 20/23] scsi: ufs: mediatek: Rework hardware version reading Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 21/23] scsi: ufs: mediatek: Remove ret local from link_startup_notify Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 22/23] scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" Louis-Alexis Eyraud
2026-11-19 15:06 ` [PATCH v15 23/23] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Louis-Alexis Eyraud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223360@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=louisalexis.eyraud@collabora.com \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox